Patchwork [bitbake-devel,0/6] Hob tweaks

login
register
mail settings
Submitter Joshua Lock
Date March 20, 2012, 12:18 a.m.
Message ID <cover.1332202341.git.josh@linux.intel.com>
Download mbox
Permalink /patch/23825/
State New
Headers show

Pull-request

git://github.com/incandescant/bitbake josh/hob

Comments

Joshua Lock - March 20, 2012, 12:18 a.m.
Here's a series of patches to polish the Hob GUI: some minor tweaks to remove
redundant calls and API, a couple of HIG related tweaks to buttons, a change to
the persistenttooltip to try and match the close position of the window manager
(i.e. running under Unity on Ubuntu the close button on the persistent tooltip
will appear on the left) and finally a change to the layer dialogue implementation
so that it more closely matches the interaction design (this is still pending
some designer feedback on visuals and whether to remove some labels but they can
easily be implemented as iterative patches on top of these).

Cheers,

Joshua

The following changes since commit 5a1e62a8cdd4f0253b0dc59046b3b4c3186af461:

  bitbake/fetch2: Fix typo which broke use of tarballs (2012-03-16 23:44:08 +0000)

are available in the git repository at:
  git://github.com/incandescant/bitbake josh/hob
  https://github.com/incandescant/bitbake/tree/josh/hob
  git://git.yoctoproject.org/poky-contrib josh/hob
  http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=josh/hob

Joshua Lock (6):
  ui/crumbs/hig: use close rather than OK for dismis button
  ui/crumbs: remove unused return value from append_toolbar_button
  ui/crumbs/hobpage: no need to force a Toolbar button type
  ui/crumbs/persistenttooltip: try to reflect WM close button position
  ui/crumbs/builder: remove OK/Cancel buttons on Layer dialog. Use
    Close.
  ui/crumbs/hig: make the layer selection dialogue more closely match
    design

 lib/bb/ui/crumbs/builder.py                |    3 +-
 lib/bb/ui/crumbs/hig.py                    |   98 +++++++++++++++++++++-------
 lib/bb/ui/crumbs/hobpages.py               |    6 +-
 lib/bb/ui/crumbs/imageconfigurationpage.py |    6 +-
 lib/bb/ui/crumbs/imagedetailspage.py       |    2 +-
 lib/bb/ui/crumbs/persistenttooltip.py      |   24 +++++++-
 6 files changed, 105 insertions(+), 34 deletions(-)
Richard Purdie - March 20, 2012, 2:34 p.m.
On Mon, 2012-03-19 at 17:18 -0700, Joshua Lock wrote:
> Here's a series of patches to polish the Hob GUI: some minor tweaks to remove
> redundant calls and API, a couple of HIG related tweaks to buttons, a change to
> the persistenttooltip to try and match the close position of the window manager
> (i.e. running under Unity on Ubuntu the close button on the persistent tooltip
> will appear on the left) and finally a change to the layer dialogue implementation
> so that it more closely matches the interaction design (this is still pending
> some designer feedback on visuals and whether to remove some labels but they can
> easily be implemented as iterative patches on top of these).
> 
> Cheers,
> 
> Joshua
> 
> The following changes since commit 5a1e62a8cdd4f0253b0dc59046b3b4c3186af461:
> 
>   bitbake/fetch2: Fix typo which broke use of tarballs (2012-03-16 23:44:08 +0000)
> 
> are available in the git repository at:
>   git://github.com/incandescant/bitbake josh/hob
>   https://github.com/incandescant/bitbake/tree/josh/hob
>   git://git.yoctoproject.org/poky-contrib josh/hob
>   http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=josh/hob
> 
> Joshua Lock (6):
>   ui/crumbs/hig: use close rather than OK for dismis button
>   ui/crumbs: remove unused return value from append_toolbar_button
>   ui/crumbs/hobpage: no need to force a Toolbar button type
>   ui/crumbs/persistenttooltip: try to reflect WM close button position
>   ui/crumbs/builder: remove OK/Cancel buttons on Layer dialog. Use
>     Close.
>   ui/crumbs/hig: make the layer selection dialogue more closely match
>     design

I've merged the first four, the last two seemed to be being discussed...

Cheers,

Richard