Patchwork [bitbake-devel] runningbuild.py: fix goggle ui

login
register
mail settings
Submitter Eric BENARD
Date March 19, 2012, 11:56 a.m.
Message ID <1332158179-2776-1-git-send-email-eric@eukrea.com>
Download mbox | patch
Permalink /patch/23799/
State Accepted
Commit 815c113120b73331ecf32d6f57bc034f379bed43
Headers show

Comments

Eric BENARD - March 19, 2012, 11:56 a.m.
* goggle ui actually fails with :
Traceback (most recent call last):
  File ".../bitbake/lib/bb/ui/goggle.py", line 35, in event_handle_idle_func
    build.handle_event (event, pbar)
  File ".../bitbake/lib/bb/ui/crumbs/runningbuild.py", line 234, in handle_event
    pbar.update(0, None, bb.event.getName(event))
TypeError: update() takes exactly 3 arguments (4 given)

Signed-off-by: Eric Bénard <eric@eukrea.com>
---
 lib/bb/ui/crumbs/runningbuild.py |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Richard Purdie - March 20, 2012, 2:13 p.m.
On Mon, 2012-03-19 at 12:56 +0100, Eric Bénard wrote:
> * goggle ui actually fails with :
> Traceback (most recent call last):
>   File ".../bitbake/lib/bb/ui/goggle.py", line 35, in event_handle_idle_func
>     build.handle_event (event, pbar)
>   File ".../bitbake/lib/bb/ui/crumbs/runningbuild.py", line 234, in handle_event
>     pbar.update(0, None, bb.event.getName(event))
> TypeError: update() takes exactly 3 arguments (4 given)
> 
> Signed-off-by: Eric Bénard <eric@eukrea.com>

Merged to master, thanks.

Richard

Patch

diff --git a/lib/bb/ui/crumbs/runningbuild.py b/lib/bb/ui/crumbs/runningbuild.py
index 718f692..10ca394 100644
--- a/lib/bb/ui/crumbs/runningbuild.py
+++ b/lib/bb/ui/crumbs/runningbuild.py
@@ -231,8 +231,8 @@  class RunningBuild (gobject.GObject):
                                       HobColors.OK,
                                       0))
             if pbar:
-                pbar.update(0, None, bb.event.getName(event))
-                pbar.set_title()
+                pbar.update(0, self.progress_total)
+                pbar.set_title(bb.event.getName(event))
 
         elif isinstance(event, bb.event.BuildCompleted):
             failures = int (event._failures)