diff mbox series

[25/27] gdb: enable python PACKAGECONFIG

Message ID 20230509172344.1516743-25-alex@linutronix.de
State New
Headers show
Series [01/27] insane.bbclass: add a SUMMARY/HOMEPAGE check (oe-core recipes only) | expand

Commit Message

Alexander Kanavin May 9, 2023, 5:23 p.m. UTC
This is required by latest valgrind ptests.

Signed-off-by: Alexander Kanavin <alex@linutronix.de>
---
 meta/recipes-devtools/gdb/gdb-common.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ross Burton May 18, 2023, 3:51 p.m. UTC | #1
On 9 May 2023, at 18:23, Alexander Kanavin via lists.openembedded.org <alex.kanavin=gmail.com@lists.openembedded.org> wrote:
> 
> This is required by latest valgrind ptests.
> 
> Signed-off-by: Alexander Kanavin <alex@linutronix.de>
> ---
> meta/recipes-devtools/gdb/gdb-common.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/gdb/gdb-common.inc b/meta/recipes-devtools/gdb/gdb-common.inc
> index 9db61b785f3..5a41cd17dc6 100644
> --- a/meta/recipes-devtools/gdb/gdb-common.inc
> +++ b/meta/recipes-devtools/gdb/gdb-common.inc
> @@ -30,7 +30,7 @@ EXTRA_OECONF = "--disable-gdbtk --disable-x --disable-werror \
>                 --with-libgmp-prefix=${STAGING_EXECPREFIXDIR} \
> "
> 
> -PACKAGECONFIG ??= "readline ${@bb.utils.filter('DISTRO_FEATURES', 'debuginfod', d)}"
> +PACKAGECONFIG ??= "readline ${@bb.utils.filter('DISTRO_FEATURES', 'debuginfod', d)} python”

This means that gdb hard-depends on python, can we split that out into a separate gdb-python package so we don’t pull the whole Python stack in with gdb?

Ross
Alexander Kanavin May 19, 2023, 9:58 a.m. UTC | #2
On Thu, 18 May 2023 at 17:52, Ross Burton <Ross.Burton@arm.com> wrote:
> > -PACKAGECONFIG ??= "readline ${@bb.utils.filter('DISTRO_FEATURES', 'debuginfod', d)}"
> > +PACKAGECONFIG ??= "readline ${@bb.utils.filter('DISTRO_FEATURES', 'debuginfod', d)} python”
>
> This means that gdb hard-depends on python, can we split that out into a separate gdb-python package so we don’t pull the whole Python stack in with gdb?

Yes, I just sent a revised patchset for this.

Alex
Alexander Kanavin May 22, 2023, 11:14 a.m. UTC | #3
On Fri, 19 May 2023 at 11:59, Alexander Kanavin via
lists.openembedded.org <alex.kanavin=gmail.com@lists.openembedded.org>
wrote:
>
> On Thu, 18 May 2023 at 17:52, Ross Burton <Ross.Burton@arm.com> wrote:
> > > -PACKAGECONFIG ??= "readline ${@bb.utils.filter('DISTRO_FEATURES', 'debuginfod', d)}"
> > > +PACKAGECONFIG ??= "readline ${@bb.utils.filter('DISTRO_FEATURES', 'debuginfod', d)} python”
> >
> > This means that gdb hard-depends on python, can we split that out into a separate gdb-python package so we don’t pull the whole Python stack in with gdb?
>
> Yes, I just sent a revised patchset for this.

So splitting python modules and rdepends into a separate gdb-python
package doesn't quite work, as /usr/bin/gdb directly links with
libpython and then loads its own python modules on startup. But it's
enough to rdepend only on python3-core/codecs, not the whole python3.
I'll revise it once more.

Alex
diff mbox series

Patch

diff --git a/meta/recipes-devtools/gdb/gdb-common.inc b/meta/recipes-devtools/gdb/gdb-common.inc
index 9db61b785f3..5a41cd17dc6 100644
--- a/meta/recipes-devtools/gdb/gdb-common.inc
+++ b/meta/recipes-devtools/gdb/gdb-common.inc
@@ -30,7 +30,7 @@  EXTRA_OECONF = "--disable-gdbtk --disable-x --disable-werror \
                 --with-libgmp-prefix=${STAGING_EXECPREFIXDIR} \
 "
 
-PACKAGECONFIG ??= "readline ${@bb.utils.filter('DISTRO_FEATURES', 'debuginfod', d)}"
+PACKAGECONFIG ??= "readline ${@bb.utils.filter('DISTRO_FEATURES', 'debuginfod', d)} python"
 # Use --without-system-readline to compile with readline 5.
 PACKAGECONFIG[readline] = "--with-system-readline,--without-system-readline,readline"
 PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without-python,python3,python3 python3-codecs"