Patchwork [7/7] git: fix packaging warnings

login
register
mail settings
Submitter Nitin A Kamble
Date March 16, 2012, 7 p.m.
Message ID <a1f5c268db3260e44e705a22e67d54185a83e4e3.1331924359.git.nitin.a.kamble@intel.com>
Download mbox | patch
Permalink /patch/23739/
State Accepted
Commit b2dcb79c8c713ffb25d49a355fdb1bfa97d3c10d
Headers show

Comments

Nitin A Kamble - March 16, 2012, 7 p.m.
From: Nitin A Kamble <nitin.a.kamble@intel.com>

This commits fixes these packaging warnings
 WARNING: For recipe git, the following files/directories were installed
but not shipped in any package:
 WARNING:   /usr/lib/perl-native
 WARNING:   /usr/lib/perl-native/perl
 WARNING:   /usr/lib/perl-native/perl/5.14.2
 WARNING:   /usr/lib/perl-native/perl/5.14.2/Git.pm
 WARNING:   /usr/lib/perl-native/perl/5.14.2/perllocal.pod
 WARNING:   /usr/lib/perl-native/perl/5.14.2/auto
 WARNING:   /usr/lib/perl-native/perl/5.14.2/auto/Git
 WARNING:   /usr/lib/perl-native/perl/5.14.2/auto/Git/.packlist

PR not bumber because no change in the output packages.

Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
---
 meta/recipes-devtools/git/git.inc |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Paul Menzel - March 17, 2012, 10:16 a.m.
Dear Nitin,


Am Freitag, den 16.03.2012, 12:00 -0700 schrieb nitin.a.kamble@intel.com:
> From: Nitin A Kamble <nitin.a.kamble@intel.com>
> 
> This commits fixes these packaging warnings
>  WARNING: For recipe git, the following files/directories were installed
> but not shipped in any package:
>  WARNING:   /usr/lib/perl-native
>  WARNING:   /usr/lib/perl-native/perl
>  WARNING:   /usr/lib/perl-native/perl/5.14.2
>  WARNING:   /usr/lib/perl-native/perl/5.14.2/Git.pm
>  WARNING:   /usr/lib/perl-native/perl/5.14.2/perllocal.pod
>  WARNING:   /usr/lib/perl-native/perl/5.14.2/auto
>  WARNING:   /usr/lib/perl-native/perl/5.14.2/auto/Git
>  WARNING:   /usr/lib/perl-native/perl/5.14.2/auto/Git/.packlist
> 
> PR not bumber because no change in the output packages.

bumpe*d*

> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> ---
>  meta/recipes-devtools/git/git.inc |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/meta/recipes-devtools/git/git.inc b/meta/recipes-devtools/git/git.inc
> index ca13ffd..be3831b 100644
> --- a/meta/recipes-devtools/git/git.inc
> +++ b/meta/recipes-devtools/git/git.inc
> @@ -16,6 +16,7 @@ do_install () {
>  	oe_runmake install DESTDIR="${D}" bindir=${bindir} \
>  		template_dir=${datadir}/git-core/templates \
>  		GIT_PYTHON_DIR=${D}${datadir}/git-core/python
> +	rm -rf ${D}${libdir}/perl-native
>  }
>  
>  do_install_append_virtclass-native() {
> @@ -47,6 +48,7 @@ RDEPENDS_${PN}-perltools = "${PN} perl perl-module-file-path findutils"
>  PACKAGES =+ "${PN}-python"
>  FILES_${PN}-python = "${libdir}/python*"
>  
> +

This extra line seems to have been snuck in.

>  # git-tk package with gitk and git-gui
>  PACKAGES =+ "${PN}-tk"
>  #RDEPENDS_${PN}-tk = "${PN} tk tcl"


Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>


Thanks,

Paul

Patch

diff --git a/meta/recipes-devtools/git/git.inc b/meta/recipes-devtools/git/git.inc
index ca13ffd..be3831b 100644
--- a/meta/recipes-devtools/git/git.inc
+++ b/meta/recipes-devtools/git/git.inc
@@ -16,6 +16,7 @@  do_install () {
 	oe_runmake install DESTDIR="${D}" bindir=${bindir} \
 		template_dir=${datadir}/git-core/templates \
 		GIT_PYTHON_DIR=${D}${datadir}/git-core/python
+	rm -rf ${D}${libdir}/perl-native
 }
 
 do_install_append_virtclass-native() {
@@ -47,6 +48,7 @@  RDEPENDS_${PN}-perltools = "${PN} perl perl-module-file-path findutils"
 PACKAGES =+ "${PN}-python"
 FILES_${PN}-python = "${libdir}/python*"
 
+
 # git-tk package with gitk and git-gui
 PACKAGES =+ "${PN}-tk"
 #RDEPENDS_${PN}-tk = "${PN} tk tcl"