diff mbox series

[meta-oe] pahole: fix native package build error

Message ID 20230505072710.666230-1-xiangyu.chen@eng.windriver.com
State New
Headers show
Series [meta-oe] pahole: fix native package build error | expand

Commit Message

Xiangyu Chen May 5, 2023, 7:27 a.m. UTC 
From: Xiangyu Chen <xiangyu.chen@windriver.com>

pahole-native package needs some uapi headers such like linux/btf.h,
otherwise it would report error as below:

btf_loader.c:342:54: error: invalid use of undefined type ‘struct btf_enum64’

Signed-off-by: Xiangyu Chen <xiangyu.chen@windriver.com>
---
 meta-oe/recipes-devtools/pahole/pahole_1.24.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jose Quaresma May 5, 2023, 9:05 a.m. UTC | #1 
Xiangyu Chen <xiangyu.chen@eng.windriver.com> escreveu no dia sexta,
5/05/2023 à(s) 08:27:

> From: Xiangyu Chen <xiangyu.chen@windriver.com>
>
> pahole-native package needs some uapi headers such like linux/btf.h,
> otherwise it would report error as below:
>
> btf_loader.c:342:54: error: invalid use of undefined type ‘struct
> btf_enum64’
>
> Signed-off-by: Xiangyu Chen <xiangyu.chen@windriver.com>
> ---
>  meta-oe/recipes-devtools/pahole/pahole_1.24.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-oe/recipes-devtools/pahole/pahole_1.24.bb
> b/meta-oe/recipes-devtools/pahole/pahole_1.24.bb
> index 2bb73c3eb..93ee7f30f 100644
> --- a/meta-oe/recipes-devtools/pahole/pahole_1.24.bb
> +++ b/meta-oe/recipes-devtools/pahole/pahole_1.24.bb
> @@ -3,7 +3,7 @@ SUMMARY = "Shows and manipulates data structure layout"
>  LICENSE = "GPL-2.0-only"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
>
> -DEPENDS = "elfutils zlib libbpf"
> +DEPENDS = "elfutils zlib libbpf linux-libc-headers"
>

If it is only needed for native maybe using class-native is better:

DEPENDS:append:class-native = " linux-libc-headers"

Jose


>  # Depends on MACHINE_ARCH libbpf
>  PACKAGE_ARCH = "${MACHINE_ARCH}"
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#102316):
> https://lists.openembedded.org/g/openembedded-devel/message/102316
> Mute This Topic: https://lists.openembedded.org/mt/98700913/5052612
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
> quaresma.jose@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
Xiangyu Chen May 5, 2023, 9:18 a.m. UTC | #2 
On 5/5/23 17:05, Jose Quaresma wrote:
> **
> *CAUTION: This email comes from a non Wind River email account!*
> Do not click links or open attachments unless you recognize the sender 
> and know the content is safe.
>
>
> Xiangyu Chen <xiangyu.chen@eng.windriver.com> escreveu no dia sexta, 
> 5/05/2023 à(s) 08:27:
>
>     From: Xiangyu Chen <xiangyu.chen@windriver.com>
>
>     pahole-native package needs some uapi headers such like linux/btf.h,
>     otherwise it would report error as below:
>
>     btf_loader.c:342:54: error: invalid use of undefined type ‘struct
>     btf_enum64’
>
>     Signed-off-by: Xiangyu Chen <xiangyu.chen@windriver.com>
>     ---
>      meta-oe/recipes-devtools/pahole/pahole_1.24.bb
>     <https://urldefense.com/v3/__http://pahole_1.24.bb__;!!AjveYdw8EvQ!bNylWq3KEGYf5hLfs2xlzXzBZmcw-hBCZq9-WEagfdr2DATOw_5uQFj-opLWXKLwWAXTOdF6genpPCYXr9r2yDTGNv8dp2Df$>
>     | 2 +-
>      1 file changed, 1 insertion(+), 1 deletion(-)
>
>     diff --git a/meta-oe/recipes-devtools/pahole/pahole_1.24.bb
>     <https://urldefense.com/v3/__http://pahole_1.24.bb__;!!AjveYdw8EvQ!bNylWq3KEGYf5hLfs2xlzXzBZmcw-hBCZq9-WEagfdr2DATOw_5uQFj-opLWXKLwWAXTOdF6genpPCYXr9r2yDTGNv8dp2Df$>
>     b/meta-oe/recipes-devtools/pahole/pahole_1.24.bb
>     <https://urldefense.com/v3/__http://pahole_1.24.bb__;!!AjveYdw8EvQ!bNylWq3KEGYf5hLfs2xlzXzBZmcw-hBCZq9-WEagfdr2DATOw_5uQFj-opLWXKLwWAXTOdF6genpPCYXr9r2yDTGNv8dp2Df$>
>     index 2bb73c3eb..93ee7f30f 100644
>     --- a/meta-oe/recipes-devtools/pahole/pahole_1.24.bb
>     <https://urldefense.com/v3/__http://pahole_1.24.bb__;!!AjveYdw8EvQ!bNylWq3KEGYf5hLfs2xlzXzBZmcw-hBCZq9-WEagfdr2DATOw_5uQFj-opLWXKLwWAXTOdF6genpPCYXr9r2yDTGNv8dp2Df$>
>     +++ b/meta-oe/recipes-devtools/pahole/pahole_1.24.bb
>     <https://urldefense.com/v3/__http://pahole_1.24.bb__;!!AjveYdw8EvQ!bNylWq3KEGYf5hLfs2xlzXzBZmcw-hBCZq9-WEagfdr2DATOw_5uQFj-opLWXKLwWAXTOdF6genpPCYXr9r2yDTGNv8dp2Df$>
>     @@ -3,7 +3,7 @@ SUMMARY = "Shows and manipulates data structure
>     layout"
>      LICENSE = "GPL-2.0-only"
>      LIC_FILES_CHKSUM =
>     "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
>
>     -DEPENDS = "elfutils zlib libbpf"
>     +DEPENDS = "elfutils zlib libbpf linux-libc-headers"
>
>
> If it is only needed for native maybe using class-native is better:
>
> DEPENDS:append:class-native = " linux-libc-headers"
>
Ah, yes, indeed, i tested on my local setup and this issue happens on 
native package only, thanks for your suggestion, a v2 patch will

post later.

Thanks,

Xiangyu


> Jose
>
>
>      # Depends on MACHINE_ARCH libbpf
>      PACKAGE_ARCH = "${MACHINE_ARCH}"
>     -- 
>     2.34.1
>
>
>     -=-=-=-=-=-=-=-=-=-=-=-
>     Links: You receive all messages sent to this group.
>     View/Reply Online (#102316):
>     https://lists.openembedded.org/g/openembedded-devel/message/102316
>     <https://urldefense.com/v3/__https://lists.openembedded.org/g/openembedded-devel/message/102316__;!!AjveYdw8EvQ!bNylWq3KEGYf5hLfs2xlzXzBZmcw-hBCZq9-WEagfdr2DATOw_5uQFj-opLWXKLwWAXTOdF6genpPCYXr9r2yDTGNsH_kE5v$>
>     Mute This Topic:
>     https://lists.openembedded.org/mt/98700913/5052612
>     <https://urldefense.com/v3/__https://lists.openembedded.org/mt/98700913/5052612__;!!AjveYdw8EvQ!bNylWq3KEGYf5hLfs2xlzXzBZmcw-hBCZq9-WEagfdr2DATOw_5uQFj-opLWXKLwWAXTOdF6genpPCYXr9r2yDTGNsAure0n$>
>     Group Owner: openembedded-devel+owner@lists.openembedded.org
>     <mailto:openembedded-devel%2Bowner@lists.openembedded.org>
>     Unsubscribe:
>     https://lists.openembedded.org/g/openembedded-devel/unsub
>     <https://urldefense.com/v3/__https://lists.openembedded.org/g/openembedded-devel/unsub__;!!AjveYdw8EvQ!bNylWq3KEGYf5hLfs2xlzXzBZmcw-hBCZq9-WEagfdr2DATOw_5uQFj-opLWXKLwWAXTOdF6genpPCYXr9r2yDTGNiJoZlYi$>
>     [quaresma.jose@gmail.com]
>     -=-=-=-=-=-=-=-=-=-=-=-
>
>
>
> -- 
> Best regards,
>
> José Quaresma
diff mbox series

Patch

diff --git a/meta-oe/recipes-devtools/pahole/pahole_1.24.bb b/meta-oe/recipes-devtools/pahole/pahole_1.24.bb
index 2bb73c3eb..93ee7f30f 100644
--- a/meta-oe/recipes-devtools/pahole/pahole_1.24.bb
+++ b/meta-oe/recipes-devtools/pahole/pahole_1.24.bb
@@ -3,7 +3,7 @@  SUMMARY = "Shows and manipulates data structure layout"
 LICENSE = "GPL-2.0-only"
 LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
 
-DEPENDS = "elfutils zlib libbpf"
+DEPENDS = "elfutils zlib libbpf linux-libc-headers"
 
 # Depends on MACHINE_ARCH libbpf
 PACKAGE_ARCH = "${MACHINE_ARCH}"