Patchwork parted: don't pass --disable-Werror to configure

login
register
mail settings
Submitter Andreas Oberritter
Date March 15, 2012, 1:08 a.m.
Message ID <1331773718-14372-1-git-send-email-obi@opendreambox.org>
Download mbox | patch
Permalink /patch/23361/
State Accepted
Commit 324c66698d08c94472271f86b6e962678f1b9086
Headers show

Comments

Andreas Oberritter - March 15, 2012, 1:08 a.m.
* Fixes the following warning:

| configure: WARNING: unrecognized options: --disable-Werror

Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
---
* No PR bump required because it doesn't change anything
  apart from the log message mentioned above.

 meta/recipes-extended/parted/parted_3.0.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Saul Wold - March 15, 2012, 4:28 p.m.
On 03/14/2012 06:08 PM, Andreas Oberritter wrote:
> * Fixes the following warning:
>
> | configure: WARNING: unrecognized options: --disable-Werror
>
> Signed-off-by: Andreas Oberritter<obi@opendreambox.org>
> ---
> * No PR bump required because it doesn't change anything
>    apart from the log message mentioned above.
>
>   meta/recipes-extended/parted/parted_3.0.bb |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-extended/parted/parted_3.0.bb b/meta/recipes-extended/parted/parted_3.0.bb
> index 29daf01..2fba6d1 100644
> --- a/meta/recipes-extended/parted/parted_3.0.bb
> +++ b/meta/recipes-extended/parted/parted_3.0.bb
> @@ -13,7 +13,7 @@ SRC_URI = "${GNU_MIRROR}/parted/parted-${PV}.tar.gz \
>   SRC_URI[md5sum] = "a94e84a9b9944715c4453f82ccc639bf"
>   SRC_URI[sha256sum] = "8886eece015202f6bd5ce8414f4b68838452cef509f2e3389ad56128219837b7"
>
> -EXTRA_OECONF = "--disable-Werror --disable-device-mapper"
> +EXTRA_OECONF = "--disable-device-mapper"
>
>   inherit autotools pkgconfig gettext
>

Merged into OE-Core

Thanks
	Sau!
Khem Raj - April 2, 2012, 9:08 p.m.
On (15/03/12 02:08), Andreas Oberritter wrote:
> * Fixes the following warning:
> 
> | configure: WARNING: unrecognized options: --disable-Werror


should 'W' be 'w' in --disable-Werror

> 
> Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
> ---
> * No PR bump required because it doesn't change anything
>   apart from the log message mentioned above.
> 
>  meta/recipes-extended/parted/parted_3.0.bb |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-extended/parted/parted_3.0.bb b/meta/recipes-extended/parted/parted_3.0.bb
> index 29daf01..2fba6d1 100644
> --- a/meta/recipes-extended/parted/parted_3.0.bb
> +++ b/meta/recipes-extended/parted/parted_3.0.bb
> @@ -13,7 +13,7 @@ SRC_URI = "${GNU_MIRROR}/parted/parted-${PV}.tar.gz \
>  SRC_URI[md5sum] = "a94e84a9b9944715c4453f82ccc639bf"
>  SRC_URI[sha256sum] = "8886eece015202f6bd5ce8414f4b68838452cef509f2e3389ad56128219837b7"
>  
> -EXTRA_OECONF = "--disable-Werror --disable-device-mapper"
> +EXTRA_OECONF = "--disable-device-mapper"
>  
>  inherit autotools pkgconfig gettext
>  
> -- 
> 1.7.5.4
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Andreas Oberritter - April 2, 2012, 9:46 p.m.
On 02.04.2012 23:08, Khem Raj wrote:
> On (15/03/12 02:08), Andreas Oberritter wrote:
>> * Fixes the following warning:
>>
>> | configure: WARNING: unrecognized options: --disable-Werror
> 
> 
> should 'W' be 'w' in --disable-Werror

Maybe (didn't verify), but it doesn't seem to be required anyway, so
it's better to not use the option.

Regards,
Andreas
Khem Raj - April 3, 2012, 12:01 a.m.
On Mon, Apr 2, 2012 at 2:46 PM, Andreas Oberritter <obi@opendreambox.org> wrote:
> Maybe (didn't verify), but it doesn't seem to be required anyway, so
> it's better to not use the option.

I generally agree on nor disabling werror. so removing it is right
thing to do regardless

Patch

diff --git a/meta/recipes-extended/parted/parted_3.0.bb b/meta/recipes-extended/parted/parted_3.0.bb
index 29daf01..2fba6d1 100644
--- a/meta/recipes-extended/parted/parted_3.0.bb
+++ b/meta/recipes-extended/parted/parted_3.0.bb
@@ -13,7 +13,7 @@  SRC_URI = "${GNU_MIRROR}/parted/parted-${PV}.tar.gz \
 SRC_URI[md5sum] = "a94e84a9b9944715c4453f82ccc639bf"
 SRC_URI[sha256sum] = "8886eece015202f6bd5ce8414f4b68838452cef509f2e3389ad56128219837b7"
 
-EXTRA_OECONF = "--disable-Werror --disable-device-mapper"
+EXTRA_OECONF = "--disable-device-mapper"
 
 inherit autotools pkgconfig gettext