diff mbox series

[3/3] binutils: package static libs from gprofng

Message ID 20230502144406.2849858-3-raj.khem@gmail.com
State New
Headers show
Series [1/3] musl: Update to latest master | expand

Commit Message

Khem Raj May 2, 2023, 2:44 p.m. UTC
From: Martin Jansa <martin.jansa@gmail.com>

* fixes:
  ERROR: binutils-2.40-r0 do_package: QA Issue: binutils: Files/directories were installed but not shipped in any package:
    /usr/lib/gprofng/libgp-collectorAPI.a
  Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
  binutils: 1 installed and not shipped files. [installed-vs-shipped]

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-devtools/binutils/binutils_2.40.bb | 1 +
 1 file changed, 1 insertion(+)

Comments

Denys Dmytriyenko June 2, 2023, 7:26 p.m. UTC | #1
On Tue, May 02, 2023 at 07:44:06AM -0700, Khem Raj wrote:
> From: Martin Jansa <martin.jansa@gmail.com>
> 
> * fixes:
>   ERROR: binutils-2.40-r0 do_package: QA Issue: binutils: Files/directories were installed but not shipped in any package:
>     /usr/lib/gprofng/libgp-collectorAPI.a
>   Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
>   binutils: 1 installed and not shipped files. [installed-vs-shipped]
> 
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-devtools/binutils/binutils_2.40.bb | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-devtools/binutils/binutils_2.40.bb b/meta/recipes-devtools/binutils/binutils_2.40.bb
> index 4ce1b4bec2..9fe4bf5ae3 100644
> --- a/meta/recipes-devtools/binutils/binutils_2.40.bb
> +++ b/meta/recipes-devtools/binutils/binutils_2.40.bb
> @@ -67,6 +67,7 @@ FILES:libbfd = "${libdir}/libbfd-*.so.* ${libdir}/libbfd-*.so"
>  FILES:libopcodes = "${libdir}/libopcodes-*.so.* ${libdir}/libopcodes-*.so"
>  FILES:gprofng = "${sysconfdir}/gprofng.rc ${libdir}/gprofng/libgp-*.so ${libdir}/gprofng/libgprofng.so.* ${bindir}/gp-* ${bindir}/gprofng"

^^^

>  FILES:${PN}-dev += "${libdir}/libgprofng.so ${libdir}/libsframe.so"
> +FILES:${PN}-staticdev += "${libdir}/gprofng/*.a"

1. since there's a separate gprofng package, should this instead be:

FILES:gprofng-staticdev += "${libdir}/gprofng/*.a"


2. it also breaks for binutils-cross-canadian, since this change is not in any 
of the common .inc files


>  SRC_URI:append:class-nativesdk =  " file://0003-binutils-nativesdk-Search-for-alternative-ld.so.conf.patch "
>  
>  USE_ALTERNATIVES_FOR:class-nativesdk = ""
> -- 
> 2.40.1
diff mbox series

Patch

diff --git a/meta/recipes-devtools/binutils/binutils_2.40.bb b/meta/recipes-devtools/binutils/binutils_2.40.bb
index 4ce1b4bec2..9fe4bf5ae3 100644
--- a/meta/recipes-devtools/binutils/binutils_2.40.bb
+++ b/meta/recipes-devtools/binutils/binutils_2.40.bb
@@ -67,6 +67,7 @@  FILES:libbfd = "${libdir}/libbfd-*.so.* ${libdir}/libbfd-*.so"
 FILES:libopcodes = "${libdir}/libopcodes-*.so.* ${libdir}/libopcodes-*.so"
 FILES:gprofng = "${sysconfdir}/gprofng.rc ${libdir}/gprofng/libgp-*.so ${libdir}/gprofng/libgprofng.so.* ${bindir}/gp-* ${bindir}/gprofng"
 FILES:${PN}-dev += "${libdir}/libgprofng.so ${libdir}/libsframe.so"
+FILES:${PN}-staticdev += "${libdir}/gprofng/*.a"
 SRC_URI:append:class-nativesdk =  " file://0003-binutils-nativesdk-Search-for-alternative-ld.so.conf.patch "
 
 USE_ALTERNATIVES_FOR:class-nativesdk = ""