Patchwork [0/1] ncurses packaging fix

login
register
mail settings
Submitter Scott Garman
Date March 14, 2012, 12:31 a.m.
Message ID <cover.1331684953.git.scott.a.garman@intel.com>
Download mbox
Permalink /patch/23205/
State New
Headers show

Pull-request

git://git.pokylinux.org/poky-contrib sgarman/ncurses-pkg-fix-oe

Comments

Scott Garman - March 14, 2012, 12:31 a.m.
Hello,

This fixes the ncurses library packaging. Thanks to Andreas Oberritter
for pointing it out.

Scott

The following changes since commit 81379dc141e245307ca391a02b7490b199128991:

  dates: Fix unpackaged files warning (2012-03-13 23:18:19 +0000)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib sgarman/ncurses-pkg-fix-oe
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=sgarman/ncurses-pkg-fix-oe

Scott Garman (1):
  ncurses: fix packaging of moved libraries

 meta/recipes-core/ncurses/ncurses.inc |   18 ++++++++++++++++--
 1 files changed, 16 insertions(+), 2 deletions(-)
Martin Jansa - March 14, 2012, 7:51 a.m.
On Tue, Mar 13, 2012 at 05:31:24PM -0700, Scott Garman wrote:
> Hello,
> 
> This fixes the ncurses library packaging. Thanks to Andreas Oberritter
> for pointing it out.

Why not use another do_split_packages for base_libdir?

Can it be used only once per recipe? are there any libs left in libdir?

Cheers,

> 
> Scott
> 
> The following changes since commit 81379dc141e245307ca391a02b7490b199128991:
> 
>   dates: Fix unpackaged files warning (2012-03-13 23:18:19 +0000)
> 
> are available in the git repository at:
>   git://git.pokylinux.org/poky-contrib sgarman/ncurses-pkg-fix-oe
>   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=sgarman/ncurses-pkg-fix-oe
> 
> Scott Garman (1):
>   ncurses: fix packaging of moved libraries
> 
>  meta/recipes-core/ncurses/ncurses.inc |   18 ++++++++++++++++--
>  1 files changed, 16 insertions(+), 2 deletions(-)
> 
> -- 
> 1.7.5.4
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Koen Kooi - March 14, 2012, 8:22 a.m.
Op 14 mrt. 2012, om 01:31 heeft Scott Garman het volgende geschreven:

> Hello,
> 
> This fixes the ncurses library packaging. Thanks to Andreas Oberritter
> for pointing it out.
> 
> Scott
> 
> The following changes since commit 81379dc141e245307ca391a02b7490b199128991:
> 
>  dates: Fix unpackaged files warning (2012-03-13 23:18:19 +0000)
> 
> are available in the git repository at:
>  git://git.pokylinux.org/poky-contrib sgarman/ncurses-pkg-fix-oe
>  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=sgarman/ncurses-pkg-fix-oe
> 
> Scott Garman (1):
>  ncurses: fix packaging of moved libraries

You're missing a PR bump for the affected packages.

regards,

Koen
Scott Garman - March 14, 2012, 4:26 p.m.
On 03/14/2012 01:22 AM, Koen Kooi wrote:
>
> Op 14 mrt. 2012, om 01:31 heeft Scott Garman het volgende geschreven:
>
>> Hello,
>>
>> This fixes the ncurses library packaging. Thanks to Andreas Oberritter
>> for pointing it out.
>>
>> Scott
>>
>> The following changes since commit 81379dc141e245307ca391a02b7490b199128991:
>>
>>   dates: Fix unpackaged files warning (2012-03-13 23:18:19 +0000)
>>
>> are available in the git repository at:
>>   git://git.pokylinux.org/poky-contrib sgarman/ncurses-pkg-fix-oe
>>   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=sgarman/ncurses-pkg-fix-oe
>>
>> Scott Garman (1):
>>   ncurses: fix packaging of moved libraries
>
> You're missing a PR bump for the affected packages.

My patch included incrementing INC_PR, but I'm guessing you're pointing 
this out because overnight Paul Eggleton got a patch into master which 
incremented INC_PR to the same number as I did in this patch. So I'm 
going to respin the branch with another increase to INC_PR.

If I'm mistaken, please let me know.

Thanks,

Scott
Scott Garman - March 14, 2012, 4:49 p.m.
On 03/14/2012 12:51 AM, Martin Jansa wrote:
> On Tue, Mar 13, 2012 at 05:31:24PM -0700, Scott Garman wrote:
>> Hello,
>>
>> This fixes the ncurses library packaging. Thanks to Andreas Oberritter
>> for pointing it out.
>
> Why not use another do_split_packages for base_libdir?
>
> Can it be used only once per recipe? are there any libs left in libdir?

Hi Martin,

This is something worth looking into, but due to the amount of testing I 
feel it would need, I'm going to have to defer it. Our next release is 
coming up fast, and I've been asked to focus on recipe upgrades for the 
rest of this week. I have filed bug #2106 to keep track of it.

https://bugzilla.yoctoproject.org/show_bug.cgi?id=2106

Certainly anyone who has time to do proper testing on this can grab 
ownership of the bug in the meantime.

Scott