Patchwork [bitbake-devel,0/3,V2] Hob Notebook Implementation

login
register
mail settings
Submitter Shane Wang
Date March 12, 2012, 1:23 p.m.
Message ID <cover.1331558220.git.shane.wang@intel.com>
Download mbox
Permalink /patch/23029/
State New
Headers show

Pull-request

git://git.pokylinux.org/poky-contrib shane/hob2-v0.69

Comments

Shane Wang - March 12, 2012, 1:23 p.m.
This patchset is to implement Hob self-defined notebook, and use it in the build details page.

The following changes since commit fe0659991b826eb3b4163743d29533fe5f91cb12:

  libx11-trim/diet: Ensure libx11-locale doesn't trigger multiple provider issues (2012-03-12 02:28:03 +0000)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib shane/hob2-v0.69
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=shane/hob2-v0.69

Shane Wang (3):
  Hob: implement a self-defined notebook visual component for Hob
  Hob: use HobNotebook to implement a notebook in build details page
  Hob: show indicators on the tabs of the Hob notebook

 bitbake/lib/bb/ui/crumbs/builddetailspage.py     |   40 ++-
 bitbake/lib/bb/ui/crumbs/builder.py              |    5 +
 bitbake/lib/bb/ui/crumbs/hobcolor.py             |    1 +
 bitbake/lib/bb/ui/crumbs/hobwidget.py            |  482 ++++++++++++++++++----
 bitbake/lib/bb/ui/crumbs/packageselectionpage.py |   19 +-
 bitbake/lib/bb/ui/crumbs/recipeselectionpage.py  |   19 +-
 bitbake/lib/bb/ui/crumbs/runningbuild.py         |   69 +++
 7 files changed, 518 insertions(+), 117 deletions(-)
Joshua Lock - March 13, 2012, 6:10 p.m.
On 12/03/12 06:23, Shane Wang wrote:
> This patchset is to implement Hob self-defined notebook, and use it in the build details page.

I have raised some concerns with the implementation of this series on 
each of the patches. It may seem nit-picky but we really do need to 
start paying attention to the details at this point and polishing the 
functionality and work-flow of the new Hob.

I'm torn on the series. As it stands we see errors each time we use Hob 
in master as the standard Gtk notebook doesn't support some of the API 
in the Hob notebook that is being called - errors look bad.

However this series has some poor coding style and doesn't match the 
visual design - these also look bad, though arguably less so.

I don't mind whether we merge this and iterate on the implementation or 
hold on merging until we fix the implementation but I feel we need to 
address the issues.

What are others thoughts?

Joshua