Patchwork [1/5] Split xcb-util into separate packages.

login
mail settings
Submitter Marko Kati?
Date March 10, 2012, 3:49 p.m.
Message ID <CAHod+Ge8QmNp5TXhoKnqLR_2s+eGg=jOWLG2keAoCYFjTs3ByA@mail.gmail.com>
Download mbox | patch
Permalink /patch/22999/
State New
Headers show

Comments

Marko Kati? - March 10, 2012, 3:49 p.m.
xcb-util was split into separate packages during the 0.3.6 -> 0.3.8
transition.
Change xcb-util.inc to reflect that.
Saul Wold - March 12, 2012, 9:06 p.m.
On 03/10/2012 07:49 AM, Marko Kati? wrote:
> xcb-util was split into separate packages during the 0.3.6 -> 0.3.8
> transition.
> Change xcb-util.inc to reflect that.
>
This patch series looks OK, but the comment need refining.

First it's best to have correctly Subjects that list the file or recipe 
area being addressed and then what's the summary

For example in this case:

xcb-util: Remove packaging and modify SRC_URI for multiple ${PN} names

xcb-util was split into separate packages during the 0.3.6 -> 0.3.8 
transition, so update the .inc file to reflect that by removing the 
older packaging.

The reset of this series needs similar updates to commit messages.

Also, if possible can you use a git repo (request an oe-core or poky 
branch).
>
>
> diff --git a/meta/recipes-graphics/xcb/xcb-util.inc
> b/meta/recipes-graphics/xcb/xcb-util.inc
> index cd9923d..5e77a22 100644
> --- a/meta/recipes-graphics/xcb/xcb-util.inc
> +++ b/meta/recipes-graphics/xcb/xcb-util.inc
> @@ -18,20 +18,6 @@ DEPENDS += "gperf-native"
>   PARALLEL_MAKE = ""
> -SRC_URI = "http://xcb.freedesktop.org/dist/xcb-util-${PV}.tar.bz2"
> -
> -PACKAGES =+ "libxcbatom libxcbaux libxcbevent libxcbicccm \
> -             libxcbimage libxcbkeysyms libxcbproperty \
> -             libxcbreply libxcbwm"
> -
> -FILES_libxcbatom = "${libdir}/libXCBAtom.so.*"
> -FILES_libxcbaux = "${libdir}/libXCBAux.so.*"
> -FILES_libxcbevent = "${libdir}/libXCBEvent.so.*"
> -FILES_libxcbicccm = "${libdir}/libXCBICCCM.so.*"
> -FILES_libxcbimage = "${libdir}/libXCBImage.so.*"
> -FILES_libxcbkeysyms = "${libdir}/libXCBKeysyms.so.*"
> -FILES_libxcbproperty = "${libdir}/libXCBProperty.so.*"
> -FILES_libxcbreply = "${libdir}/libXCBReply.so.*"
> -FILES_libxcbwm = "${libdir}/libXCBWM.so.*"
> +SRC_URI = "http://xcb.freedesktop.org/dist/${PN}-${PV}.tar.bz2"
>   inherit autotools pkgconfig
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Saul Wold - March 13, 2012, 12:18 a.m.
On 03/10/2012 07:49 AM, Marko Kati? wrote:
> xcb-util was split into separate packages during the 0.3.6 -> 0.3.8
> transition.
> Change xcb-util.inc to reflect that.
>
>
>
> diff --git a/meta/recipes-graphics/xcb/xcb-util.inc
> b/meta/recipes-graphics/xcb/xcb-util.inc
> index cd9923d..5e77a22 100644
> --- a/meta/recipes-graphics/xcb/xcb-util.inc
> +++ b/meta/recipes-graphics/xcb/xcb-util.inc
> @@ -18,20 +18,6 @@ DEPENDS += "gperf-native"
>   PARALLEL_MAKE = ""
> -SRC_URI = "http://xcb.freedesktop.org/dist/xcb-util-${PV}.tar.bz2"
> -
> -PACKAGES =+ "libxcbatom libxcbaux libxcbevent libxcbicccm \
> -             libxcbimage libxcbkeysyms libxcbproperty \
> -             libxcbreply libxcbwm"
> -
> -FILES_libxcbatom = "${libdir}/libXCBAtom.so.*"
> -FILES_libxcbaux = "${libdir}/libXCBAux.so.*"
> -FILES_libxcbevent = "${libdir}/libXCBEvent.so.*"
> -FILES_libxcbicccm = "${libdir}/libXCBICCCM.so.*"
> -FILES_libxcbimage = "${libdir}/libXCBImage.so.*"
> -FILES_libxcbkeysyms = "${libdir}/libXCBKeysyms.so.*"
> -FILES_libxcbproperty = "${libdir}/libXCBProperty.so.*"
> -FILES_libxcbreply = "${libdir}/libXCBReply.so.*"
> -FILES_libxcbwm = "${libdir}/libXCBWM.so.*"
> +SRC_URI = "http://xcb.freedesktop.org/dist/${PN}-${PV}.tar.bz2"
>   inherit autotools pkgconfig
>
This should be ${BPN} instead of ${PN}.

Also, your email came as HTML and that messed up the git am.

Sau!

>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Yuri Bushmelev - March 13, 2012, 6:51 p.m.
2012/3/10 Marko Kati? <dromede@gmail.com>:
> xcb-util was split into separate packages during the 0.3.6 -> 0.3.8
> transition.
> Change xcb-util.inc to reflect that.
>
>
>
> diff --git a/meta/recipes-graphics/xcb/xcb-util.inc
> b/meta/recipes-graphics/xcb/xcb-util.inc
> index cd9923d..5e77a22 100644
> --- a/meta/recipes-graphics/xcb/xcb-util.inc
> +++ b/meta/recipes-graphics/xcb/xcb-util.inc
> @@ -18,20 +18,6 @@ DEPENDS += "gperf-native"
>
>  PARALLEL_MAKE = ""

BTW, I haven't seen any trouble with PARALLEL_MAKE and
xcb-util_0.3.8.bb. So we may try to remove this line.

>
> -SRC_URI = "http://xcb.freedesktop.org/dist/xcb-util-${PV}.tar.bz2"
> -
> -PACKAGES =+ "libxcbatom libxcbaux libxcbevent libxcbicccm \
> -             libxcbimage libxcbkeysyms libxcbproperty \
> -             libxcbreply libxcbwm"
> -
> -FILES_libxcbatom = "${libdir}/libXCBAtom.so.*"
> -FILES_libxcbaux = "${libdir}/libXCBAux.so.*"
> -FILES_libxcbevent = "${libdir}/libXCBEvent.so.*"
> -FILES_libxcbicccm = "${libdir}/libXCBICCCM.so.*"
> -FILES_libxcbimage = "${libdir}/libXCBImage.so.*"
> -FILES_libxcbkeysyms = "${libdir}/libXCBKeysyms.so.*"
> -FILES_libxcbproperty = "${libdir}/libXCBProperty.so.*"
> -FILES_libxcbreply = "${libdir}/libXCBReply.so.*"
> -FILES_libxcbwm = "${libdir}/libXCBWM.so.*"
> +SRC_URI = "http://xcb.freedesktop.org/dist/${PN}-${PV}.tar.bz2"
>
>  inherit autotools pkgconfig
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>

Patch

diff --git a/meta/recipes-graphics/xcb/xcb-util.inc
b/meta/recipes-graphics/xcb/xcb-util.inc
index cd9923d..5e77a22 100644
--- a/meta/recipes-graphics/xcb/xcb-util.inc
+++ b/meta/recipes-graphics/xcb/xcb-util.inc
@@ -18,20 +18,6 @@  DEPENDS += "gperf-native"

 PARALLEL_MAKE = ""

-SRC_URI = "http://xcb.freedesktop.org/dist/xcb-util-${PV}.tar.bz2"
-
-PACKAGES =+ "libxcbatom libxcbaux libxcbevent libxcbicccm \
-             libxcbimage libxcbkeysyms libxcbproperty \
-             libxcbreply libxcbwm"
-
-FILES_libxcbatom = "${libdir}/libXCBAtom.so.*"
-FILES_libxcbaux = "${libdir}/libXCBAux.so.*"
-FILES_libxcbevent = "${libdir}/libXCBEvent.so.*"
-FILES_libxcbicccm = "${libdir}/libXCBICCCM.so.*"
-FILES_libxcbimage = "${libdir}/libXCBImage.so.*"
-FILES_libxcbkeysyms = "${libdir}/libXCBKeysyms.so.*"
-FILES_libxcbproperty = "${libdir}/libXCBProperty.so.*"
-FILES_libxcbreply = "${libdir}/libXCBReply.so.*"
-FILES_libxcbwm = "${libdir}/libXCBWM.so.*"
+SRC_URI = "http://xcb.freedesktop.org/dist/${PN}-${PV}.tar.bz2"

 inherit autotools pkgconfig