| Submitter | Daniel Zauner |
|---|---|
| Date | March 9, 2012, 6:07 a.m. |
| Message ID | <1331273267-17295-1-git-send-email-daniel.zauner@me.com> |
| Download | mbox | patch |
| Permalink | /patch/22987/ |
| State | Superseded |
| Headers | show |
Comments
Two comments: 1. The patch description got messed up and went all in the Subject. Don't use nested square brackets [[]], use them in sequence [][] or just one of those. 2. Use -M flag to git-format-patch so it catches the rename and makes the patch readable again.
Thanks, will do. Do you want me to re-submit the patch? Daniel Am 12.03.2012 um 22:00 schrieb Denys Dmytriyenko: > Two comments: > > 1. The patch description got messed up and went all in the Subject. Don't use > nested square brackets [[]], use them in sequence [][] or just one of those. > > 2. Use -M flag to git-format-patch so it catches the rename and makes the > patch readable again. > > -- > Denys > > > On Fri, Mar 09, 2012 at 07:07:47AM +0100, Daniel Zauner wrote: >> Signed-off-by: Daniel Zauner <daniel.zauner@me.com> >> --- >> recipes/opkg-utils/opkg-utils_git.bb | 27 +++++++++++++++++++++++++++ >> recipes/opkg-utils/opkg-utils_svn.bb | 25 ------------------------- >> 2 files changed, 27 insertions(+), 25 deletions(-) >> create mode 100644 recipes/opkg-utils/opkg-utils_git.bb >> delete mode 100644 recipes/opkg-utils/opkg-utils_svn.bb >> >> diff --git a/recipes/opkg-utils/opkg-utils_git.bb b/recipes/opkg-utils/opkg-utils_git.bb >> new file mode 100644 >> index 0000000..6adc7c1 >> --- /dev/null >> +++ b/recipes/opkg-utils/opkg-utils_git.bb >> @@ -0,0 +1,27 @@ >> +DESCRIPTION = "OPKG Package Manager Utilities" >> +SECTION = "base" >> +HOMEPAGE = "http://wiki.openmoko.org/wiki/Opkg" >> +PRIORITY = "optional" >> +LICENSE = "GPLv2" >> +RDEPENDS_${PN} = "python" >> +RDEPENDS_${PN}_virtclass-native = "" >> +SRCREV = "002d29bc605d7c2d02e4cf20a43c5277c15f5597" >> +PV = "0.1.8+gitr${SRCPV}" >> +PR = "r0" >> + >> +SRC_URI = "git://git.yoctoproject.org/opkg-utils;protocol=git \ >> + file://index-ignore-filenotfound.patch \ >> + file://arfile_header_split.patch \ >> + file://mtime-int.patch" >> + >> +S = "${WORKDIR}/git" >> + >> +# Avoid circular dependencies from package_ipk.bbclass >> +PACKAGES_virtclass-native = "" >> + >> +do_install() { >> + oe_runmake PREFIX=${prefix} DESTDIR=${D} install >> +} >> + >> +BBCLASSEXTEND = "native" >> +TARGET_CC_ARCH += "${LDFLAGS}" >> diff --git a/recipes/opkg-utils/opkg-utils_svn.bb b/recipes/opkg-utils/opkg-utils_svn.bb >> deleted file mode 100644 >> index 6b8d3ea..0000000 >> --- a/recipes/opkg-utils/opkg-utils_svn.bb >> +++ /dev/null >> @@ -1,25 +0,0 @@ >> -DESCRIPTION = "OPKG Package Manager Utilities" >> -SECTION = "base" >> -HOMEPAGE = "http://wiki.openmoko.org/wiki/Opkg" >> -PRIORITY = "optional" >> -RDEPENDS_${PN} = "python" >> -RDEPENDS_${PN}_virtclass-native = "" >> -SRCREV = "4747" >> -PV = "0.1.8+svnr${SRCPV}" >> -PR = "r6" >> - >> -SRC_URI = "svn://svn.openmoko.org/trunk/src/host/;module=opkg-utils;proto=http \ >> - file://index-ignore-filenotfound.patch \ >> - file://mtime-int.patch" >> - >> -S = "${WORKDIR}/opkg-utils" >> - >> -# Avoid circular dependencies from package_ipk.bbclass >> -PACKAGES_virtclass-native = "" >> - >> -do_install() { >> - oe_runmake PREFIX=${prefix} DESTDIR=${D} install >> -} >> - >> -BBCLASSEXTEND = "native" >> -TARGET_CC_ARCH += "${LDFLAGS}" >> -- >> 1.7.2.5 >> >> >> _______________________________________________ >> Openembedded-devel mailing list >> Openembedded-devel@lists.openembedded.org >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
On Mon, Mar 12, 2012 at 10:06:45PM +0100, Daniel Zauner wrote: > Thanks, will do. > Do you want me to re-submit the patch? Yes, please.
Patch
diff --git a/recipes/opkg-utils/opkg-utils_git.bb b/recipes/opkg-utils/opkg-utils_git.bb new file mode 100644 index 0000000..6adc7c1 --- /dev/null +++ b/recipes/opkg-utils/opkg-utils_git.bb @@ -0,0 +1,27 @@ +DESCRIPTION = "OPKG Package Manager Utilities" +SECTION = "base" +HOMEPAGE = "http://wiki.openmoko.org/wiki/Opkg" +PRIORITY = "optional" +LICENSE = "GPLv2" +RDEPENDS_${PN} = "python" +RDEPENDS_${PN}_virtclass-native = "" +SRCREV = "002d29bc605d7c2d02e4cf20a43c5277c15f5597" +PV = "0.1.8+gitr${SRCPV}" +PR = "r0" + +SRC_URI = "git://git.yoctoproject.org/opkg-utils;protocol=git \ + file://index-ignore-filenotfound.patch \ + file://arfile_header_split.patch \ + file://mtime-int.patch" + +S = "${WORKDIR}/git" + +# Avoid circular dependencies from package_ipk.bbclass +PACKAGES_virtclass-native = "" + +do_install() { + oe_runmake PREFIX=${prefix} DESTDIR=${D} install +} + +BBCLASSEXTEND = "native" +TARGET_CC_ARCH += "${LDFLAGS}" diff --git a/recipes/opkg-utils/opkg-utils_svn.bb b/recipes/opkg-utils/opkg-utils_svn.bb deleted file mode 100644 index 6b8d3ea..0000000 --- a/recipes/opkg-utils/opkg-utils_svn.bb +++ /dev/null @@ -1,25 +0,0 @@ -DESCRIPTION = "OPKG Package Manager Utilities" -SECTION = "base" -HOMEPAGE = "http://wiki.openmoko.org/wiki/Opkg" -PRIORITY = "optional" -RDEPENDS_${PN} = "python" -RDEPENDS_${PN}_virtclass-native = "" -SRCREV = "4747" -PV = "0.1.8+svnr${SRCPV}" -PR = "r6" - -SRC_URI = "svn://svn.openmoko.org/trunk/src/host/;module=opkg-utils;proto=http \ - file://index-ignore-filenotfound.patch \ - file://mtime-int.patch" - -S = "${WORKDIR}/opkg-utils" - -# Avoid circular dependencies from package_ipk.bbclass -PACKAGES_virtclass-native = "" - -do_install() { - oe_runmake PREFIX=${prefix} DESTDIR=${D} install -} - -BBCLASSEXTEND = "native" -TARGET_CC_ARCH += "${LDFLAGS}"
Signed-off-by: Daniel Zauner <daniel.zauner@me.com> --- recipes/opkg-utils/opkg-utils_git.bb | 27 +++++++++++++++++++++++++++ recipes/opkg-utils/opkg-utils_svn.bb | 25 ------------------------- 2 files changed, 27 insertions(+), 25 deletions(-) create mode 100644 recipes/opkg-utils/opkg-utils_git.bb delete mode 100644 recipes/opkg-utils/opkg-utils_svn.bb