Patchwork [meta-oe,v2] udev-173: don't hardcode path to pidof

login
register
mail settings
Submitter Andreas Oberritter
Date March 8, 2012, 9:15 p.m.
Message ID <1331241331-14081-1-git-send-email-obi@opendreambox.org>
Download mbox | patch
Permalink /patch/22923/
State Accepted
Commit 8b5006510a73d04f023554b2126b0858f7bbd68a
Headers show

Comments

Andreas Oberritter - March 8, 2012, 9:15 p.m.
* pidof lives in /bin, search it in $PATH.
* Assume pidof's presence.
* Remove -e shell option, because pidof may return nonzero.

Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
---
v1->v2: Removed -e.

 meta-oe/recipes-core/udev/udev/init   |    8 +++-----
 meta-oe/recipes-core/udev/udev_173.bb |    2 +-
 2 files changed, 4 insertions(+), 6 deletions(-)

Patch

diff --git a/meta-oe/recipes-core/udev/udev/init b/meta-oe/recipes-core/udev/udev/init
index ecc357d..d160300 100644
--- a/meta-oe/recipes-core/udev/udev/init
+++ b/meta-oe/recipes-core/udev/udev/init
@@ -1,4 +1,4 @@ 
-#!/bin/sh -e
+#!/bin/sh
 
 ### BEGIN INIT INFO
 # Provides:          udev
@@ -18,10 +18,8 @@  export TZ=/etc/localtime
 [ -f /etc/udev/udev.conf ] && . /etc/udev/udev.conf
 
 kill_udevd() {
-	if [ -x /sbin/pidof ]; then
-		pid=`/sbin/pidof -x udevd`
-		[ -n "$pid" ] && kill $pid
-	fi
+	pid=`pidof -x udevd`
+	[ -n "$pid" ] && kill $pid
 }
 
 export ACTION=add
diff --git a/meta-oe/recipes-core/udev/udev_173.bb b/meta-oe/recipes-core/udev/udev_173.bb
index 5c5ce26..b7d7ed3 100644
--- a/meta-oe/recipes-core/udev/udev_173.bb
+++ b/meta-oe/recipes-core/udev/udev_173.bb
@@ -16,7 +16,7 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe \
 # Needed for udev-extras
 DEPENDS = "gperf-native usbutils acl glib-2.0"
 
-PR = "r3"
+PR = "r4"
 
 # version specific SRC_URI
 SRC_URI = "${KERNELORG_MIRROR}/linux/utils/kernel/hotplug/udev-${PV}.tar.gz \