Patchwork xserver-nodm-init 2.0: remove DEFAULT_PREFERENCE = "-1"

login
register
mail settings
Submitter Denis Carikli
Date April 15, 2011, 8:12 p.m.
Message ID <1302898356-22075-1-git-send-email-GNUtoo@no-log.org>
Download mbox | patch
Permalink /patch/2291/
State Accepted
Headers show

Comments

Denis Carikli - April 15, 2011, 8:12 p.m.
That fix was made in order to prevent distributions like Angstrom2010
  from picking the 1.0 version:
Angstrom 2008 picked the 2.0 version while Angstrom 2010 use the 1.0 version.
  That can prevent Xorg session from starting on the target device(like bug20 in my case):
The 1.0 lacks the following session start:
    xinit /etc/X11/Xsession -- `which $XSERVER` $ARGS >/var/log/Xsession.log 2>&1
And has that instead:
    /etc/X11/Xserver &
Which has the effect of starting Xorg only(and not the session,display manager etc...)

Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
---
 recipes/xserver-nodm-init/xserver-nodm-init_2.0.bb |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Martin Jansa - April 18, 2011, 6:17 p.m.
On Fri, Apr 15, 2011 at 10:12:36PM +0200, Denis 'GNUtoo' Carikli wrote:
> That fix was made in order to prevent distributions like Angstrom2010
>   from picking the 1.0 version:
> Angstrom 2008 picked the 2.0 version while Angstrom 2010 use the 1.0 version.
>   That can prevent Xorg session from starting on the target device(like bug20 in my case):
> The 1.0 lacks the following session start:
>     xinit /etc/X11/Xsession -- `which $XSERVER` $ARGS >/var/log/Xsession.log 2>&1
> And has that instead:
>     /etc/X11/Xserver &
> Which has the effect of starting Xorg only(and not the session,display manager etc...)
> 
> Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>

Acked-by: Martin Jansa <Martin.Jansa@gmail.com>

> ---
>  recipes/xserver-nodm-init/xserver-nodm-init_2.0.bb |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/recipes/xserver-nodm-init/xserver-nodm-init_2.0.bb b/recipes/xserver-nodm-init/xserver-nodm-init_2.0.bb
> index 5d6ca39..317d58a 100644
> --- a/recipes/xserver-nodm-init/xserver-nodm-init_2.0.bb
> +++ b/recipes/xserver-nodm-init/xserver-nodm-init_2.0.bb
> @@ -3,7 +3,6 @@ LICENSE = "GPL"
>  SECTION = "x11"
>  PRIORITY = "optional"
>  RDEPENDS_${PN} = "xserver-common (>= 1.30) xinit"
> -DEFAULT_PREFERENCE = "-1"
>  PR = "r4"
>  
>  SRC_URI = "file://xserver-nodm"
> -- 
> 1.7.0.4
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Stefan Schmidt - April 19, 2011, 8:56 a.m.
Hello.

On Mon, 2011-04-18 at 20:17, Martin Jansa wrote:
> On Fri, Apr 15, 2011 at 10:12:36PM +0200, Denis 'GNUtoo' Carikli wrote:
> > That fix was made in order to prevent distributions like Angstrom2010
> >   from picking the 1.0 version:
> > Angstrom 2008 picked the 2.0 version while Angstrom 2010 use the 1.0 version.
> >   That can prevent Xorg session from starting on the target device(like bug20 in my case):
> > The 1.0 lacks the following session start:
> >     xinit /etc/X11/Xsession -- `which $XSERVER` $ARGS >/var/log/Xsession.log 2>&1
> > And has that instead:
> >     /etc/X11/Xserver &
> > Which has the effect of starting Xorg only(and not the session,display manager etc...)
> > 
> > Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
> 
> Acked-by: Martin Jansa <Martin.Jansa@gmail.com>

Acked-by: Stefan Schmidt <stefan@buglabs.net>

I did run into this problem as well and pinned angstrom to this
version to avoid it. Removing the default preference makes more sense
to me. Allowing other to use it as well.

regards
Stefan Schmidt

Patch

diff --git a/recipes/xserver-nodm-init/xserver-nodm-init_2.0.bb b/recipes/xserver-nodm-init/xserver-nodm-init_2.0.bb
index 5d6ca39..317d58a 100644
--- a/recipes/xserver-nodm-init/xserver-nodm-init_2.0.bb
+++ b/recipes/xserver-nodm-init/xserver-nodm-init_2.0.bb
@@ -3,7 +3,6 @@  LICENSE = "GPL"
 SECTION = "x11"
 PRIORITY = "optional"
 RDEPENDS_${PN} = "xserver-common (>= 1.30) xinit"
-DEFAULT_PREFERENCE = "-1"
 PR = "r4"
 
 SRC_URI = "file://xserver-nodm"