Patchwork udev-164: don't hardcode path to pidof

login
register
mail settings
Submitter Andreas Oberritter
Date March 8, 2012, 12:08 p.m.
Message ID <1331208530-11938-1-git-send-email-obi@opendreambox.org>
Download mbox | patch
Permalink /patch/22895/
State Accepted
Commit 2f9ac0a10f7d1e3144622a5dff5aa6787fcee534
Headers show

Comments

Andreas Oberritter - March 8, 2012, 12:08 p.m.
* pidof lives in /bin, search it in $PATH.
* Assume pidof's presence.

Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
---
 meta/recipes-core/udev/udev/init   |    6 ++----
 meta/recipes-core/udev/udev_164.bb |    2 +-
 2 files changed, 3 insertions(+), 5 deletions(-)
Otavio Salvador - March 8, 2012, 3:07 p.m.
Acked-by: Otavio Salvador <otavio@ossystems.com.br>

On Thu, Mar 8, 2012 at 09:08, Andreas Oberritter <obi@opendreambox.org> wrote:
> * pidof lives in /bin, search it in $PATH.
> * Assume pidof's presence.
>
> Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
Denys Dmytriyenko - March 8, 2012, 6:10 p.m.
On Thu, Mar 08, 2012 at 01:08:50PM +0100, Andreas Oberritter wrote:
> * pidof lives in /bin, search it in $PATH.

Nice catch! It does indeed live in /bin

> * Assume pidof's presence.
> 
> Signed-off-by: Andreas Oberritter <obi@opendreambox.org>

Acked-by: Denys Dmytriyenko <denys@ti.com>

> ---
>  meta/recipes-core/udev/udev/init   |    6 ++----
>  meta/recipes-core/udev/udev_164.bb |    2 +-
>  2 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/meta/recipes-core/udev/udev/init b/meta/recipes-core/udev/udev/init
> index 78b5b1c..f9e9014 100644
> --- a/meta/recipes-core/udev/udev/init
> +++ b/meta/recipes-core/udev/udev/init
> @@ -28,10 +28,8 @@ readfile () {
>  }
>  
>  kill_udevd() {
> -	if [ -x /sbin/pidof ]; then
> -		pid=`/sbin/pidof -x udevd`
> -		[ -n "$pid" ] && kill $pid
> -	fi
> +	pid=`pidof -x udevd`
> +	[ -n "$pid" ] && kill $pid
>  }
>  
>  export ACTION=add
> diff --git a/meta/recipes-core/udev/udev_164.bb b/meta/recipes-core/udev/udev_164.bb
> index b993a13..d661044 100644
> --- a/meta/recipes-core/udev/udev_164.bb
> +++ b/meta/recipes-core/udev/udev_164.bb
> @@ -1,6 +1,6 @@
>  include udev.inc
>  
> -PR = "r11"
> +PR = "r12"
>  
>  SRC_URI += "file://udev-166-v4l1-1.patch"
>  
> -- 
> 1.7.5.4
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Richard Purdie - March 8, 2012, 8:09 p.m.
On Thu, 2012-03-08 at 13:08 +0100, Andreas Oberritter wrote:
> * pidof lives in /bin, search it in $PATH.
> * Assume pidof's presence.
> 
> Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
> ---
>  meta/recipes-core/udev/udev/init   |    6 ++----
>  meta/recipes-core/udev/udev_164.bb |    2 +-
>  2 files changed, 3 insertions(+), 5 deletions(-)

Merged to master, thanks.

Richard

Patch

diff --git a/meta/recipes-core/udev/udev/init b/meta/recipes-core/udev/udev/init
index 78b5b1c..f9e9014 100644
--- a/meta/recipes-core/udev/udev/init
+++ b/meta/recipes-core/udev/udev/init
@@ -28,10 +28,8 @@  readfile () {
 }
 
 kill_udevd() {
-	if [ -x /sbin/pidof ]; then
-		pid=`/sbin/pidof -x udevd`
-		[ -n "$pid" ] && kill $pid
-	fi
+	pid=`pidof -x udevd`
+	[ -n "$pid" ] && kill $pid
 }
 
 export ACTION=add
diff --git a/meta/recipes-core/udev/udev_164.bb b/meta/recipes-core/udev/udev_164.bb
index b993a13..d661044 100644
--- a/meta/recipes-core/udev/udev_164.bb
+++ b/meta/recipes-core/udev/udev_164.bb
@@ -1,6 +1,6 @@ 
 include udev.inc
 
-PR = "r11"
+PR = "r12"
 
 SRC_URI += "file://udev-166-v4l1-1.patch"