Patchwork [PATCHv3] bluez4: add dependency on libcheck to enable test modules

login
register
mail settings
Submitter chase maupin
Date March 7, 2012, 8:48 p.m.
Message ID <1331153332-3782-1-git-send-email-Chase.Maupin@ti.com>
Download mbox | patch
Permalink /patch/22869/
State New
Headers show

Comments

chase maupin - March 7, 2012, 8:48 p.m.
* The later versions of bluez such as 4.98 require libcheck
  in order to build the test packages as enabled by the
  --enable-test option passed in EXTRA_OECONF.
* Failure to have the libcheck package available results in the
  configure script ignoring the --enable-test option and not
  building the test modules.
* Adding libcheck, which is greater than the minimum required
  version of the check library of 0.9.6 allows building the
  test modules.
* Build tested for am335x-evm MACHINE type and run time tested
  by back porting this fix to the oe-classic and arago setup
  and booting on am335x-evm.

Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
---
* Updated in version 2:
    * Bumped the PR of the bluez4_4.98 recipe.  I assume this is the
      way to handle changes to the .inc file since there is no INC_PR
* Updated in version 3:
    * Fixed typo in commit message
---
 meta/recipes-connectivity/bluez/bluez4.inc     |    2 +-
 meta/recipes-connectivity/bluez/bluez4_4.98.bb |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Richard Purdie - March 8, 2012, 8:13 p.m.
On Wed, 2012-03-07 at 14:48 -0600, Chase Maupin wrote:
> * The later versions of bluez such as 4.98 require libcheck
>   in order to build the test packages as enabled by the
>   --enable-test option passed in EXTRA_OECONF.
> * Failure to have the libcheck package available results in the
>   configure script ignoring the --enable-test option and not
>   building the test modules.
> * Adding libcheck, which is greater than the minimum required
>   version of the check library of 0.9.6 allows building the
>   test modules.
> * Build tested for am335x-evm MACHINE type and run time tested
>   by back porting this fix to the oe-classic and arago setup
>   and booting on am335x-evm.
> 
> Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
> ---
> * Updated in version 2:
>     * Bumped the PR of the bluez4_4.98 recipe.  I assume this is the
>       way to handle changes to the .inc file since there is no INC_PR
> * Updated in version 3:
>     * Fixed typo in commit message
> ---
>  meta/recipes-connectivity/bluez/bluez4.inc     |    2 +-
>  meta/recipes-connectivity/bluez/bluez4_4.98.bb |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-connectivity/bluez/bluez4.inc b/meta/recipes-connectivity/bluez/bluez4.inc
> index 9158687..fbbe0bf 100644
> --- a/meta/recipes-connectivity/bluez/bluez4.inc
> +++ b/meta/recipes-connectivity/bluez/bluez4.inc
> @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
>                      file://COPYING.LIB;md5=fb504b67c50331fc78734fed90fb0e09 \
>                      file://src/main.c;beginline=1;endline=24;md5=9bc54b93cd7e17bf03f52513f39f926e \
>                      file://sbc/sbc.c;beginline=1;endline=25;md5=1a40781ed30d50d8639323a184aeb191"
> -DEPENDS = "udev alsa-lib libusb dbus-glib glib-2.0"
> +DEPENDS = "udev alsa-lib libusb dbus-glib glib-2.0 libcheck"
>  RDEPENDS_${PN}-dev = "bluez-hcidump"
>  
>  ASNEEDED = ""

Merged to master, thanks.

Richard

Patch

diff --git a/meta/recipes-connectivity/bluez/bluez4.inc b/meta/recipes-connectivity/bluez/bluez4.inc
index 9158687..fbbe0bf 100644
--- a/meta/recipes-connectivity/bluez/bluez4.inc
+++ b/meta/recipes-connectivity/bluez/bluez4.inc
@@ -7,7 +7,7 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
                     file://COPYING.LIB;md5=fb504b67c50331fc78734fed90fb0e09 \
                     file://src/main.c;beginline=1;endline=24;md5=9bc54b93cd7e17bf03f52513f39f926e \
                     file://sbc/sbc.c;beginline=1;endline=25;md5=1a40781ed30d50d8639323a184aeb191"
-DEPENDS = "udev alsa-lib libusb dbus-glib glib-2.0"
+DEPENDS = "udev alsa-lib libusb dbus-glib glib-2.0 libcheck"
 RDEPENDS_${PN}-dev = "bluez-hcidump"
 
 ASNEEDED = ""
diff --git a/meta/recipes-connectivity/bluez/bluez4_4.98.bb b/meta/recipes-connectivity/bluez/bluez4_4.98.bb
index 2412b1b..9a4c682 100644
--- a/meta/recipes-connectivity/bluez/bluez4_4.98.bb
+++ b/meta/recipes-connectivity/bluez/bluez4_4.98.bb
@@ -1,6 +1,6 @@ 
 require bluez4.inc
 
-PR = "r1"
+PR = "r2"
 
 SRC_URI += "file://bluetooth.conf \
             file://sbc_mmx.patch \