Patchwork [PATCHv2] bluez4: add dependency on libcheck to enable test modules

login
register
mail settings
Submitter chase maupin
Date March 7, 2012, 12:32 p.m.
Message ID <1331123568-23178-1-git-send-email-Chase.Maupin@ti.com>
Download mbox | patch
Permalink /patch/22863/
State Accepted
Commit 6e5fc682a4d464f62fbba12e61a8bc8e97ff92e2
Headers show

Comments

chase maupin - March 7, 2012, 12:32 p.m.
* The later versions of bluez such as 4.98 require libcheck
  in order to build the test packages as enabled by the
  --enable-test option passed in EXTRA_OECONF.
* Failure to have the libcheck package availalbe results in the
  configure script ignoring the --enable-test option and not
  building the test modules.
* Adding libcheck, which is greater than the minimum required
  version of the check library of 0.9.6 allows building the
  test modules.
* Build tested for am335x-evm MACHINE type and run time tested
  by back porting this fix to the oe-classic and arago setup
  and booting on am335x-evm.

Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
---
* Updated in version 2:
    * Bumped the PR of the bluez4_4.98 recipe.  I assume this is the
      way to handle changes to the .inc file since there is no INC_PR

---
 meta/recipes-connectivity/bluez/bluez4.inc     |    2 +-
 meta/recipes-connectivity/bluez/bluez4_4.98.bb |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Paul Menzel - March 7, 2012, 12:43 p.m.
Am Mittwoch, den 07.03.2012, 06:32 -0600 schrieb Chase Maupin:
> * The later versions of bluez such as 4.98 require libcheck
>   in order to build the test packages as enabled by the
>   --enable-test option passed in EXTRA_OECONF.
> * Failure to have the libcheck package availalbe results in the

availa*bl*e

>   configure script ignoring the --enable-test option and not
>   building the test modules.
> * Adding libcheck, which is greater than the minimum required
>   version of the check library of 0.9.6 allows building the
>   test modules.
> * Build tested for am335x-evm MACHINE type and run time tested
>   by back porting this fix to the oe-classic and arago setup
>   and booting on am335x-evm.

Do you have a patch for that so that others can profit from this work
too?

> Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
> ---
> * Updated in version 2:
>     * Bumped the PR of the bluez4_4.98 recipe.  I assume this is the
>       way to handle changes to the .inc file since there is no INC_PR
> 
> ---
>  meta/recipes-connectivity/bluez/bluez4.inc     |    2 +-
>  meta/recipes-connectivity/bluez/bluez4_4.98.bb |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-connectivity/bluez/bluez4.inc b/meta/recipes-connectivity/bluez/bluez4.inc
> index 9158687..fbbe0bf 100644
> --- a/meta/recipes-connectivity/bluez/bluez4.inc
> +++ b/meta/recipes-connectivity/bluez/bluez4.inc
> @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
>                      file://COPYING.LIB;md5=fb504b67c50331fc78734fed90fb0e09 \
>                      file://src/main.c;beginline=1;endline=24;md5=9bc54b93cd7e17bf03f52513f39f926e \
>                      file://sbc/sbc.c;beginline=1;endline=25;md5=1a40781ed30d50d8639323a184aeb191"
> -DEPENDS = "udev alsa-lib libusb dbus-glib glib-2.0"
> +DEPENDS = "udev alsa-lib libusb dbus-glib glib-2.0 libcheck"
>  RDEPENDS_${PN}-dev = "bluez-hcidump"
>  
>  ASNEEDED = ""
> diff --git a/meta/recipes-connectivity/bluez/bluez4_4.98.bb b/meta/recipes-connectivity/bluez/bluez4_4.98.bb
> index 2412b1b..9a4c682 100644
> --- a/meta/recipes-connectivity/bluez/bluez4_4.98.bb
> +++ b/meta/recipes-connectivity/bluez/bluez4_4.98.bb
> @@ -1,6 +1,6 @@
>  require bluez4.inc
>  
> -PR = "r1"
> +PR = "r2"
>  
>  SRC_URI += "file://bluetooth.conf \
>              file://sbc_mmx.patch \

Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>


Thanks,

Paul
chase maupin - March 7, 2012, 8:47 p.m.
> -----Original Message-----
> From: Paul Menzel [mailto:paulepanter@users.sourceforge.net]
> Sent: Wednesday, March 07, 2012 6:43 AM
> To: openembedded-core@lists.openembedded.org
> Cc: Maupin, Chase
> Subject: Re: [OE-core] [PATCHv2] bluez4: add dependency on libcheck
> to enable test modules
> 
> Am Mittwoch, den 07.03.2012, 06:32 -0600 schrieb Chase Maupin:
> > * The later versions of bluez such as 4.98 require libcheck
> >   in order to build the test packages as enabled by the
> >   --enable-test option passed in EXTRA_OECONF.
> > * Failure to have the libcheck package availalbe results in the
> 
> availa*bl*e

I'll fix this.  thanks

> 
> >   configure script ignoring the --enable-test option and not
> >   building the test modules.
> > * Adding libcheck, which is greater than the minimum required
> >   version of the check library of 0.9.6 allows building the
> >   test modules.
> > * Build tested for am335x-evm MACHINE type and run time tested
> >   by back porting this fix to the oe-classic and arago setup
> >   and booting on am335x-evm.
> 
> Do you have a patch for that so that others can profit from this
> work
> too?

It is being made into an official patch for arago.  Currently it is on my build setup but a patch is pending.

> 
> > Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
> > ---
> > * Updated in version 2:
> >     * Bumped the PR of the bluez4_4.98 recipe.  I assume this is
> the
> >       way to handle changes to the .inc file since there is no
> INC_PR
> >
> > ---
> >  meta/recipes-connectivity/bluez/bluez4.inc     |    2 +-
> >  meta/recipes-connectivity/bluez/bluez4_4.98.bb |    2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta/recipes-connectivity/bluez/bluez4.inc
> b/meta/recipes-connectivity/bluez/bluez4.inc
> > index 9158687..fbbe0bf 100644
> > --- a/meta/recipes-connectivity/bluez/bluez4.inc
> > +++ b/meta/recipes-connectivity/bluez/bluez4.inc
> > @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM =
> "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
> >
> file://COPYING.LIB;md5=fb504b67c50331fc78734fed90fb0e09 \
> >
> file://src/main.c;beginline=1;endline=24;md5=9bc54b93cd7e17bf03f525
> 13f39f926e \
> >
> file://sbc/sbc.c;beginline=1;endline=25;md5=1a40781ed30d50d8639323a
> 184aeb191"
> > -DEPENDS = "udev alsa-lib libusb dbus-glib glib-2.0"
> > +DEPENDS = "udev alsa-lib libusb dbus-glib glib-2.0 libcheck"
> >  RDEPENDS_${PN}-dev = "bluez-hcidump"
> >
> >  ASNEEDED = ""
> > diff --git a/meta/recipes-connectivity/bluez/bluez4_4.98.bb
> b/meta/recipes-connectivity/bluez/bluez4_4.98.bb
> > index 2412b1b..9a4c682 100644
> > --- a/meta/recipes-connectivity/bluez/bluez4_4.98.bb
> > +++ b/meta/recipes-connectivity/bluez/bluez4_4.98.bb
> > @@ -1,6 +1,6 @@
> >  require bluez4.inc
> >
> > -PR = "r1"
> > +PR = "r2"
> >
> >  SRC_URI += "file://bluetooth.conf \
> >              file://sbc_mmx.patch \
> 
> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
> 
> 
> Thanks,
> 
> Paul
Saul Wold - March 12, 2012, 5:43 p.m.
On 03/07/2012 04:32 AM, Chase Maupin wrote:
> * The later versions of bluez such as 4.98 require libcheck
>    in order to build the test packages as enabled by the
>    --enable-test option passed in EXTRA_OECONF.
> * Failure to have the libcheck package availalbe results in the
>    configure script ignoring the --enable-test option and not
>    building the test modules.
> * Adding libcheck, which is greater than the minimum required
>    version of the check library of 0.9.6 allows building the
>    test modules.
> * Build tested for am335x-evm MACHINE type and run time tested
>    by back porting this fix to the oe-classic and arago setup
>    and booting on am335x-evm.
>
> Signed-off-by: Chase Maupin<Chase.Maupin@ti.com>
> ---
> * Updated in version 2:
>      * Bumped the PR of the bluez4_4.98 recipe.  I assume this is the
>        way to handle changes to the .inc file since there is no INC_PR
>
> ---
>   meta/recipes-connectivity/bluez/bluez4.inc     |    2 +-
>   meta/recipes-connectivity/bluez/bluez4_4.98.bb |    2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-connectivity/bluez/bluez4.inc b/meta/recipes-connectivity/bluez/bluez4.inc
> index 9158687..fbbe0bf 100644
> --- a/meta/recipes-connectivity/bluez/bluez4.inc
> +++ b/meta/recipes-connectivity/bluez/bluez4.inc
> @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
>                       file://COPYING.LIB;md5=fb504b67c50331fc78734fed90fb0e09 \
>                       file://src/main.c;beginline=1;endline=24;md5=9bc54b93cd7e17bf03f52513f39f926e \
>                       file://sbc/sbc.c;beginline=1;endline=25;md5=1a40781ed30d50d8639323a184aeb191"
> -DEPENDS = "udev alsa-lib libusb dbus-glib glib-2.0"
> +DEPENDS = "udev alsa-lib libusb dbus-glib glib-2.0 libcheck"
>   RDEPENDS_${PN}-dev = "bluez-hcidump"
>
>   ASNEEDED = ""
> diff --git a/meta/recipes-connectivity/bluez/bluez4_4.98.bb b/meta/recipes-connectivity/bluez/bluez4_4.98.bb
> index 2412b1b..9a4c682 100644
> --- a/meta/recipes-connectivity/bluez/bluez4_4.98.bb
> +++ b/meta/recipes-connectivity/bluez/bluez4_4.98.bb
> @@ -1,6 +1,6 @@
>   require bluez4.inc
>
> -PR = "r1"
> +PR = "r2"
>
>   SRC_URI += "file://bluetooth.conf \
>               file://sbc_mmx.patch \


Merged into OE-Core (with spelling mistake fixed)

Thanks
	Sau!
Paul Menzel - March 12, 2012, 10:39 p.m.
Am Montag, den 12.03.2012, 10:43 -0700 schrieb Saul Wold:
> On 03/07/2012 04:32 AM, Chase Maupin wrote:
> > * The later versions of bluez such as 4.98 require libcheck
> >    in order to build the test packages as enabled by the
> >    --enable-test option passed in EXTRA_OECONF.
> > * Failure to have the libcheck package availalbe results in the
> >    configure script ignoring the --enable-test option and not
> >    building the test modules.
> > * Adding libcheck, which is greater than the minimum required
> >    version of the check library of 0.9.6 allows building the
> >    test modules.
> > * Build tested for am335x-evm MACHINE type and run time tested
> >    by back porting this fix to the oe-classic and arago setup
> >    and booting on am335x-evm.
> >
> > Signed-off-by: Chase Maupin<Chase.Maupin@ti.com>
> > ---
> > * Updated in version 2:
> >      * Bumped the PR of the bluez4_4.98 recipe.  I assume this is the
> >        way to handle changes to the .inc file since there is no INC_PR
> >
> > ---
> >   meta/recipes-connectivity/bluez/bluez4.inc     |    2 +-
> >   meta/recipes-connectivity/bluez/bluez4_4.98.bb |    2 +-
> >   2 files changed, 2 insertions(+), 2 deletions(-)

[…]

> Merged into OE-Core (with spelling mistake fixed)

Chase thankfully submitted a v3 and Richard already merged that on
Thursday [1].


Thanks,

Paul


[1] Message-ID: <1331237581.3006.30.camel@ted>

Patch

diff --git a/meta/recipes-connectivity/bluez/bluez4.inc b/meta/recipes-connectivity/bluez/bluez4.inc
index 9158687..fbbe0bf 100644
--- a/meta/recipes-connectivity/bluez/bluez4.inc
+++ b/meta/recipes-connectivity/bluez/bluez4.inc
@@ -7,7 +7,7 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
                     file://COPYING.LIB;md5=fb504b67c50331fc78734fed90fb0e09 \
                     file://src/main.c;beginline=1;endline=24;md5=9bc54b93cd7e17bf03f52513f39f926e \
                     file://sbc/sbc.c;beginline=1;endline=25;md5=1a40781ed30d50d8639323a184aeb191"
-DEPENDS = "udev alsa-lib libusb dbus-glib glib-2.0"
+DEPENDS = "udev alsa-lib libusb dbus-glib glib-2.0 libcheck"
 RDEPENDS_${PN}-dev = "bluez-hcidump"
 
 ASNEEDED = ""
diff --git a/meta/recipes-connectivity/bluez/bluez4_4.98.bb b/meta/recipes-connectivity/bluez/bluez4_4.98.bb
index 2412b1b..9a4c682 100644
--- a/meta/recipes-connectivity/bluez/bluez4_4.98.bb
+++ b/meta/recipes-connectivity/bluez/bluez4_4.98.bb
@@ -1,6 +1,6 @@ 
 require bluez4.inc
 
-PR = "r1"
+PR = "r2"
 
 SRC_URI += "file://bluetooth.conf \
             file://sbc_mmx.patch \