Patchwork [bitbake-devel,1/1] bitbake/siggen: output filename on error in finalise

login
register
mail settings
Submitter Paul Eggleton
Date March 6, 2012, 11:37 p.m.
Message ID <789e78d1de4f36657addeb3a7264a6fabfa697e2.1331076902.git.paul.eggleton@linux.intel.com>
Download mbox | patch
Permalink /patch/22843/
State New
Headers show

Comments

Paul Eggleton - March 6, 2012, 11:37 p.m.
If an error occurs during finalise() (when for example we might get an
expansion error in SRCPV), log a note which mentions which recipe was
being finalised.

Fixes [YOCTO #1782]

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 bitbake/lib/bb/siggen.py |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
Richard Purdie - March 12, 2012, 2:21 a.m.
On Tue, 2012-03-06 at 23:37 +0000, Paul Eggleton wrote:
> If an error occurs during finalise() (when for example we might get an
> expansion error in SRCPV), log a note which mentions which recipe was
> being finalised.
> 
> Fixes [YOCTO #1782]
> 
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
>  bitbake/lib/bb/siggen.py |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)

Merged to master, thanks.

Richard

Patch

diff --git a/bitbake/lib/bb/siggen.py b/bitbake/lib/bb/siggen.py
index 975ae41..eaef4a8 100644
--- a/bitbake/lib/bb/siggen.py
+++ b/bitbake/lib/bb/siggen.py
@@ -126,7 +126,11 @@  class SignatureGeneratorBasic(SignatureGenerator):
         if variant:
             fn = "virtual:" + variant + ":" + fn
 
-        taskdeps = self._build_data(fn, d)
+        try:
+            taskdeps = self._build_data(fn, d)
+        except:
+            bb.note("Error during finalise of %s" % fn)
+            raise
 
         #Slow but can be useful for debugging mismatched basehashes
         #for task in self.taskdeps[fn]: