Patchwork [v2] firefox: Added libIDL-2.0 CFLAGS and LIBS

login
register
mail settings
Submitter Patrik Dahlström
Date April 15, 2011, 4:42 p.m.
Message ID <1302885760-32195-1-git-send-email-patda293@student.liu.se>
Download mbox | patch
Permalink /patch/2283/
State New, archived
Headers show

Comments

Patrik Dahlström - April 15, 2011, 4:42 p.m.
* autoconf does not fill in any CFLAGS or LIBS for libIDL-2.0. This
  patch sets the appropriate flags in autoconf.mk.in for
  HOST_LIBIDL_CFLAGS and HOST_LIBIDL_LIBS.

Signed-off-by: Patrik Dahlström <patda293@student.liu.se>
---
 recipes/mozilla/firefox_3.6.8.bb |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)
Denis Carikli - April 15, 2011, 8:40 p.m.
On Fri, 2011-04-15 at 18:42 +0200, Patrik Dahlström wrote:
> * autoconf does not fill in any CFLAGS or LIBS for libIDL-2.0. This
>   patch sets the appropriate flags in autoconf.mk.in for
>   HOST_LIBIDL_CFLAGS and HOST_LIBIDL_LIBS.
What error did you get?
Maybe you could add something like:
 This patch fixes the following error:
 [ERROR here]
To the commit message.

By the way, thanks a lot for the fix.

Denis.
Paul Menzel - April 16, 2011, 12:28 p.m.
Am Freitag, den 15.04.2011, 22:40 +0200 schrieb Denis 'GNUtoo' Carikli:
> On Fri, 2011-04-15 at 18:42 +0200, Patrik Dahlström wrote:
> > * autoconf does not fill in any CFLAGS or LIBS for libIDL-2.0. This
> >   patch sets the appropriate flags in autoconf.mk.in for
> >   HOST_LIBIDL_CFLAGS and HOST_LIBIDL_LIBS.
> What error did you get?
> Maybe you could add something like:
>  This patch fixes the following error:
>  [ERROR here]
> To the commit message.

I get the following error message.

        make[7]: Entering directory `/oe/build-minimal-eglibc/minimal-dev/work/armv7a-oe-linux-gnueabi/firefox-3.6.8-r3/mozilla-1.9.2/xpcom/typelib/xpidl'
        xpidl.c
        gcc -o host_xpidl.o -c -isystem/oe/build-minimal-eglibc/minimal-dev/sysroots/i686-linux/usr/include -O2 -g -DXP_UNIX -O3  -DMDCPUCFG=\"md/_linux.cfg\"  -I. -I. -I../../..
        /dist/include -I../../../dist/include/nsprpub  -I/oe/build-minimal-eglibc/minimal-dev/work/armv7a-oe-linux-gnueabi/firefox-3.6.8-r3/mozilla-1.9.2/dist/include/nspr -I/hom
        e/paul/oe/build-minimal-eglibc/minimal-dev/work/armv7a-oe-linux-gnueabi/firefox-3.6.8-r3/mozilla-1.9.2/dist/include/nss      -I/oe/build-minimal-eglibc/minimal-dev/work/a
        rmv7a-oe-linux-gnueabi/firefox-3.6.8-r3/mozilla-1.9.2/dist/include/nspr xpidl.c
        
        In file included from xpidl.c:42:
        xpidl.h:49:18: error: glib.h: No such file or directory
        In file included from xpidl_idl.c:43:
        xpidl.h:49:18: error: glib.h: No such file or directory
        In file included from xpidl_util.c:42:
        xpidl.h:49:18: error: glib.h: No such file or directory
        In file included from xpidl_header.c:42:
        xpidl.h:49:18: error: glib.h: No such file or directory
        xpidl.h:52:24: error: libIDL/IDL.h: No such file or directory
        xpidl.h:52:24: error: libIDL/IDL.h: No such file or directory
        xpidl.h:52:24: error: libIDL/IDL.h: No such file or directory
        In file included from xpidl.c:42:
        xpidl.h:79: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'enable_debug'
        xpidl.h:80: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'enable_warnings'
        xpidl.h:81: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'verbose_mode'
        xpidl.h:82: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'emit_typelib_annotations'
        xpidl.h:83: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'explicit_output_filename'
        In file included from xpidl_idl.c:43:
        xpidl.h:79: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'enable_debug'
        xpidl.h:80: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'enable_warnings'
        xpidl.h:94: error: expected declaration specifiers or '...' before '*' tokenxpidl.h:81: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'verbose_mode'
        
        xpidl.h:82: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'emit_typelib_annotations'
        xpidl.h:94: error: 'gboolean' declared as function returning a function
        xpidl.h:83: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'explicit_output_filename'
        xpidl.h:100: error: expected specifier-qualifier-list before 'nodeHandler'
        xpidl.h:94: error: expected declaration specifiers or '...' before '*' token
        xpidl.h:94: error: 'gboolean' declared as function returning a function
        xpidl.h:100: error: expected specifier-qualifier-list before 'nodeHandler'
        xpidl.h:130: error: expected specifier-qualifier-list before 'IDL_ns'
        xpidl.h:138: error: expected specifier-qualifier-list before 'GHashTable'
        xpidl.h:130: error: expected specifier-qualifier-list before 'IDL_ns'
        xpidl.h:156: error: expected ')' before 'p'
        xpidl.h:138: error: expected specifier-qualifier-list before 'GHashTable'
        xpidl.h:177: error: 'xpidl_process_node' declared as function returning a function
        xpidl.h:156: error: expected ')' before 'p'
        xpidl.h:202: error: 'xpidl_sprint_iid' declared as function returning a function
        xpidl.h:177: error: 'xpidl_process_node' declared as function returning a functionxpidl.h:209: error: 'xpidl_parse_iid' declared as function returning a function
        
        xpidl.h:202: error: 'xpidl_sprint_iid' declared as function returning a function
        xpidl.h:241: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'find_underlying_type'xpidl.h:209: error: 'xpidl_parse_iid' declared as function returning a function
        
        xpidl.h:248: error: expected ')' before 'const_tree'
        xpidl.h:254: error: expected ')' before 'method_tree'
        xpidl.h:260: error: expected ')' before 'method_tree'
        xpidl.h:266: error: expected ')' before 'method_tree'xpidl.h:241: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'find_underlying_type'
        
        xpidl.h:273: error: 'check_native' declared as function returning a functionxpidl.h:248: error: expected ')' before 'const_tree'
        
        xpidl.h:254: error: expected ')' before 'method_tree'
        xpidl.h:276: error: expected declaration specifiers or '...' before 'GSList'
        xpidl.h:260: error: expected ')' before 'method_tree'
        xpidl.h:279: error: expected ')' before 'method_tree'xpidl.h:266: error: expected ')' before 'method_tree'
        
        xpidl.h:273: error: 'check_native' declared as function returning a function
        xpidl.h:276: error: expected declaration specifiers or '...' before 'GSList'
        xpidl.h:279: error: expected ')' before 'method_tree'

> By the way, thanks a lot for the fix.

I am testing this patch right now and will see if also a dependency on
`glib-2.0` is needed.


Thanks,

Paul
Paul Menzel - April 16, 2011, 1:27 p.m.
Am Samstag, den 16.04.2011, 14:28 +0200 schrieb Paul Menzel:
> Am Freitag, den 15.04.2011, 22:40 +0200 schrieb Denis 'GNUtoo' Carikli:
> > On Fri, 2011-04-15 at 18:42 +0200, Patrik Dahlström wrote:
> > > * autoconf does not fill in any CFLAGS or LIBS for libIDL-2.0. This
> > >   patch sets the appropriate flags in autoconf.mk.in for
> > >   HOST_LIBIDL_CFLAGS and HOST_LIBIDL_LIBS.
> > What error did you get?
> > Maybe you could add something like:
> >  This patch fixes the following error:
> >  [ERROR here]
> > To the commit message.
> 
> I get the following error message.
> 
>         make[7]: Entering directory `/oe/build-minimal-eglibc/minimal-dev/work/armv7a-oe-linux-gnueabi/firefox-3.6.8-r3/mozilla-1.9.2/xpcom/typelib/xpidl'
>         xpidl.c
>         gcc -o host_xpidl.o -c -isystem/oe/build-minimal-eglibc/minimal-dev/sysroots/i686-linux/usr/include -O2 -g -DXP_UNIX -O3  -DMDCPUCFG=\"md/_linux.cfg\"  -I. -I. -I../../..
>         /dist/include -I../../../dist/include/nsprpub  -I/oe/build-minimal-eglibc/minimal-dev/work/armv7a-oe-linux-gnueabi/firefox-3.6.8-r3/mozilla-1.9.2/dist/include/nspr -I/hom
>         e/paul/oe/build-minimal-eglibc/minimal-dev/work/armv7a-oe-linux-gnueabi/firefox-3.6.8-r3/mozilla-1.9.2/dist/include/nss      -I/oe/build-minimal-eglibc/minimal-dev/work/a
>         rmv7a-oe-linux-gnueabi/firefox-3.6.8-r3/mozilla-1.9.2/dist/include/nspr xpidl.c
>         
>         In file included from xpidl.c:42:
>         xpidl.h:49:18: error: glib.h: No such file or directory
>         In file included from xpidl_idl.c:43:
>         xpidl.h:49:18: error: glib.h: No such file or directory
>         In file included from xpidl_util.c:42:
>         xpidl.h:49:18: error: glib.h: No such file or directory
>         In file included from xpidl_header.c:42:
>         xpidl.h:49:18: error: glib.h: No such file or directory
>         xpidl.h:52:24: error: libIDL/IDL.h: No such file or directory
>         xpidl.h:52:24: error: libIDL/IDL.h: No such file or directory
>         xpidl.h:52:24: error: libIDL/IDL.h: No such file or directory
>         In file included from xpidl.c:42:
>         xpidl.h:79: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'enable_debug'
>         xpidl.h:80: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'enable_warnings'
>         xpidl.h:81: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'verbose_mode'
>         xpidl.h:82: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'emit_typelib_annotations'
>         xpidl.h:83: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'explicit_output_filename'
>         In file included from xpidl_idl.c:43:
>         xpidl.h:79: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'enable_debug'
>         xpidl.h:80: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'enable_warnings'
>         xpidl.h:94: error: expected declaration specifiers or '...' before '*' tokenxpidl.h:81: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'verbose_mode'
>         
>         xpidl.h:82: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'emit_typelib_annotations'
>         xpidl.h:94: error: 'gboolean' declared as function returning a function
>         xpidl.h:83: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'explicit_output_filename'
>         xpidl.h:100: error: expected specifier-qualifier-list before 'nodeHandler'
>         xpidl.h:94: error: expected declaration specifiers or '...' before '*' token
>         xpidl.h:94: error: 'gboolean' declared as function returning a function
>         xpidl.h:100: error: expected specifier-qualifier-list before 'nodeHandler'
>         xpidl.h:130: error: expected specifier-qualifier-list before 'IDL_ns'
>         xpidl.h:138: error: expected specifier-qualifier-list before 'GHashTable'
>         xpidl.h:130: error: expected specifier-qualifier-list before 'IDL_ns'
>         xpidl.h:156: error: expected ')' before 'p'
>         xpidl.h:138: error: expected specifier-qualifier-list before 'GHashTable'
>         xpidl.h:177: error: 'xpidl_process_node' declared as function returning a function
>         xpidl.h:156: error: expected ')' before 'p'
>         xpidl.h:202: error: 'xpidl_sprint_iid' declared as function returning a function
>         xpidl.h:177: error: 'xpidl_process_node' declared as function returning a functionxpidl.h:209: error: 'xpidl_parse_iid' declared as function returning a function
>         
>         xpidl.h:202: error: 'xpidl_sprint_iid' declared as function returning a function
>         xpidl.h:241: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'find_underlying_type'xpidl.h:209: error: 'xpidl_parse_iid' declared as function returning a function
>         
>         xpidl.h:248: error: expected ')' before 'const_tree'
>         xpidl.h:254: error: expected ')' before 'method_tree'
>         xpidl.h:260: error: expected ')' before 'method_tree'
>         xpidl.h:266: error: expected ')' before 'method_tree'xpidl.h:241: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'find_underlying_type'
>         
>         xpidl.h:273: error: 'check_native' declared as function returning a functionxpidl.h:248: error: expected ')' before 'const_tree'
>         
>         xpidl.h:254: error: expected ')' before 'method_tree'
>         xpidl.h:276: error: expected declaration specifiers or '...' before 'GSList'
>         xpidl.h:260: error: expected ')' before 'method_tree'
>         xpidl.h:279: error: expected ')' before 'method_tree'xpidl.h:266: error: expected ')' before 'method_tree'
>         
>         xpidl.h:273: error: 'check_native' declared as function returning a function
>         xpidl.h:276: error: expected declaration specifiers or '...' before 'GSList'
>         xpidl.h:279: error: expected ')' before 'method_tree'
> 
> > By the way, thanks a lot for the fix.
> 
> I am testing this patch right now and will see if also a dependency on
> `glib-2.0` is needed.

Patrik’s patch worked just fine.

        Build Configuration:
        BB_VERSION        = "1.12.0"
        METADATA_BRANCH   = "gitorious"
        METADATA_REVISION = "2acbb95"
        TARGET_ARCH       = "arm"
        TARGET_OS         = "linux-gnueabi"
        MACHINE           = "beagleboard"
        DISTRO            = "minimal"
        DISTRO_VERSION    = "dev-snapshot-20110416"
        TARGET_FPU        = "hard"


Thanks,

Paul
Paul Menzel - April 16, 2011, 1:28 p.m.
Dear Patrik,


Am Freitag, den 15.04.2011, 18:42 +0200 schrieb Patrik Dahlström:
> * autoconf does not fill in any CFLAGS or LIBS for libIDL-2.0. This
>   patch sets the appropriate flags in autoconf.mk.in for
>   HOST_LIBIDL_CFLAGS and HOST_LIBIDL_LIBS.
> 
> Signed-off-by: Patrik Dahlström <patda293@student.liu.se>
> ---
>  recipes/mozilla/firefox_3.6.8.bb |    7 +++++--
>  1 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/recipes/mozilla/firefox_3.6.8.bb b/recipes/mozilla/firefox_3.6.8.bb
> index 04dde08..828822c 100644
> --- a/recipes/mozilla/firefox_3.6.8.bb
> +++ b/recipes/mozilla/firefox_3.6.8.bb
> @@ -28,6 +28,7 @@ SRC_URI[archive.md5sum] = "0ee5f14fd8be07513d16131027ebcb61"
>  SRC_URI[archive.sha256sum] = "fc609cc6a0ddaa2a9ebd8511ec39ae4a404e1107a12e07b233e2afca51d9a10e"
>  
>  S = "${WORKDIR}/mozilla-1.9.2"
> +export PKG_CONFIG=${STAGING_BINDIR_NATIVE}/pkg-config

is that line really needed?

>  inherit mozilla
>  require firefox.inc
> @@ -37,7 +38,9 @@ EXTRA_OECONF += " --enable-official-branding --disable-crashreporter"
>  FULL_OPTIMIZATION = "-fexpensive-optimizations -fomit-frame-pointer -frename-registers -O2"
>  
>  do_compile_prepend() {
> -	cp ${WORKDIR}/jsautocfg.h ${S}/js/src/
> -	sed -i "s|CPU_ARCH =|CPU_ARCH = ${TARGET_ARCH}|" security/coreconf/Linux.mk
> +    cp ${WORKDIR}/jsautocfg.h ${S}/js/src/
> +    sed -i "s|CPU_ARCH =|CPU_ARCH = ${TARGET_ARCH}|" security/coreconf/Linux.mk
> +    sed -i "s|HOST_LIBIDL_CFLAGS = \@HOST_LIBIDL_CFLAGS\@|HOST_LIBIDL_CFLAGS = $(pkg-config --cflags libIDL-2.0)|" config/autoconf.mk.in
> +    sed -i "s|HOST_LIBIDL_LIBS   = @HOST_LIBIDL_LIBS@|HOST_LIBIDL_LIBS = $(pkg-config --libs libIDL-2.0)|" config/autoconf.mk.in
>  }

Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>

Is that bug fixed in newer releases of Firefox?


Thanks,

Paul
Paul Menzel - April 16, 2011, 7:18 p.m.
Am Samstag, den 16.04.2011, 15:27 +0200 schrieb Paul Menzel:
> Am Samstag, den 16.04.2011, 14:28 +0200 schrieb Paul Menzel:
> > Am Freitag, den 15.04.2011, 22:40 +0200 schrieb Denis 'GNUtoo' Carikli:
> > > On Fri, 2011-04-15 at 18:42 +0200, Patrik Dahlström wrote:
> > > > * autoconf does not fill in any CFLAGS or LIBS for libIDL-2.0. This
> > > >   patch sets the appropriate flags in autoconf.mk.in for
> > > >   HOST_LIBIDL_CFLAGS and HOST_LIBIDL_LIBS.
> > > What error did you get?
> > > Maybe you could add something like:
> > >  This patch fixes the following error:
> > >  [ERROR here]
> > > To the commit message.
> > 
> > I get the following error message.
> > 
> >         make[7]: Entering directory `/oe/build-minimal-eglibc/minimal-dev/work/armv7a-oe-linux-gnueabi/firefox-3.6.8-r3/mozilla-1.9.2/xpcom/typelib/xpidl'
> >         xpidl.c
> >         gcc -o host_xpidl.o -c -isystem/oe/build-minimal-eglibc/minimal-dev/sysroots/i686-linux/usr/include -O2 -g -DXP_UNIX -O3  -DMDCPUCFG=\"md/_linux.cfg\"  -I. -I. -I../../..
> >         /dist/include -I../../../dist/include/nsprpub  -I/oe/build-minimal-eglibc/minimal-dev/work/armv7a-oe-linux-gnueabi/firefox-3.6.8-r3/mozilla-1.9.2/dist/include/nspr -I/hom
> >         e/paul/oe/build-minimal-eglibc/minimal-dev/work/armv7a-oe-linux-gnueabi/firefox-3.6.8-r3/mozilla-1.9.2/dist/include/nss      -I/oe/build-minimal-eglibc/minimal-dev/work/a
> >         rmv7a-oe-linux-gnueabi/firefox-3.6.8-r3/mozilla-1.9.2/dist/include/nspr xpidl.c
> >         
> >         In file included from xpidl.c:42:
> >         xpidl.h:49:18: error: glib.h: No such file or directory
> >         In file included from xpidl_idl.c:43:
> >         xpidl.h:49:18: error: glib.h: No such file or directory
> >         In file included from xpidl_util.c:42:
> >         xpidl.h:49:18: error: glib.h: No such file or directory
> >         In file included from xpidl_header.c:42:
> >         xpidl.h:49:18: error: glib.h: No such file or directory
> >         xpidl.h:52:24: error: libIDL/IDL.h: No such file or directory
> >         xpidl.h:52:24: error: libIDL/IDL.h: No such file or directory
> >         xpidl.h:52:24: error: libIDL/IDL.h: No such file or directory
> >         In file included from xpidl.c:42:
> >         xpidl.h:79: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'enable_debug'
> >         xpidl.h:80: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'enable_warnings'
> >         xpidl.h:81: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'verbose_mode'
> >         xpidl.h:82: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'emit_typelib_annotations'
> >         xpidl.h:83: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'explicit_output_filename'
> >         In file included from xpidl_idl.c:43:
> >         xpidl.h:79: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'enable_debug'
> >         xpidl.h:80: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'enable_warnings'
> >         xpidl.h:94: error: expected declaration specifiers or '...' before '*' tokenxpidl.h:81: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'verbose_mode'
> >         
> >         xpidl.h:82: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'emit_typelib_annotations'
> >         xpidl.h:94: error: 'gboolean' declared as function returning a function
> >         xpidl.h:83: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'explicit_output_filename'
> >         xpidl.h:100: error: expected specifier-qualifier-list before 'nodeHandler'
> >         xpidl.h:94: error: expected declaration specifiers or '...' before '*' token
> >         xpidl.h:94: error: 'gboolean' declared as function returning a function
> >         xpidl.h:100: error: expected specifier-qualifier-list before 'nodeHandler'
> >         xpidl.h:130: error: expected specifier-qualifier-list before 'IDL_ns'
> >         xpidl.h:138: error: expected specifier-qualifier-list before 'GHashTable'
> >         xpidl.h:130: error: expected specifier-qualifier-list before 'IDL_ns'
> >         xpidl.h:156: error: expected ')' before 'p'
> >         xpidl.h:138: error: expected specifier-qualifier-list before 'GHashTable'
> >         xpidl.h:177: error: 'xpidl_process_node' declared as function returning a function
> >         xpidl.h:156: error: expected ')' before 'p'
> >         xpidl.h:202: error: 'xpidl_sprint_iid' declared as function returning a function
> >         xpidl.h:177: error: 'xpidl_process_node' declared as function returning a functionxpidl.h:209: error: 'xpidl_parse_iid' declared as function returning a function
> >         
> >         xpidl.h:202: error: 'xpidl_sprint_iid' declared as function returning a function
> >         xpidl.h:241: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'find_underlying_type'xpidl.h:209: error: 'xpidl_parse_iid' declared as function returning a function
> >         
> >         xpidl.h:248: error: expected ')' before 'const_tree'
> >         xpidl.h:254: error: expected ')' before 'method_tree'
> >         xpidl.h:260: error: expected ')' before 'method_tree'
> >         xpidl.h:266: error: expected ')' before 'method_tree'xpidl.h:241: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'find_underlying_type'
> >         
> >         xpidl.h:273: error: 'check_native' declared as function returning a functionxpidl.h:248: error: expected ')' before 'const_tree'
> >         
> >         xpidl.h:254: error: expected ')' before 'method_tree'
> >         xpidl.h:276: error: expected declaration specifiers or '...' before 'GSList'
> >         xpidl.h:260: error: expected ')' before 'method_tree'
> >         xpidl.h:279: error: expected ')' before 'method_tree'xpidl.h:266: error: expected ')' before 'method_tree'
> >         
> >         xpidl.h:273: error: 'check_native' declared as function returning a function
> >         xpidl.h:276: error: expected declaration specifiers or '...' before 'GSList'
> >         xpidl.h:279: error: expected ')' before 'method_tree'
> > 
> > > By the way, thanks a lot for the fix.
> > 
> > I am testing this patch right now and will see if also a dependency on
> > `glib-2.0` is needed.
> 
> Patrik’s patch worked just fine.
> 
>         Build Configuration:
>         BB_VERSION        = "1.12.0"
>         METADATA_BRANCH   = "gitorious"
>         METADATA_REVISION = "2acbb95"
>         TARGET_ARCH       = "arm"
>         TARGET_OS         = "linux-gnueabi"
>         MACHINE           = "beagleboard"
>         DISTRO            = "minimal"
>         DISTRO_VERSION    = "dev-snapshot-20110416"
>         TARGET_FPU        = "hard"

Please wait until tomorrow. I think I made a mistake testing the patch.


Thanks,

Paul
Denis Carikli - April 16, 2011, 7:34 p.m.
On Sat, 2011-04-16 at 14:28 +0200, Paul Menzel wrote:
> Am Freitag, den 15.04.2011, 22:40 +0200 schrieb Denis 'GNUtoo' Carikli:
> > On Fri, 2011-04-15 at 18:42 +0200, Patrik Dahlström wrote:
> > > * autoconf does not fill in any CFLAGS or LIBS for libIDL-2.0. This
> > >   patch sets the appropriate flags in autoconf.mk.in for
> > >   HOST_LIBIDL_CFLAGS and HOST_LIBIDL_LIBS.
> > What error did you get?
> > Maybe you could add something like:
> >  This patch fixes the following error:
> >  [ERROR here]
> > To the commit message.
> 
> I get the following error message.
> 
>         make[7]: Entering directory `/oe/build-minimal-eglibc/minimal-dev/work/armv7a-oe-linux-gnueabi/firefox-3.6.8-r3/mozilla-1.9.2/xpcom/typelib/xpidl'
>         xpidl.c
>         gcc -o host_xpidl.o -c -isystem/oe/build-minimal-eglibc/minimal-dev/sysroots/i686-linux/usr/include -O2 -g -DXP_UNIX -O3  -DMDCPUCFG=\"md/_linux.cfg\"  -I. -I. -I../../..
>         /dist/include -I../../../dist/include/nsprpub  -I/oe/build-minimal-eglibc/minimal-dev/work/armv7a-oe-linux-gnueabi/firefox-3.6.8-r3/mozilla-1.9.2/dist/include/nspr -I/hom
>         e/paul/oe/build-minimal-eglibc/minimal-dev/work/armv7a-oe-linux-gnueabi/firefox-3.6.8-r3/mozilla-1.9.2/dist/include/nss      -I/oe/build-minimal-eglibc/minimal-dev/work/a
>         rmv7a-oe-linux-gnueabi/firefox-3.6.8-r3/mozilla-1.9.2/dist/include/nspr xpidl.c
>         
>         In file included from xpidl.c:42:
>         xpidl.h:49:18: error: glib.h: No such file or directory
I think I had the same error while trying to cross-compile firefox(I
remember some glib.h) ...

Thanks a lot for the patch.

Denis.
Paul Menzel - April 17, 2011, 10:39 a.m.
Am Samstag, den 16.04.2011, 21:18 +0200 schrieb Paul Menzel:
> Am Samstag, den 16.04.2011, 15:27 +0200 schrieb Paul Menzel:
> > Am Samstag, den 16.04.2011, 14:28 +0200 schrieb Paul Menzel:
> > > Am Freitag, den 15.04.2011, 22:40 +0200 schrieb Denis 'GNUtoo' Carikli:
> > > > On Fri, 2011-04-15 at 18:42 +0200, Patrik Dahlström wrote:
> > > > > * autoconf does not fill in any CFLAGS or LIBS for libIDL-2.0. This
> > > > >   patch sets the appropriate flags in autoconf.mk.in for
> > > > >   HOST_LIBIDL_CFLAGS and HOST_LIBIDL_LIBS.
> > > > What error did you get?
> > > > Maybe you could add something like:
> > > >  This patch fixes the following error:
> > > >  [ERROR here]
> > > > To the commit message.
> > > 
> > > I get the following error message.
> > > 
> > >         make[7]: Entering directory `/oe/build-minimal-eglibc/minimal-dev/work/armv7a-oe-linux-gnueabi/firefox-3.6.8-r3/mozilla-1.9.2/xpcom/typelib/xpidl'
> > >         xpidl.c
> > >         gcc -o host_xpidl.o -c -isystem/oe/build-minimal-eglibc/minimal-dev/sysroots/i686-linux/usr/include -O2 -g -DXP_UNIX -O3  -DMDCPUCFG=\"md/_linux.cfg\"  -I. -I. -I../../..
> > >         /dist/include -I../../../dist/include/nsprpub  -I/oe/build-minimal-eglibc/minimal-dev/work/armv7a-oe-linux-gnueabi/firefox-3.6.8-r3/mozilla-1.9.2/dist/include/nspr -I/hom
> > >         e/paul/oe/build-minimal-eglibc/minimal-dev/work/armv7a-oe-linux-gnueabi/firefox-3.6.8-r3/mozilla-1.9.2/dist/include/nss      -I/oe/build-minimal-eglibc/minimal-dev/work/a
> > >         rmv7a-oe-linux-gnueabi/firefox-3.6.8-r3/mozilla-1.9.2/dist/include/nspr xpidl.c
> > >         
> > >         In file included from xpidl.c:42:
> > >         xpidl.h:49:18: error: glib.h: No such file or directory
> > >         In file included from xpidl_idl.c:43:
> > >         xpidl.h:49:18: error: glib.h: No such file or directory
> > >         In file included from xpidl_util.c:42:
> > >         xpidl.h:49:18: error: glib.h: No such file or directory
> > >         In file included from xpidl_header.c:42:
> > >         xpidl.h:49:18: error: glib.h: No such file or directory
> > >         xpidl.h:52:24: error: libIDL/IDL.h: No such file or directory
> > >         xpidl.h:52:24: error: libIDL/IDL.h: No such file or directory
> > >         xpidl.h:52:24: error: libIDL/IDL.h: No such file or directory
> > >         In file included from xpidl.c:42:
> > >         xpidl.h:79: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'enable_debug'
> > >         xpidl.h:80: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'enable_warnings'
> > >         xpidl.h:81: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'verbose_mode'
> > >         xpidl.h:82: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'emit_typelib_annotations'
> > >         xpidl.h:83: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'explicit_output_filename'
> > >         In file included from xpidl_idl.c:43:
> > >         xpidl.h:79: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'enable_debug'
> > >         xpidl.h:80: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'enable_warnings'
> > >         xpidl.h:94: error: expected declaration specifiers or '...' before '*' tokenxpidl.h:81: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'verbose_mode'
> > >         
> > >         xpidl.h:82: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'emit_typelib_annotations'
> > >         xpidl.h:94: error: 'gboolean' declared as function returning a function
> > >         xpidl.h:83: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'explicit_output_filename'
> > >         xpidl.h:100: error: expected specifier-qualifier-list before 'nodeHandler'
> > >         xpidl.h:94: error: expected declaration specifiers or '...' before '*' token
> > >         xpidl.h:94: error: 'gboolean' declared as function returning a function
> > >         xpidl.h:100: error: expected specifier-qualifier-list before 'nodeHandler'
> > >         xpidl.h:130: error: expected specifier-qualifier-list before 'IDL_ns'
> > >         xpidl.h:138: error: expected specifier-qualifier-list before 'GHashTable'
> > >         xpidl.h:130: error: expected specifier-qualifier-list before 'IDL_ns'
> > >         xpidl.h:156: error: expected ')' before 'p'
> > >         xpidl.h:138: error: expected specifier-qualifier-list before 'GHashTable'
> > >         xpidl.h:177: error: 'xpidl_process_node' declared as function returning a function
> > >         xpidl.h:156: error: expected ')' before 'p'
> > >         xpidl.h:202: error: 'xpidl_sprint_iid' declared as function returning a function
> > >         xpidl.h:177: error: 'xpidl_process_node' declared as function returning a functionxpidl.h:209: error: 'xpidl_parse_iid' declared as function returning a function
> > >         
> > >         xpidl.h:202: error: 'xpidl_sprint_iid' declared as function returning a function
> > >         xpidl.h:241: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'find_underlying_type'xpidl.h:209: error: 'xpidl_parse_iid' declared as function returning a function
> > >         
> > >         xpidl.h:248: error: expected ')' before 'const_tree'
> > >         xpidl.h:254: error: expected ')' before 'method_tree'
> > >         xpidl.h:260: error: expected ')' before 'method_tree'
> > >         xpidl.h:266: error: expected ')' before 'method_tree'xpidl.h:241: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'find_underlying_type'
> > >         
> > >         xpidl.h:273: error: 'check_native' declared as function returning a functionxpidl.h:248: error: expected ')' before 'const_tree'
> > >         
> > >         xpidl.h:254: error: expected ')' before 'method_tree'
> > >         xpidl.h:276: error: expected declaration specifiers or '...' before 'GSList'
> > >         xpidl.h:260: error: expected ')' before 'method_tree'
> > >         xpidl.h:279: error: expected ')' before 'method_tree'xpidl.h:266: error: expected ')' before 'method_tree'
> > >         
> > >         xpidl.h:273: error: 'check_native' declared as function returning a function
> > >         xpidl.h:276: error: expected declaration specifiers or '...' before 'GSList'
> > >         xpidl.h:279: error: expected ')' before 'method_tree'
> > > 
> > > > By the way, thanks a lot for the fix.
> > > 
> > > I am testing this patch right now and will see if also a dependency on
> > > `glib-2.0` is needed.
> > 
> > Patrik’s patch worked just fine.
> > 
> >         Build Configuration:
> >         BB_VERSION        = "1.12.0"
> >         METADATA_BRANCH   = "firefox"
> >         METADATA_REVISION = "2acbb95"
> >         TARGET_ARCH       = "arm"
> >         TARGET_OS         = "linux-gnueabi"
> >         MACHINE           = "beagleboard"
> >         DISTRO            = "minimal"
> >         DISTRO_VERSION    = "dev-snapshot-20110416"
> >         TARGET_FPU        = "hard"
> 
> Please wait until tomorrow. I think I made a mistake testing the patch.

Ok, it did work alright. Also tested using ?ngström.

        Build Configuration:
        BB_VERSION        = "1.12.0"
        METADATA_BRANCH   = "firefox"
        METADATA_REVISION = "2acbb95"
        TARGET_ARCH       = "arm"
        TARGET_OS         = "linux-gnueabi"
        MACHINE           = "beagleboard"
        DISTRO            = "angstrom"
        DISTRO_VERSION    = "v20110417"
        TARGET_FPU        = "hard"

I have problems compiling it using `minimal-uclibc` though. But this
probably belongs to a different thread.

        jsfun.h: In function 'js_ArgsPrivateNative* js_GetArgsPrivateNative(JSObject*)':
        jsfun.h:233:55: warning: converting to non-pointer type 'unsigned int' from NULL
        In file included from jsinterp.h:50:0,
                         from jscntxt.h:53,
                         from jsbool.cpp:49:
        jsscript.h: In member function 'JSObjectArray* JSScript::objects()':
        jsscript.h:141:64: warning: cast from 'uint8*' to 'JSObjectArray*' increases required alignment of target type
        jsscript.h: In member function 'JSUpvarArray* JSScript::upvars()':
        jsscript.h:146:63: warning: cast from 'uint8*' to 'JSUpvarArray*' increases required alignment of target type
        jsscript.h: In member function 'JSObjectArray* JSScript::regexps()':
        jsscript.h:151:65: warning: cast from 'uint8*' to 'JSObjectArray*' increases required alignment of target type
        jsscript.h: In member function 'JSTryNoteArray* JSScript::trynotes()':
        jsscript.h:156:67: warning: cast from 'uint8*' to 'JSTryNoteArray*' increases required alignment of target type
        In file included from jsbool.cpp:49:0:
        jscntxt.h: In function 'JSAtom** FrameAtomBase(JSContext*, JSStackFrame*)':
        jscntxt.h:1307:14: warning: cast from 'uint8*' to 'JSAtom**' increases required alignment of target type
        jscntxt.h: In function 'JSContext* js_ContextFromLinkField(JSCList*)':
        jscntxt.h:1533:69: warning: cast from 'uint8*' to 'JSContext*' increases required alignment of target type
        In file included from jsbool.cpp:52:0:
        jsnum.h: In function 'int JSDOUBLE_IS_FINITE(jsdouble)':
        jsnum.h:101:20: error: 'finite' was not declared in this scope
        In file included from jsbool.cpp:55:0:
        jsvector.h: In member function 'T* js::Vector<T, MinInlineCapacity, AllocPolicy>::inlineEnd() const [with T = short unsigned int, unsigned int N = 32u, AllocPolicy = js::ContextAllocPolicy]':
        jsvector.h:679:13:   instantiated from 'bool js::Vector<T, MinInlineCapacity, AllocPolicy>::append(const U*, const U*) [with U = char, T = short unsigned int, unsigned int N = 32u, AllocPolicy = js::ContextAllocPolicy]'
        jsvector.h:418:51:   instantiated from 'bool js::js_AppendLiteral(js::Vector<T, N, AP>&, const char (&)[ArrayLength]) [with T = short unsigned int, unsigned int N = 32u, AP = js::ContextAllocPolicy, unsigned int ArrayLength = 5u]'
        jsbool.cpp:169:43:   instantiated from here
        jsvector.h:254:32: warning: cast from 'const char*' to 'short unsigned int*' increases required alignment of target type
        jsvector.h: In member function 'T* js::Vector<T, MinInlineCapacity, AllocPolicy>::inlineBegin() const [with T = short unsigned int, unsigned int N = 32u, AllocPolicy = js::ContextAllocPolicy]':
        jsvector.h:514:5:   instantiated from 'bool js::Vector<T, MinInlineCapacity, AllocPolicy>::convertToHeapStorage(size_t) [with T = short unsigned int, unsigned int N = 32u, AllocPolicy = js::ContextAllocPolicy, size_t = unsigned int]'
        jsvector.h:684:9:   instantiated from 'bool js::Vector<T, MinInlineCapacity, AllocPolicy>::append(const U*, const U*) [with U = char, T = short unsigned int, unsigned int N = 32u, AllocPolicy = js::ContextAllocPolicy]'
        jsvector.h:418:51:   instantiated from 'bool js::js_AppendLiteral(js::Vector<T, N, AP>&, const char (&)[ArrayLength]) [with T = short unsigned int, unsigned int N = 32u, AP = js::ContextAllocPolicy, unsigned int ArrayLength = 5u]'
        jsbool.cpp:169:43:   instantiated from here
        jsvector.h:249:23: warning: cast from 'const char*' to 'short unsigned int*' increases required alignment of target type
        make[4]: *** [jsbool.o] Error 1

Additionally Firefox should probably get updated to newer version, since
I guess the current one in OE suffers from several security issues.


Thanks,

Paul
Patrik Dahlström - April 18, 2011, 1:09 p.m.
lördag 16 april 2011 15.28.39 skrev  Paul Menzel:
> Dear Patrik,
> 
> Am Freitag, den 15.04.2011, 18:42 +0200 schrieb Patrik Dahlström:
> > * autoconf does not fill in any CFLAGS or LIBS for libIDL-2.0. This
> > 
> >   patch sets the appropriate flags in autoconf.mk.in for
> >   HOST_LIBIDL_CFLAGS and HOST_LIBIDL_LIBS.
> > 
> > Signed-off-by: Patrik Dahlström <patda293@student.liu.se>
> > ---
> > 
> >  recipes/mozilla/firefox_3.6.8.bb |    7 +++++--
> >  1 files changed, 5 insertions(+), 2 deletions(-)
> > 
> > diff --git a/recipes/mozilla/firefox_3.6.8.bb
> > b/recipes/mozilla/firefox_3.6.8.bb index 04dde08..828822c 100644
> > --- a/recipes/mozilla/firefox_3.6.8.bb
> > +++ b/recipes/mozilla/firefox_3.6.8.bb
> > @@ -28,6 +28,7 @@ SRC_URI[archive.md5sum] =
> > "0ee5f14fd8be07513d16131027ebcb61"
> > 
> >  SRC_URI[archive.sha256sum] =
> >  "fc609cc6a0ddaa2a9ebd8511ec39ae4a404e1107a12e07b233e2afca51d9a10e"
> >  
> >  S = "${WORKDIR}/mozilla-1.9.2"
> > 
> > +export PKG_CONFIG=${STAGING_BINDIR_NATIVE}/pkg-config
> 
> is that line really needed?
It seems I misspelled something here. It was supposed to say PKG_CONFIG_PATH. 
Apparently it works anyway, but I don't know if it would work for every kind 
of configuration.
However, when I used $PKG_CONFIG instead of $(pkg-config ...) below it didn't 
work. I will try to reproduce the error when I have some time over and be more 
precise on what the actual error was (missing glib.h as I recall).
> 
> >  inherit mozilla
> >  require firefox.inc
> > 
> > @@ -37,7 +38,9 @@ EXTRA_OECONF += " --enable-official-branding
> > --disable-crashreporter"
> > 
> >  FULL_OPTIMIZATION = "-fexpensive-optimizations -fomit-frame-pointer
> >  -frename-registers -O2"
> >  
> >  do_compile_prepend() {
> > 
> > -	cp ${WORKDIR}/jsautocfg.h ${S}/js/src/
> > -	sed -i "s|CPU_ARCH =|CPU_ARCH = ${TARGET_ARCH}|"
> > security/coreconf/Linux.mk +    cp ${WORKDIR}/jsautocfg.h ${S}/js/src/
> > +    sed -i "s|CPU_ARCH =|CPU_ARCH = ${TARGET_ARCH}|"
> > security/coreconf/Linux.mk +    sed -i "s|HOST_LIBIDL_CFLAGS =
> > \@HOST_LIBIDL_CFLAGS\@|HOST_LIBIDL_CFLAGS = $(pkg-config --cflags
> > libIDL-2.0)|" config/autoconf.mk.in +    sed -i "s|HOST_LIBIDL_LIBS   =
> > @HOST_LIBIDL_LIBS@|HOST_LIBIDL_LIBS = $(pkg-config --libs libIDL-2.0)|"
> > config/autoconf.mk.in
> > 
> >  }
> 
> Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>
> 
> Is that bug fixed in newer releases of Firefox?
This was the latest release of firefox in OE. I didn't try to create a new 
recipe for any newer version of FF.
> 
> 
> Thanks,
My pleasure.
> 
> Paul
Patrik Dahlström - April 18, 2011, 1:18 p.m.
fredag 15 april 2011 22.40.59 skrev  Denis 'GNUtoo' Carikli:
> On Fri, 2011-04-15 at 18:42 +0200, Patrik Dahlström wrote:
> > * autoconf does not fill in any CFLAGS or LIBS for libIDL-2.0. This
> > 
> >   patch sets the appropriate flags in autoconf.mk.in for
> >   HOST_LIBIDL_CFLAGS and HOST_LIBIDL_LIBS.
> 
> What error did you get?
> Maybe you could add something like:
>  This patch fixes the following error:
>  [ERROR here]
> To the commit message.
When I have some time over I will look into this. Right now, school takes up 
most of my time.
> 
> By the way, thanks a lot for the fix.
My pleasure.
> 
> Denis.
> 
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Patch

diff --git a/recipes/mozilla/firefox_3.6.8.bb b/recipes/mozilla/firefox_3.6.8.bb
index 04dde08..828822c 100644
--- a/recipes/mozilla/firefox_3.6.8.bb
+++ b/recipes/mozilla/firefox_3.6.8.bb
@@ -28,6 +28,7 @@  SRC_URI[archive.md5sum] = "0ee5f14fd8be07513d16131027ebcb61"
 SRC_URI[archive.sha256sum] = "fc609cc6a0ddaa2a9ebd8511ec39ae4a404e1107a12e07b233e2afca51d9a10e"
 
 S = "${WORKDIR}/mozilla-1.9.2"
+export PKG_CONFIG=${STAGING_BINDIR_NATIVE}/pkg-config
 
 inherit mozilla
 require firefox.inc
@@ -37,7 +38,9 @@  EXTRA_OECONF += " --enable-official-branding --disable-crashreporter"
 FULL_OPTIMIZATION = "-fexpensive-optimizations -fomit-frame-pointer -frename-registers -O2"
 
 do_compile_prepend() {
-	cp ${WORKDIR}/jsautocfg.h ${S}/js/src/
-	sed -i "s|CPU_ARCH =|CPU_ARCH = ${TARGET_ARCH}|" security/coreconf/Linux.mk
+    cp ${WORKDIR}/jsautocfg.h ${S}/js/src/
+    sed -i "s|CPU_ARCH =|CPU_ARCH = ${TARGET_ARCH}|" security/coreconf/Linux.mk
+    sed -i "s|HOST_LIBIDL_CFLAGS = \@HOST_LIBIDL_CFLAGS\@|HOST_LIBIDL_CFLAGS = $(pkg-config --cflags libIDL-2.0)|" config/autoconf.mk.in
+    sed -i "s|HOST_LIBIDL_LIBS   = @HOST_LIBIDL_LIBS@|HOST_LIBIDL_LIBS = $(pkg-config --libs libIDL-2.0)|" config/autoconf.mk.in
 }