Patchwork psplash: Add mising commands module import.

login
register
mail settings
Submitter Peter Tworek
Date March 5, 2012, 10:31 p.m.
Message ID <1330986694-28199-1-git-send-email-tworaz666@gmail.com>
Download mbox | patch
Permalink /patch/22717/
State Accepted
Commit 34bdb9a459208377210454e54635afb9404ee126
Headers show

Comments

Peter Tworek - March 5, 2012, 10:31 p.m.
Python commands module is used in the recipe, but never imported.
This leads to build errors like:

NameError: global name 'commands' is not defined

ERROR: The stack trace of python calls that resulted in this exception/failure was:
ERROR:   File "do_compile", line 24, in <module>
ERROR:
ERROR:   File "do_compile", line 11, in do_compile
ERROR:
ERROR: The code that was being executed was:
ERROR:      0020:        bb.build.exec_func("oe_runmake", d)
ERROR:      0021:        shutil.copyfile("psplash", outputfile)
ERROR:      0022:
ERROR:      0023:
ERROR:  *** 0024:do_compile(d)
ERROR:      0025:
ERROR: (file: 'do_compile', lineno: 24, function: <module>)
ERROR:      0007:    localfiles = d.getVar('SPLASH_LOCALPATHS', True).split()
ERROR:      0008:    outputfiles = d.getVar('SPLASH_INSTALL', True).split()
ERROR:      0009:    for localfile, outputfile in zip(localfiles, outputfiles):
ERROR:      0010:        if localfile.endswith(".png"):
ERROR:  *** 0011:            outp = commands.getstatusoutput('./make-image-header.sh %s POKY' % localfile)
ERROR:      0012:            print(outp[1])
ERROR:      0013:            fbase = os.path.splitext(os.path.basename(localfile))[0]
ERROR:      0014:            shutil.copyfile("%s-img.h" % fbase, destfile)
ERROR:      0015:        else:

Signed-off-by: Peter Tworek <tworaz666@gmail.com>
---
 meta/recipes-core/psplash/psplash_git.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Paul Eggleton - March 5, 2012, 10:48 p.m.
On Monday 05 March 2012 23:31:34 Peter Tworek wrote:
> Python commands module is used in the recipe, but never imported.
> This leads to build errors like:
> 
> NameError: global name 'commands' is not defined
> 
> ERROR: The stack trace of python calls that resulted in this
> exception/failure was: ERROR:   File "do_compile", line 24, in <module>
> ERROR:
> ERROR:   File "do_compile", line 11, in do_compile
> ERROR:
> ERROR: The code that was being executed was:
> ERROR:      0020:        bb.build.exec_func("oe_runmake", d)
> ERROR:      0021:        shutil.copyfile("psplash", outputfile)
> ERROR:      0022:
> ERROR:      0023:
> ERROR:  *** 0024:do_compile(d)
> ERROR:      0025:
> ERROR: (file: 'do_compile', lineno: 24, function: <module>)
> ERROR:      0007:    localfiles = d.getVar('SPLASH_LOCALPATHS',
> True).split() ERROR:      0008:    outputfiles = d.getVar('SPLASH_INSTALL',
> True).split() ERROR:      0009:    for localfile, outputfile in
> zip(localfiles, outputfiles): ERROR:      0010:        if
> localfile.endswith(".png"):
> ERROR:  *** 0011:            outp =
> commands.getstatusoutput('./make-image-header.sh %s POKY' % localfile)
> ERROR:      0012:            print(outp[1])
> ERROR:      0013:            fbase =
> os.path.splitext(os.path.basename(localfile))[0] ERROR:      0014:         
>   shutil.copyfile("%s-img.h" % fbase, destfile) ERROR:      0015:       
> else:
> 
> Signed-off-by: Peter Tworek <tworaz666@gmail.com>
> ---
>  meta/recipes-core/psplash/psplash_git.bb |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-core/psplash/psplash_git.bb
> b/meta/recipes-core/psplash/psplash_git.bb index 42ea615..bd405f9 100644
> --- a/meta/recipes-core/psplash/psplash_git.bb
> +++ b/meta/recipes-core/psplash/psplash_git.bb
> @@ -68,7 +68,7 @@ S = "${WORKDIR}/git"
>  inherit autotools pkgconfig update-rc.d
> 
>  python do_compile () {
> -    import shutil
> +    import shutil, commands
> 
>      # Build a separate executable for each splash image
>      destfile = "%s/psplash-poky-img.h" % d.getVar('S', True)

Acked-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Saul Wold - March 12, 2012, 9:12 p.m.
On 03/05/2012 02:31 PM, Peter Tworek wrote:
> Python commands module is used in the recipe, but never imported.
> This leads to build errors like:
>
> NameError: global name 'commands' is not defined
>
> ERROR: The stack trace of python calls that resulted in this exception/failure was:
> ERROR:   File "do_compile", line 24, in<module>
> ERROR:
> ERROR:   File "do_compile", line 11, in do_compile
> ERROR:
> ERROR: The code that was being executed was:
> ERROR:      0020:        bb.build.exec_func("oe_runmake", d)
> ERROR:      0021:        shutil.copyfile("psplash", outputfile)
> ERROR:      0022:
> ERROR:      0023:
> ERROR:  *** 0024:do_compile(d)
> ERROR:      0025:
> ERROR: (file: 'do_compile', lineno: 24, function:<module>)
> ERROR:      0007:    localfiles = d.getVar('SPLASH_LOCALPATHS', True).split()
> ERROR:      0008:    outputfiles = d.getVar('SPLASH_INSTALL', True).split()
> ERROR:      0009:    for localfile, outputfile in zip(localfiles, outputfiles):
> ERROR:      0010:        if localfile.endswith(".png"):
> ERROR:  *** 0011:            outp = commands.getstatusoutput('./make-image-header.sh %s POKY' % localfile)
> ERROR:      0012:            print(outp[1])
> ERROR:      0013:            fbase = os.path.splitext(os.path.basename(localfile))[0]
> ERROR:      0014:            shutil.copyfile("%s-img.h" % fbase, destfile)
> ERROR:      0015:        else:
>
> Signed-off-by: Peter Tworek<tworaz666@gmail.com>
> ---
>   meta/recipes-core/psplash/psplash_git.bb |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-core/psplash/psplash_git.bb b/meta/recipes-core/psplash/psplash_git.bb
> index 42ea615..bd405f9 100644
> --- a/meta/recipes-core/psplash/psplash_git.bb
> +++ b/meta/recipes-core/psplash/psplash_git.bb
> @@ -68,7 +68,7 @@ S = "${WORKDIR}/git"
>   inherit autotools pkgconfig update-rc.d
>
>   python do_compile () {
> -    import shutil
> +    import shutil, commands
>
>       # Build a separate executable for each splash image
>       destfile = "%s/psplash-poky-img.h" % d.getVar('S', True)
Merged into OE-Core

Thanks 	
	Sau!

Patch

diff --git a/meta/recipes-core/psplash/psplash_git.bb b/meta/recipes-core/psplash/psplash_git.bb
index 42ea615..bd405f9 100644
--- a/meta/recipes-core/psplash/psplash_git.bb
+++ b/meta/recipes-core/psplash/psplash_git.bb
@@ -68,7 +68,7 @@  S = "${WORKDIR}/git"
 inherit autotools pkgconfig update-rc.d
 
 python do_compile () {
-    import shutil
+    import shutil, commands
 
     # Build a separate executable for each splash image
     destfile = "%s/psplash-poky-img.h" % d.getVar('S', True)