| Submitter | Joshua Lock |
|---|---|
| Date | March 3, 2012, 12:39 a.m. |
| Message ID | <cover.1330734444.git.josh@linux.intel.com> |
| Download | mbox |
| Permalink | /patch/22611/ |
| State | New |
| Headers | show |
Pull-request
git://github.com/incandescant/bitbake josh/hobComments
Whoops. Forgot to hit save in my editor before sending... The message should be: The following series addresses some issues I've raised with the Hob implementation. Firstly it introduces two new widgets, a generic PersistentTooltip widget which is an implementation of a tooltip like widget that persists until the user explicitly dismisses it, this matches the Hob interaction design more closely. The second widget is a button-like widget using the info icon from the visual design which, when clicked, will display a persistent tooltip. The series then replaces all known instances of a gtk.Image containing the stock info item plus a standard tooltip with the new HobInfoButton. The final patch, to ensure consistency, special cases the stock info icon in the CrumbsMesssageDialog so that any dialogues which show an info icon will display the custom icon per the visual design. I've attached a few screenshots showing the PersistentTooltip and HobInfoButton's in use. Cheers, Joshua On 02/03/12 16:39, Joshua Lock wrote: > > The following changes since commit 4a480a052f450c4ee061ab0e60a495a45f140cf9: > > stderr would previously be appended to stdout, corrupting the result when something was outputed to stderr but exit code was still 0 (non-fatal warning messages). This commit makes the code parse only stdout, but output stderr if an error happened. (2012-03-02 16:17:43 +0000) > > are available in the git repository at: > git://github.com/incandescant/bitbake josh/hob > https://github.com/incandescant/bitbake/tree/josh/hob > > and as a poky repository at: > git://git.yoctoproject.org/poky-contrib josh/hob > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=josh/hob > > Joshua Lock (6): > crumbs/persistenttooltip: a new Gtk+ widget for use in Hob > ui/icons: crop the info icons > ui/crumbs/hobwidget: implement HobInfoButton per Hob interaction > design > ui/crumbs/imageconfigurationpage: make use of the HobInfoButton > ui/crumbs/hig: use HobInfoButton in place of gtk.Image with tooltip > ui/crumbs/hig: special case stock info icons in CrumbsMesssageDialog > > lib/bb/ui/crumbs/hig.py | 52 +++++------- > lib/bb/ui/crumbs/hobwidget.py | 49 +++++++++++ > lib/bb/ui/crumbs/imageconfigurationpage.py | 12 +-- > lib/bb/ui/crumbs/persistenttooltip.py | 127 ++++++++++++++++++++++++++++ > lib/bb/ui/icons/info/info_display.png | Bin 4760 -> 4558 bytes > lib/bb/ui/icons/info/info_hover.png | Bin 4847 -> 4650 bytes > 6 files changed, 200 insertions(+), 40 deletions(-) > create mode 100644 lib/bb/ui/crumbs/persistenttooltip.py >
Whoops. Forgot to hit save in my editor before sending... The message should be: The following series addresses some issues I've raised with the Hob implementation. Firstly it introduces two new widgets, a generic PersistentTooltip widget which is an implementation of a tooltip like widget that persists until the user explicitly dismisses it, this matches the Hob interaction design more closely. The second widget is a button-like widget using the info icon from the visual design which, when clicked, will display a persistent tooltip. The series then replaces all known instances of a gtk.Image containing the stock info item plus a standard tooltip with the new HobInfoButton. The final patch, to ensure consistency, special cases the stock info icon in the CrumbsMesssageDialog so that any dialogues which show an info icon will display the custom icon per the visual design. Cheers, Joshua Note: this is attempt two at sending this follow on, attempt one is stuck awaiting moderation as I tried to include screenshots.... On 02/03/12 16:39, Joshua Lock wrote: > asldlasjd > > The following changes since commit 4a480a052f450c4ee061ab0e60a495a45f140cf9: > > stderr would previously be appended to stdout, corrupting the result when something was outputed to stderr but exit code was still 0 (non-fatal warning messages). This commit makes the code parse only stdout, but output stderr if an error happened. (2012-03-02 16:17:43 +0000) > > are available in the git repository at: > git://github.com/incandescant/bitbake josh/hob > https://github.com/incandescant/bitbake/tree/josh/hob > > and as a poky repository at: > git://git.yoctoproject.org/poky-contrib josh/hob > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=josh/hob > > Joshua Lock (6): > crumbs/persistenttooltip: a new Gtk+ widget for use in Hob > ui/icons: crop the info icons > ui/crumbs/hobwidget: implement HobInfoButton per Hob interaction > design > ui/crumbs/imageconfigurationpage: make use of the HobInfoButton > ui/crumbs/hig: use HobInfoButton in place of gtk.Image with tooltip > ui/crumbs/hig: special case stock info icons in CrumbsMesssageDialog > > lib/bb/ui/crumbs/hig.py | 52 +++++------- > lib/bb/ui/crumbs/hobwidget.py | 49 +++++++++++ > lib/bb/ui/crumbs/imageconfigurationpage.py | 12 +-- > lib/bb/ui/crumbs/persistenttooltip.py | 127 ++++++++++++++++++++++++++++ > lib/bb/ui/icons/info/info_display.png | Bin 4760 -> 4558 bytes > lib/bb/ui/icons/info/info_hover.png | Bin 4847 -> 4650 bytes > 6 files changed, 200 insertions(+), 40 deletions(-) > create mode 100644 lib/bb/ui/crumbs/persistenttooltip.py >
On Fri, 2012-03-02 at 16:39 -0800, Joshua Lock wrote: > asldlasjd > > The following changes since commit 4a480a052f450c4ee061ab0e60a495a45f140cf9: > > stderr would previously be appended to stdout, corrupting the result when something was outputed to stderr but exit code was still 0 (non-fatal warning messages). This commit makes the code parse only stdout, but output stderr if an error happened. (2012-03-02 16:17:43 +0000) > > are available in the git repository at: > git://github.com/incandescant/bitbake josh/hob > https://github.com/incandescant/bitbake/tree/josh/hob > > and as a poky repository at: > git://git.yoctoproject.org/poky-contrib josh/hob > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=josh/hob > > Joshua Lock (6): > crumbs/persistenttooltip: a new Gtk+ widget for use in Hob > ui/icons: crop the info icons > ui/crumbs/hobwidget: implement HobInfoButton per Hob interaction > design > ui/crumbs/imageconfigurationpage: make use of the HobInfoButton > ui/crumbs/hig: use HobInfoButton in place of gtk.Image with tooltip > ui/crumbs/hig: special case stock info icons in CrumbsMesssageDialog Merged to master, thanks. Richard
Joshua Lock wrote on 2012-03-03: > Whoops. Forgot to hit save in my editor before sending... The message > should be: > > The following series addresses some issues I've raised with the Hob > implementation. Firstly it introduces two new widgets, a generic > PersistentTooltip widget which is an implementation of a tooltip like > widget that persists until the user explicitly dismisses it, this > matches the Hob interaction design more closely. The second widget is a > button-like widget using the info icon from the visual design which, > when clicked, will display a persistent tooltip. > > The series then replaces all known instances of a gtk.Image containing > the stock info item plus a standard tooltip with the new HobInfoButton. > > The final patch, to ensure consistency, special cases the stock info > icon in the CrumbsMesssageDialog so that any dialogues which show an > info icon will display the custom icon per the visual design. > > I've attached a few screenshots showing the PersistentTooltip and > HobInfoButton's in use. > > Cheers, > Joshua Josh, I am using Ubuntu system, the color of your tooltips is gray and the background of a window is black. I found it is difficult for me to see the words. I am wondering whether that is what you want, and whether we can make them white. -- Shane
Joshua Lock wrote on 2012-03-03: > Whoops. Forgot to hit save in my editor before sending... The message > should be: > > The following series addresses some issues I've raised with the Hob > implementation. Firstly it introduces two new widgets, a generic > PersistentTooltip widget which is an implementation of a tooltip like > widget that persists until the user explicitly dismisses it, this > matches the Hob interaction design more closely. The second widget is a > button-like widget using the info icon from the visual design which, > when clicked, will display a persistent tooltip. > > The series then replaces all known instances of a gtk.Image containing > the stock info item plus a standard tooltip with the new HobInfoButton. > > The final patch, to ensure consistency, special cases the stock info > icon in the CrumbsMesssageDialog so that any dialogues which show an > info icon will display the custom icon per the visual design. > > I've attached a few screenshots showing the PersistentTooltip and > HobInfoButton's in use. > > Cheers, > Joshua Josh, I am using Ubuntu system, the color of your tooltips is gray and the background of a window is black. I found it is difficult for me to see the words. I am wondering whether that is what you want, and whether we can make them white. -- Shane
On 15/03/12 23:41, Wang, Shane wrote: > > Joshua Lock wrote on 2012-03-03: > >> Whoops. Forgot to hit save in my editor before sending... The message >> should be: >> >> The following series addresses some issues I've raised with the Hob >> implementation. Firstly it introduces two new widgets, a generic >> PersistentTooltip widget which is an implementation of a tooltip like >> widget that persists until the user explicitly dismisses it, this >> matches the Hob interaction design more closely. The second widget is a >> button-like widget using the info icon from the visual design which, >> when clicked, will display a persistent tooltip. >> >> The series then replaces all known instances of a gtk.Image containing >> the stock info item plus a standard tooltip with the new HobInfoButton. >> >> The final patch, to ensure consistency, special cases the stock info >> icon in the CrumbsMesssageDialog so that any dialogues which show an >> info icon will display the custom icon per the visual design. >> >> I've attached a few screenshots showing the PersistentTooltip and >> HobInfoButton's in use. >> >> Cheers, >> Joshua > > Josh, I am using Ubuntu system, the color of your tooltips is gray and the background of a window is black. > I found it is difficult for me to see the words. > I am wondering whether that is what you want, and whether we can make them white. Hi Shane, This isn't intended - I discovered this bug via proxy recently: https://bugzilla.yoctoproject.org/show_bug.cgi?id=2128 I'm working to make the tooltips more readable when using Ubuntu with Unity. Cheers, Joshua
asldlasjd The following changes since commit 4a480a052f450c4ee061ab0e60a495a45f140cf9: stderr would previously be appended to stdout, corrupting the result when something was outputed to stderr but exit code was still 0 (non-fatal warning messages). This commit makes the code parse only stdout, but output stderr if an error happened. (2012-03-02 16:17:43 +0000) are available in the git repository at: git://github.com/incandescant/bitbake josh/hob https://github.com/incandescant/bitbake/tree/josh/hob and as a poky repository at: git://git.yoctoproject.org/poky-contrib josh/hob http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=josh/hob Joshua Lock (6): crumbs/persistenttooltip: a new Gtk+ widget for use in Hob ui/icons: crop the info icons ui/crumbs/hobwidget: implement HobInfoButton per Hob interaction design ui/crumbs/imageconfigurationpage: make use of the HobInfoButton ui/crumbs/hig: use HobInfoButton in place of gtk.Image with tooltip ui/crumbs/hig: special case stock info icons in CrumbsMesssageDialog lib/bb/ui/crumbs/hig.py | 52 +++++------- lib/bb/ui/crumbs/hobwidget.py | 49 +++++++++++ lib/bb/ui/crumbs/imageconfigurationpage.py | 12 +-- lib/bb/ui/crumbs/persistenttooltip.py | 127 ++++++++++++++++++++++++++++ lib/bb/ui/icons/info/info_display.png | Bin 4760 -> 4558 bytes lib/bb/ui/icons/info/info_hover.png | Bin 4847 -> 4650 bytes 6 files changed, 200 insertions(+), 40 deletions(-) create mode 100644 lib/bb/ui/crumbs/persistenttooltip.py