Patchwork [bitbake-devel,6/6] ui/crumbs/hig: special case stock info icons in CrumbsMesssageDialog

login
register
mail settings
Submitter Joshua Lock
Date March 3, 2012, 12:39 a.m.
Message ID <0aa653ca441811e220bbf70de4eb32781e41c9c5.1330734444.git.josh@linux.intel.com>
Download mbox | patch
Permalink /patch/22601/
State Accepted
Commit 37ed1589a19ffc82e8638b5375c99158988b38fc
Headers show

Comments

Joshua Lock - March 3, 2012, 12:39 a.m.
The Hob visual design includes an info icon which should be used
consistently throught the GUI. This change detects use of the stock info
icon in CrumbsMessageDialog and uses the Hob info icon instead.

Signed-off-by: Joshua Lock <josh@linux.intel.com>
---
 lib/bb/ui/crumbs/hig.py |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
Shane Wang - March 5, 2012, 10:39 p.m.
Joshua Lock wrote onĀ 2012-03-02:

> The Hob visual design includes an info icon which should be used
> consistently throught the GUI. This change detects use of the stock info
> icon in CrumbsMessageDialog and uses the Hob info icon instead.
> 
> Signed-off-by: Joshua Lock <josh@linux.intel.com>

ACK

--
Shane

Patch

diff --git a/lib/bb/ui/crumbs/hig.py b/lib/bb/ui/crumbs/hig.py
index b109c0a..e175a2a 100644
--- a/lib/bb/ui/crumbs/hig.py
+++ b/lib/bb/ui/crumbs/hig.py
@@ -74,7 +74,11 @@  class CrumbsMessageDialog(CrumbsDialog):
         self.vbox.add(first_row)
 
         self.icon = gtk.Image()
-        self.icon.set_from_stock(icon, gtk.ICON_SIZE_DIALOG)
+        # We have our own Info icon which should be used in preference of the stock icon
+        if icon == gtk.STOCK_INFO or icon == "gtk-dialog-info":
+            self.icon.set_from_file(hic.ICON_INFO_DISPLAY_FILE)
+        else:
+            self.icon.set_from_stock(icon, gtk.ICON_SIZE_DIALOG)
         self.icon.set_property("yalign", 0.00)
         self.icon.show()
         first_row.add(self.icon)