Patchwork gcc-cross.inc: Fix cross testing scripts to work with dash

login
register
mail settings
Submitter Khem Raj
Date March 2, 2012, 10:54 p.m.
Message ID <1330728865-21682-1-git-send-email-raj.khem@gmail.com>
Download mbox | patch
Permalink /patch/22595/
State Accepted
Commit 1d262630853e65be9167d904b934b581acf64182
Headers show

Comments

Khem Raj - March 2, 2012, 10:54 p.m.
dash does not like >& so be explicit and say 2>&1

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-devtools/gcc/gcc-cross.inc |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Richard Purdie - March 4, 2012, 4:27 a.m.
On Fri, 2012-03-02 at 14:54 -0800, Khem Raj wrote:
> dash does not like >& so be explicit and say 2>&1
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-devtools/gcc/gcc-cross.inc |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Merged to master, thanks.

Richard

Patch

diff --git a/meta/recipes-devtools/gcc/gcc-cross.inc b/meta/recipes-devtools/gcc/gcc-cross.inc
index b16c57d..e7a5e41 100644
--- a/meta/recipes-devtools/gcc/gcc-cross.inc
+++ b/meta/recipes-devtools/gcc/gcc-cross.inc
@@ -65,7 +65,7 @@  then
 	exit 1;
 fi
 
-echo "\$target" | grep "@" >& /dev/null
+echo "\$target" | grep "@" 2>&1 > /dev/null
 if [ "x\$?" = "x0" ]
 then
    user=\$(echo \$target | cut -d '@' -f 1)
@@ -73,7 +73,7 @@  then
 else
    user=\$USER
 fi
-ssh \$user@\$target date >& /dev/null
+ssh \$user@\$target date 2>&1 > /dev/null
 if [ "x\$?" != "x0" ]
 then
 	echo "Failed connecting to \$user@\$target it could be because"