| Submitter | Robert Yang |
|---|---|
| Date | March 2, 2012, 10:15 a.m. |
| Message ID | <4F509DDF.3040103@windriver.com> |
| Download | mbox |
| Permalink | /patch/22577/ |
| State | New |
| Headers | show |
Pull-request
git://git.pokylinux.org/poky-contrib robert/libpamComments
Op 2 mrt. 2012, om 11:15 heeft Robert Yang het volgende geschreven: > > > On 03/02/2012 04:42 PM, Koen Kooi wrote: >> >> Op 2 mrt. 2012, om 08:02 heeft Robert Yang het volgende geschreven: >> >>> The libpam's has an error when generating the rootfs: >>> >>> chmod: cannot access `/usr/sbin/unix_chkpwd': No such file or directory >>> >>> This is because the following code in libpam_1.1.5.bb: >>> >>> pkg_postinst_pam-plugin-unix () { >>> # below is necessary to allow unix_chkpwd get user info from shadow file >>> # on lsb images >>> chmod 4755 ${sbindir}/unix_chkpwd >>> } >>> >>> This is to set the setuid permission for unix_chkpwd (the lsb test >>> requires this), but it lacks a "${D}", and we can do this in the install >>> stage. >>> >>> [YOCTO #2049] >>> >>> Signed-off-by: Robert Yang<liezhi.yang@windriver.com> >>> --- >>> meta/recipes-extended/pam/libpam_1.1.5.bb | 7 ++----- >>> 1 files changed, 2 insertions(+), 5 deletions(-) >>> >>> diff --git a/meta/recipes-extended/pam/libpam_1.1.5.bb b/meta/recipes-extended/pam/libpam_1.1.5.bb >>> index 283f477..8cddca9 100644 >>> --- a/meta/recipes-extended/pam/libpam_1.1.5.bb >>> +++ b/meta/recipes-extended/pam/libpam_1.1.5.bb >>> @@ -85,10 +85,7 @@ do_install() { >>> >>> install -d ${D}${sysconfdir}/pam.d/ >>> install -m 0644 ${WORKDIR}/pam.d/* ${D}${sysconfdir}/pam.d/ >>> -} >>> >>> -pkg_postinst_pam-plugin-unix () { >>> - # below is necessary to allow unix_chkpwd get user info from shadow file >>> - # on lsb images >>> - chmod 4755 ${sbindir}/unix_chkpwd >>> + # The lsb requires unix_chkpwd has setuid permission >>> + chmod 4755 ${D}${sbindir}/unix_chkpwd >> >> MIssing PR bump >> > > Thanks for your reply, but I'm sorry I don't what did you mean, I guess you mean > the Pull Request, it is in the cover letter: No, I meant: you change the output package, so you need to increase PR
On 03/02/2012 06:17 PM, Koen Kooi wrote: > > Op 2 mrt. 2012, om 11:15 heeft Robert Yang het volgende geschreven: > >> >> >> On 03/02/2012 04:42 PM, Koen Kooi wrote: >>> >>> Op 2 mrt. 2012, om 08:02 heeft Robert Yang het volgende geschreven: >>> >>>> The libpam's has an error when generating the rootfs: >>>> >>>> chmod: cannot access `/usr/sbin/unix_chkpwd': No such file or directory >>>> >>>> This is because the following code in libpam_1.1.5.bb: >>>> >>>> pkg_postinst_pam-plugin-unix () { >>>> # below is necessary to allow unix_chkpwd get user info from shadow file >>>> # on lsb images >>>> chmod 4755 ${sbindir}/unix_chkpwd >>>> } >>>> >>>> This is to set the setuid permission for unix_chkpwd (the lsb test >>>> requires this), but it lacks a "${D}", and we can do this in the install >>>> stage. >>>> >>>> [YOCTO #2049] >>>> >>>> Signed-off-by: Robert Yang<liezhi.yang@windriver.com> >>>> --- >>>> meta/recipes-extended/pam/libpam_1.1.5.bb | 7 ++----- >>>> 1 files changed, 2 insertions(+), 5 deletions(-) >>>> >>>> diff --git a/meta/recipes-extended/pam/libpam_1.1.5.bb b/meta/recipes-extended/pam/libpam_1.1.5.bb >>>> index 283f477..8cddca9 100644 >>>> --- a/meta/recipes-extended/pam/libpam_1.1.5.bb >>>> +++ b/meta/recipes-extended/pam/libpam_1.1.5.bb >>>> @@ -85,10 +85,7 @@ do_install() { >>>> >>>> install -d ${D}${sysconfdir}/pam.d/ >>>> install -m 0644 ${WORKDIR}/pam.d/* ${D}${sysconfdir}/pam.d/ >>>> -} >>>> >>>> -pkg_postinst_pam-plugin-unix () { >>>> - # below is necessary to allow unix_chkpwd get user info from shadow file >>>> - # on lsb images >>>> - chmod 4755 ${sbindir}/unix_chkpwd >>>> + # The lsb requires unix_chkpwd has setuid permission >>>> + chmod 4755 ${D}${sbindir}/unix_chkpwd >>> >>> MIssing PR bump >>> >> >> Thanks for your reply, but I'm sorry I don't what did you mean, I guess you mean >> the Pull Request, it is in the cover letter: > > No, I meant: you change the output package, so you need to increase PR Would you please give me more explanations? I'm sorry I don't know what does this mean:-). // Robert > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >
On 03/02/2012 06:17 PM, Koen Kooi wrote: > > Op 2 mrt. 2012, om 11:15 heeft Robert Yang het volgende geschreven: > >> >> >> On 03/02/2012 04:42 PM, Koen Kooi wrote: >>> >>> Op 2 mrt. 2012, om 08:02 heeft Robert Yang het volgende geschreven: >>> >>>> The libpam's has an error when generating the rootfs: >>>> >>>> chmod: cannot access `/usr/sbin/unix_chkpwd': No such file or directory >>>> >>>> This is because the following code in libpam_1.1.5.bb: >>>> >>>> pkg_postinst_pam-plugin-unix () { >>>> # below is necessary to allow unix_chkpwd get user info from shadow file >>>> # on lsb images >>>> chmod 4755 ${sbindir}/unix_chkpwd >>>> } >>>> >>>> This is to set the setuid permission for unix_chkpwd (the lsb test >>>> requires this), but it lacks a "${D}", and we can do this in the install >>>> stage. >>>> >>>> [YOCTO #2049] >>>> >>>> Signed-off-by: Robert Yang<liezhi.yang@windriver.com> >>>> --- >>>> meta/recipes-extended/pam/libpam_1.1.5.bb | 7 ++----- >>>> 1 files changed, 2 insertions(+), 5 deletions(-) >>>> >>>> diff --git a/meta/recipes-extended/pam/libpam_1.1.5.bb b/meta/recipes-extended/pam/libpam_1.1.5.bb >>>> index 283f477..8cddca9 100644 >>>> --- a/meta/recipes-extended/pam/libpam_1.1.5.bb >>>> +++ b/meta/recipes-extended/pam/libpam_1.1.5.bb >>>> @@ -85,10 +85,7 @@ do_install() { >>>> >>>> install -d ${D}${sysconfdir}/pam.d/ >>>> install -m 0644 ${WORKDIR}/pam.d/* ${D}${sysconfdir}/pam.d/ >>>> -} >>>> >>>> -pkg_postinst_pam-plugin-unix () { >>>> - # below is necessary to allow unix_chkpwd get user info from shadow file >>>> - # on lsb images >>>> - chmod 4755 ${sbindir}/unix_chkpwd >>>> + # The lsb requires unix_chkpwd has setuid permission >>>> + chmod 4755 ${D}${sbindir}/unix_chkpwd >>> >>> MIssing PR bump >>> >> >> Thanks for your reply, but I'm sorry I don't what did you mean, I guess you mean >> the Pull Request, it is in the cover letter: > > No, I meant: you change the output package, so you need to increase PR Ah, got it, the PR field, I will send a V2. // Robert > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >