Patchwork streamripper: fix depends and license

login
register
mail settings
Submitter Andreas Oberritter
Date April 14, 2011, 11:24 p.m.
Message ID <1302823477-10855-1-git-send-email-obi@opendreambox.org>
Download mbox | patch
Permalink /patch/2253/
State Accepted
Commit 156d0bcaeacdffb8e8e6de3a98d8309a4ff1304a
Headers show

Comments

Andreas Oberritter - April 14, 2011, 11:24 p.m.
- Prefer the shared libmad over the one included in streamripper.
- glib-2.0 is required to build streamripper.
- libfaad2 will get picked up if built before streamripper. Make
  builds consistent.
- No need to set RDEPENDS_${PN} (already set by shlibdeps).

Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
---
 recipes/streamripper/streamripper_1.64.6.bb |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
Frans Meulenbroeks - April 15, 2011, 6 a.m.
2011/4/15 Andreas Oberritter <obi@opendreambox.org>:
> - Prefer the shared libmad over the one included in streamripper.
> - glib-2.0 is required to build streamripper.
> - libfaad2 will get picked up if built before streamripper. Make
>  builds consistent.
> - No need to set RDEPENDS_${PN} (already set by shlibdeps).
>
> Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
Acked-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
> ---
>  recipes/streamripper/streamripper_1.64.6.bb |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/recipes/streamripper/streamripper_1.64.6.bb b/recipes/streamripper/streamripper_1.64.6.bb
> index 342d92e..39fae01 100644
> --- a/recipes/streamripper/streamripper_1.64.6.bb
> +++ b/recipes/streamripper/streamripper_1.64.6.bb
> @@ -1,8 +1,8 @@
>  DESCRIPTION = "StreamRipper lets you record streaming mp3 to your hard drive."
>  SECTION = "console/multimedia"
> -LICENSE = "GPL"
> -DEPENDS = "libogg libvorbis"
> -RDEPENDS_${PN} = "libogg libvorbis"
> +LICENSE = "GPLv2+"
> +DEPENDS = "faad2 glib-2.0 libmad libogg libvorbis"
> +PR = "r1"
>
>  SRC_URI = "${SOURCEFORGE_MIRROR}/streamripper/streamripper-${PV}.tar.gz;name=src"
>  SRC_URI[src.md5sum] = "a37a1a8b8f9228522196a122a1c2dd32"
> --
> 1.7.2.5
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Patch

diff --git a/recipes/streamripper/streamripper_1.64.6.bb b/recipes/streamripper/streamripper_1.64.6.bb
index 342d92e..39fae01 100644
--- a/recipes/streamripper/streamripper_1.64.6.bb
+++ b/recipes/streamripper/streamripper_1.64.6.bb
@@ -1,8 +1,8 @@ 
 DESCRIPTION = "StreamRipper lets you record streaming mp3 to your hard drive."
 SECTION = "console/multimedia"
-LICENSE = "GPL"
-DEPENDS = "libogg libvorbis"
-RDEPENDS_${PN} = "libogg libvorbis"
+LICENSE = "GPLv2+"
+DEPENDS = "faad2 glib-2.0 libmad libogg libvorbis"
+PR = "r1"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/streamripper/streamripper-${PV}.tar.gz;name=src"
 SRC_URI[src.md5sum] = "a37a1a8b8f9228522196a122a1c2dd32"