| Message ID | 20230411131518.401912-4-brgl@bgdev.pl |
|---|---|
| State | Under Review |
| Headers | show |
| Series | [meta-oe,1/4] libgpiod: enable all features for ptest | expand |
On 2023-04-11 09:15, Bartosz Golaszewski via lists.openembedded.org wrote: > From: Bartosz Golaszewski<bartosz.golaszewski@linaro.org> > > This is a bug-fix release addressing bugs discovered since the release > of v2.0. Should we drop the old recipe? ❯ fd libgpiod meta-oe/recipes-support/libgpiod meta-oe/recipes-support/libgpiod/libgpiod-1.x meta-oe/recipes-support/libgpiod/libgpiod-2.x meta-oe/recipes-support/libgpiod/libgpiod-src.inc meta-oe/recipes-support/libgpiod/libgpiod.inc meta-oe/recipes-support/libgpiod/libgpiod_1.6.4.bb meta-oe/recipes-support/libgpiod/libgpiod_2.0.1.bb I think that v2 was added when it was a release candidate: https://git.openembedded.org/meta-openembedded/log/?qt=grep&q=libgpiod ../Randy > > Signed-off-by: Bartosz Golaszewski<bartosz.golaszewski@linaro.org> > --- > .../libgpiod/{libgpiod_2.0.bb => libgpiod_2.0.1.bb} | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > rename meta-oe/recipes-support/libgpiod/{libgpiod_2.0.bb => libgpiod_2.0.1.bb} (90%) > > diff --git a/meta-oe/recipes-support/libgpiod/libgpiod_2.0.bb b/meta-oe/recipes-support/libgpiod/libgpiod_2.0.1.bb > similarity index 90% > rename from meta-oe/recipes-support/libgpiod/libgpiod_2.0.bb > rename to meta-oe/recipes-support/libgpiod/libgpiod_2.0.1.bb > index bdfd72f2e..50b9203a7 100644 > --- a/meta-oe/recipes-support/libgpiod/libgpiod_2.0.bb > +++ b/meta-oe/recipes-support/libgpiod/libgpiod_2.0.1.bb > @@ -9,7 +9,7 @@ LIC_FILES_CHKSUM = " \ > > FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}-2.x:" > > -SRC_URI[sha256sum] = "f74cbf82038b3cb98ebeb25bce55ee2553be28194002d2a9889b9268cce2dd07" > +SRC_URI[sha256sum] = "b5367d28d045b36007a4ffd42cceda4c358737ef4f2ce22b0c1d05ec57a38392" > > # Enable all project features for ptest > PACKAGECONFIG[tests] = "--enable-tests --enable-tools --enable-bindings-cxx --enable-gpioset-interactive,--disable-tests,kmod util-linux glib-2.0 catch2 libedit" > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#102057):https://lists.openembedded.org/g/openembedded-devel/message/102057 > Mute This Topic:https://lists.openembedded.org/mt/98196930/3616765 > Group Owner:openembedded-devel+owner@lists.openembedded.org > Unsubscribe:https://lists.openembedded.org/g/openembedded-devel/unsub [randy.macleod@windriver.com] > -=-=-=-=-=-=-=-=-=-=-=- >
still seeing these errors https://autobuilder.yoctoproject.org/typhoon/#/builders/88/builds/2659/steps/14/logs/stdio On Tue, Apr 11, 2023 at 6:15 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > This is a bug-fix release addressing bugs discovered since the release > of v2.0. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > --- > .../libgpiod/{libgpiod_2.0.bb => libgpiod_2.0.1.bb} | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > rename meta-oe/recipes-support/libgpiod/{libgpiod_2.0.bb => libgpiod_2.0.1.bb} (90%) > > diff --git a/meta-oe/recipes-support/libgpiod/libgpiod_2.0.bb b/meta-oe/recipes-support/libgpiod/libgpiod_2.0.1.bb > similarity index 90% > rename from meta-oe/recipes-support/libgpiod/libgpiod_2.0.bb > rename to meta-oe/recipes-support/libgpiod/libgpiod_2.0.1.bb > index bdfd72f2e..50b9203a7 100644 > --- a/meta-oe/recipes-support/libgpiod/libgpiod_2.0.bb > +++ b/meta-oe/recipes-support/libgpiod/libgpiod_2.0.1.bb > @@ -9,7 +9,7 @@ LIC_FILES_CHKSUM = " \ > > FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}-2.x:" > > -SRC_URI[sha256sum] = "f74cbf82038b3cb98ebeb25bce55ee2553be28194002d2a9889b9268cce2dd07" > +SRC_URI[sha256sum] = "b5367d28d045b36007a4ffd42cceda4c358737ef4f2ce22b0c1d05ec57a38392" > > # Enable all project features for ptest > PACKAGECONFIG[tests] = "--enable-tests --enable-tools --enable-bindings-cxx --enable-gpioset-interactive,--disable-tests,kmod util-linux glib-2.0 catch2 libedit" > -- > 2.37.2 >
On Fri, Apr 14, 2023 at 3:19 AM Khem Raj <raj.khem@gmail.com> wrote: > > still seeing these errors > > https://autobuilder.yoctoproject.org/typhoon/#/builders/88/builds/2659/steps/14/logs/stdio > Seems like this is from python3-gpiod. Can I see the recipe logs somewhere? Bart
https://errors.yoctoproject.org/Errors/Details/699672/ On Thu, Apr 13, 2023 at 11:21 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > On Fri, Apr 14, 2023 at 3:19 AM Khem Raj <raj.khem@gmail.com> wrote: > > > > still seeing these errors > > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/88/builds/2659/steps/14/logs/stdio > > > > Seems like this is from python3-gpiod. Can I see the recipe logs somewhere? > > Bart
On Thu, Apr 13, 2023 at 11:19 PM Randy MacLeod <randy.macleod@windriver.com> wrote: > > > On 2023-04-11 09:15, Bartosz Golaszewski via lists.openembedded.org wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > This is a bug-fix release addressing bugs discovered since the release > of v2.0. > > Should we drop the old recipe? > > ❯ fd libgpiod > meta-oe/recipes-support/libgpiod > meta-oe/recipes-support/libgpiod/libgpiod-1.x > meta-oe/recipes-support/libgpiod/libgpiod-2.x > meta-oe/recipes-support/libgpiod/libgpiod-src.inc > meta-oe/recipes-support/libgpiod/libgpiod.inc > meta-oe/recipes-support/libgpiod/libgpiod_1.6.4.bb > meta-oe/recipes-support/libgpiod/libgpiod_2.0.1.bb > > I think that v2 was added when it was a release candidate: > > https://git.openembedded.org/meta-openembedded/log/?qt=grep&q=libgpiod > > ../Randy > > No! v1.6.x is the old major release that's still widely used and I still maintain it. Bart > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > --- > .../libgpiod/{libgpiod_2.0.bb => libgpiod_2.0.1.bb} | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > rename meta-oe/recipes-support/libgpiod/{libgpiod_2.0.bb => libgpiod_2.0.1.bb} (90%) > > diff --git a/meta-oe/recipes-support/libgpiod/libgpiod_2.0.bb b/meta-oe/recipes-support/libgpiod/libgpiod_2.0.1.bb > similarity index 90% > rename from meta-oe/recipes-support/libgpiod/libgpiod_2.0.bb > rename to meta-oe/recipes-support/libgpiod/libgpiod_2.0.1.bb > index bdfd72f2e..50b9203a7 100644 > --- a/meta-oe/recipes-support/libgpiod/libgpiod_2.0.bb > +++ b/meta-oe/recipes-support/libgpiod/libgpiod_2.0.1.bb > @@ -9,7 +9,7 @@ LIC_FILES_CHKSUM = " \ > > FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}-2.x:" > > -SRC_URI[sha256sum] = "f74cbf82038b3cb98ebeb25bce55ee2553be28194002d2a9889b9268cce2dd07" > +SRC_URI[sha256sum] = "b5367d28d045b36007a4ffd42cceda4c358737ef4f2ce22b0c1d05ec57a38392" > > # Enable all project features for ptest > PACKAGECONFIG[tests] = "--enable-tests --enable-tools --enable-bindings-cxx --enable-gpioset-interactive,--disable-tests,kmod util-linux glib-2.0 catch2 libedit" > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#102057): https://lists.openembedded.org/g/openembedded-devel/message/102057 > Mute This Topic: https://lists.openembedded.org/mt/98196930/3616765 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [randy.macleod@windriver.com] > -=-=-=-=-=-=-=-=-=-=-=- > > > -- > # Randy MacLeod > # Wind River Linux
On Fri, Apr 14, 2023 at 9:28 AM Khem Raj <raj.khem@gmail.com> wrote: > > https://errors.yoctoproject.org/Errors/Details/699672/ > Ah, I need to remember to always test with clang... This looks like a different bug than the one spotted in libgpiod v2.0-rc1, it appeared now after switching to python3-build based build. I'll take a look. Bart > On Thu, Apr 13, 2023 at 11:21 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > > > On Fri, Apr 14, 2023 at 3:19 AM Khem Raj <raj.khem@gmail.com> wrote: > > > > > > still seeing these errors > > > > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/88/builds/2659/steps/14/logs/stdio > > > > > > > Seems like this is from python3-gpiod. Can I see the recipe logs somewhere? > > > > Bart
On Fri, Apr 14, 2023 at 12:38 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > On Fri, Apr 14, 2023 at 9:28 AM Khem Raj <raj.khem@gmail.com> wrote: > > > > https://errors.yoctoproject.org/Errors/Details/699672/ > > > > Ah, I need to remember to always test with clang... > Not clang particularly, but with ptest enabled distro feature the recipe has deleted PTEST_CFLAGS = "${@bb.utils.contains("PTEST_ENABLED", "1", "-I../../tests/gpiosim", "", d)}" but its still referenced. > This looks like a different bug than the one spotted in libgpiod > v2.0-rc1, it appeared now after switching to python3-build based > build. > > I'll take a look. > > Bart > > > On Thu, Apr 13, 2023 at 11:21 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > > > > > On Fri, Apr 14, 2023 at 3:19 AM Khem Raj <raj.khem@gmail.com> wrote: > > > > > > > > still seeing these errors > > > > > > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/88/builds/2659/steps/14/logs/stdio > > > > > > > > > > Seems like this is from python3-gpiod. Can I see the recipe logs somewhere? > > > > > > Bart
On Fri, Apr 14, 2023 at 9:42 AM Khem Raj <raj.khem@gmail.com> wrote: > > On Fri, Apr 14, 2023 at 12:38 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > > > On Fri, Apr 14, 2023 at 9:28 AM Khem Raj <raj.khem@gmail.com> wrote: > > > > > > https://errors.yoctoproject.org/Errors/Details/699672/ > > > > > > > Ah, I need to remember to always test with clang... > > > > Not clang particularly, but with ptest enabled distro feature > the recipe has deleted > > PTEST_CFLAGS = "${@bb.utils.contains("PTEST_ENABLED", "1", > "-I../../tests/gpiosim", "", d)}" > > but its still referenced. > Hmm, why did it build for me then? Maybe I need a clean rebuild. The gpiosim.h header is not installed in /usr/include by libgpiod, which may be the problem. The shared library on the other hand should be provided by libgpiod at build-time. I'm on it, will send a fixed series as soon as I have something. Bart > > > This looks like a different bug than the one spotted in libgpiod > > v2.0-rc1, it appeared now after switching to python3-build based > > build. > > > > I'll take a look. > > > > Bart > > > > > On Thu, Apr 13, 2023 at 11:21 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > > > > > > > On Fri, Apr 14, 2023 at 3:19 AM Khem Raj <raj.khem@gmail.com> wrote: > > > > > > > > > > still seeing these errors > > > > > > > > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/88/builds/2659/steps/14/logs/stdio > > > > > > > > > > > > > Seems like this is from python3-gpiod. Can I see the recipe logs somewhere? > > > > > > > > Bart
diff --git a/meta-oe/recipes-support/libgpiod/libgpiod_2.0.bb b/meta-oe/recipes-support/libgpiod/libgpiod_2.0.1.bb similarity index 90% rename from meta-oe/recipes-support/libgpiod/libgpiod_2.0.bb rename to meta-oe/recipes-support/libgpiod/libgpiod_2.0.1.bb index bdfd72f2e..50b9203a7 100644 --- a/meta-oe/recipes-support/libgpiod/libgpiod_2.0.bb +++ b/meta-oe/recipes-support/libgpiod/libgpiod_2.0.1.bb @@ -9,7 +9,7 @@ LIC_FILES_CHKSUM = " \ FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}-2.x:" -SRC_URI[sha256sum] = "f74cbf82038b3cb98ebeb25bce55ee2553be28194002d2a9889b9268cce2dd07" +SRC_URI[sha256sum] = "b5367d28d045b36007a4ffd42cceda4c358737ef4f2ce22b0c1d05ec57a38392" # Enable all project features for ptest PACKAGECONFIG[tests] = "--enable-tests --enable-tools --enable-bindings-cxx --enable-gpioset-interactive,--disable-tests,kmod util-linux glib-2.0 catch2 libedit"