Patchwork [bitbake-devel,00/32] Hob related fixes

login
register
mail settings
Submitter Shane Wang
Date Feb. 29, 2012, 2:11 p.m.
Message ID <cover.1330523904.git.shane.wang@intel.com>
Download mbox
Permalink /patch/22421/
State New
Headers show

Pull-request

git://git.pokylinux.org/poky-contrib shane/hob2-v0.68

Comments

Shane Wang - Feb. 29, 2012, 2:11 p.m.
The following patches are going to fix the following problems:

* Enable HobNotebook to make notebook more like the design video;
* Improve and enhance the GUI;
* Rebase the patches Josh has sent out before with the title "Hob tweaks";
* Address some tricky issues we found in the bitbake;
* Revise Hob according to the comments on the previous patch set;
* Fix some bugs we found when testing Hob;
* and some temporary walkarounds we have to find a way to solve in Hob or in the bitbake later.

The following changes since commit 927bec5f72230be4f2452d9ef5a747b2c00cb781:

  bitbake.conf: Create a new filter variable BB_HASHCONFIG_WHITELIST (2012-02-27 20:10:41 +0000)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib shane/hob2-v0.68
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=shane/hob2-v0.68

Dongxiao Xu (10):
  command.py: remove the resolve parameter in generateTargetsTree
  cooker.py: Fix a bug due to variable name
  cooker: fix calculating of depends and rdepends
  Hob(crumbs/hoblistmodel.py): Fix recipe's populate() function
  Hob(crumbs/hoblistmodel.py): Add mapping for rprovides and pkg
  Hob: Add an extra 50M space if zypper is selected
  Hob: add "OK" button to "BinbDialog"
  Hob: Fix pressing "stop" build
  runqueue.py: initialize rqexe at RunQueue's init function
  Hob: Disable the handling of "NoProvider" event

Shane Wang (22):
  Hob: make HobViewTable more general in hob and make the image
    selection dialog and the image details page reuse it.
  Hob: avoid the image selection dialog to walk through all directories
    and its sub-directories, when users click "My images".
  Hob: cleanup those class methods in HobWidget
  Hob: fixed the issue in the brought-in-by dialog.
  Hob: include hddimg and iso into image types.
  Hob: implement a self-defined notebook visual component for Hob
  Hob: use HobNotebook to enable a notebook in build details page
  Hob: image configuration page doesn't need dialogs any more
  Hob: fix a bug in builder.configuration.curr_mach
  Hob: add ignore_all_errors to avoid showing error dialog multiple
    times
  Hob: make the image configuration page not to flash the progress bar
  Hob: enable indicators on the "Included" tab in the recipe selection
    page and the package selection page
  crumbs: Factor common dialogue configuration out
  crumbs/builder: use the name Hob consistently
  crumbs: move towards more standard dialogue spacing
  crumbs: fix button order in several dialogues
  hig: try to avoid setting explicit dialogue sizes
  crumbs/hig: tweak UI and layout of LayerSelectionDialog
  Hob(crumbs/builder.py): remove the code commented out in the
    builder.py
  Hob: fix a bug that the image size is shown incorrectly in the image
    details page.
  Hob: allow users to setup the proxy
  Hob(crumbs/builder.py): adjust the main window's position and ignore
    the case lower than 1024x768.

 bitbake/lib/bb/command.py                          |   14 +-
 bitbake/lib/bb/cooker.py                           |   74 +-
 bitbake/lib/bb/runqueue.py                         |    5 +
 bitbake/lib/bb/ui/crumbs/builddetailspage.py       |   40 +-
 bitbake/lib/bb/ui/crumbs/builder.py                |  138 ++-
 bitbake/lib/bb/ui/crumbs/hig.py                    |  672 ++++++++++--
 bitbake/lib/bb/ui/crumbs/hobcolor.py               |    1 +
 bitbake/lib/bb/ui/crumbs/hobeventhandler.py        |   48 +-
 bitbake/lib/bb/ui/crumbs/hoblistmodel.py           |   60 +-
 bitbake/lib/bb/ui/crumbs/hobwidget.py              | 1135 ++++++++------------
 bitbake/lib/bb/ui/crumbs/imageconfigurationpage.py |   34 +-
 bitbake/lib/bb/ui/crumbs/imagedetailspage.py       |   93 ++-
 bitbake/lib/bb/ui/crumbs/packageselectionpage.py   |   56 +-
 bitbake/lib/bb/ui/crumbs/recipeselectionpage.py    |   55 +-
 bitbake/lib/bb/ui/crumbs/runningbuild.py           |   69 ++
 15 files changed, 1457 insertions(+), 1037 deletions(-)
Joshua Lock - Feb. 29, 2012, 9:27 p.m.
Hi,

On 29/02/12 06:11, Shane Wang wrote:
> The following patches are going to fix the following problems:
>
> * Enable HobNotebook to make notebook more like the design video;
> * Improve and enhance the GUI;
> * Rebase the patches Josh has sent out before with the title "Hob tweaks";
> * Address some tricky issues we found in the bitbake;
> * Revise Hob according to the comments on the previous patch set;
> * Fix some bugs we found when testing Hob;
> * and some temporary walkarounds we have to find a way to solve in Hob or in the bitbake later.
>
> The following changes since commit 927bec5f72230be4f2452d9ef5a747b2c00cb781:
>
>    bitbake.conf: Create a new filter variable BB_HASHCONFIG_WHITELIST (2012-02-27 20:10:41 +0000)

This is a pretty decent series. I'd appreciate smaller ones in future as 
they're easier to review.

I've tried to comment on each patch with SOB's for the ones that I'm OK 
with and comments for the rest.

One thing I did notice whilst reviewing this series is that there's a 
lot of this anti-pattern in the hob 2 code:
	for i in range(len(mylist)):
rather than:
	for item in list:

Can we make an effort to tidy those up?

Cheers,
Joshua
Richard Purdie - March 1, 2012, 3:32 p.m.
On Wed, 2012-02-29 at 22:11 +0800, Shane Wang wrote:
> The following patches are going to fix the following problems:
> 
> * Enable HobNotebook to make notebook more like the design video;
> * Improve and enhance the GUI;
> * Rebase the patches Josh has sent out before with the title "Hob tweaks";
> * Address some tricky issues we found in the bitbake;
> * Revise Hob according to the comments on the previous patch set;
> * Fix some bugs we found when testing Hob;
> * and some temporary walkarounds we have to find a way to solve in Hob or in the bitbake later.
> 
> The following changes since commit 927bec5f72230be4f2452d9ef5a747b2c00cb781:
> 
>   bitbake.conf: Create a new filter variable BB_HASHCONFIG_WHITELIST (2012-02-27 20:10:41 +0000)
> 
> are available in the git repository at:
>   git://git.pokylinux.org/poky-contrib shane/hob2-v0.68
>   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=shane/hob2-v0.68
> 
> Dongxiao Xu (10):
>   command.py: remove the resolve parameter in generateTargetsTree
>   cooker.py: Fix a bug due to variable name
>   cooker: fix calculating of depends and rdepends
>   Hob(crumbs/hoblistmodel.py): Fix recipe's populate() function
>   Hob(crumbs/hoblistmodel.py): Add mapping for rprovides and pkg
>   **** Hob: Add an extra 50M space if zypper is selected
>   **** Hob: add "OK" button to "BinbDialog"
>   Hob: Fix pressing "stop" build
>   runqueue.py: initialize rqexe at RunQueue's init function
>   **** Hob: Disable the handling of "NoProvider" event
> 
> Shane Wang (22):
>   Hob: make HobViewTable more general in hob and make the image
>     selection dialog and the image details page reuse it.
>   Hob: avoid the image selection dialog to walk through all directories
>     and its sub-directories, when users click "My images".
>   Hob: cleanup those class methods in HobWidget
>   Hob: fixed the issue in the brought-in-by dialog.
>   Hob: include hddimg and iso into image types.
>   **** Hob: implement a self-defined notebook visual component for Hob
>   **** Hob: use HobNotebook to enable a notebook in build details page
>   Hob: image configuration page doesn't need dialogs any more
>   Hob: fix a bug in builder.configuration.curr_mach
>   **** Hob: add ignore_all_errors to avoid showing error dialog multiple
>     times
>   Hob: make the image configuration page not to flash the progress bar
>   Hob: enable indicators on the "Included" tab in the recipe selection
>     page and the package selection page
>   crumbs: Factor common dialogue configuration out
>   crumbs/builder: use the name Hob consistently
>   crumbs: move towards more standard dialogue spacing
>   crumbs: fix button order in several dialogues
>   hig: try to avoid setting explicit dialogue sizes
>   crumbs/hig: tweak UI and layout of LayerSelectionDialog
>   Hob(crumbs/builder.py): remove the code commented out in the
>     builder.py
>   Hob: fix a bug that the image size is shown incorrectly in the image
>     details page.
>   **** Hob: allow users to setup the proxy
>   Hob(crumbs/builder.py): adjust the main window's position and ignore
>     the case lower than 1024x768.

I pulled the above except where marked with "****". In those cases there
is feedback on the patches which needs discussion. 

I removed one piece of debug Joshua noticed and had to manually tweak
one patch to get it to apply due to other patches not being applied.
I'll expect an new pull request for the remaining patches.

Cheers,

Richard
Richard Purdie - March 1, 2012, 3:35 p.m.
On Wed, 2012-02-29 at 22:11 +0800, Shane Wang wrote:
> The following patches are going to fix the following problems:
> 
> * Enable HobNotebook to make notebook more like the design video;
> * Improve and enhance the GUI;
> * Rebase the patches Josh has sent out before with the title "Hob tweaks";
> * Address some tricky issues we found in the bitbake;
> * Revise Hob according to the comments on the previous patch set;
> * Fix some bugs we found when testing Hob;
> * and some temporary walkarounds we have to find a way to solve in Hob or in the bitbake later.
> 
> The following changes since commit 927bec5f72230be4f2452d9ef5a747b2c00cb781:
> 
>   bitbake.conf: Create a new filter variable BB_HASHCONFIG_WHITELIST (2012-02-27 20:10:41 +0000)
> 
> are available in the git repository at:
>   git://git.pokylinux.org/poky-contrib shane/hob2-v0.68
>   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=shane/hob2-v0.68
> 
> Dongxiao Xu (10):
>   command.py: remove the resolve parameter in generateTargetsTree
>   cooker.py: Fix a bug due to variable name
>   cooker: fix calculating of depends and rdepends
>   Hob(crumbs/hoblistmodel.py): Fix recipe's populate() function
>   Hob(crumbs/hoblistmodel.py): Add mapping for rprovides and pkg
>   Hob: Add an extra 50M space if zypper is selected
>   Hob: add "OK" button to "BinbDialog"
>   Hob: Fix pressing "stop" build
>   runqueue.py: initialize rqexe at RunQueue's init function
>   Hob: Disable the handling of "NoProvider" event
> 
> Shane Wang (22):
>   Hob: make HobViewTable more general in hob and make the image
>     selection dialog and the image details page reuse it.
>   Hob: avoid the image selection dialog to walk through all directories
>     and its sub-directories, when users click "My images".
>   Hob: cleanup those class methods in HobWidget
>   Hob: fixed the issue in the brought-in-by dialog.
>   Hob: include hddimg and iso into image types.
>   Hob: implement a self-defined notebook visual component for Hob
>   Hob: use HobNotebook to enable a notebook in build details page
>   Hob: image configuration page doesn't need dialogs any more
>   Hob: fix a bug in builder.configuration.curr_mach
>   Hob: add ignore_all_errors to avoid showing error dialog multiple
>     times
>   Hob: make the image configuration page not to flash the progress bar
>   Hob: enable indicators on the "Included" tab in the recipe selection
>     page and the package selection page
>   crumbs: Factor common dialogue configuration out
>   crumbs/builder: use the name Hob consistently
>   crumbs: move towards more standard dialogue spacing
>   crumbs: fix button order in several dialogues
>   hig: try to avoid setting explicit dialogue sizes
>   crumbs/hig: tweak UI and layout of LayerSelectionDialog
>   Hob(crumbs/builder.py): remove the code commented out in the
>     builder.py
>   Hob: fix a bug that the image size is shown incorrectly in the image
>     details page.
>   Hob: allow users to setup the proxy
>   Hob(crumbs/builder.py): adjust the main window's position and ignore
>     the case lower than 1024x768.

I also just realised some of these patches were authored by Joshua.
Please ensure there is a:

From: XXX <xxx>

at the head of such patches so the author information gets correctly
recorded. Unfortunately I realised to late with this push to be able to
correct it :(

Cheers,

Richard
Shane Wang - March 2, 2012, 1:23 a.m.
Josh, I am sorry for missing to add From: XXX<xxx> in your six patches.
I originally think "Signed-off-by: Josh" is enough.

Because I have some cleanups to remove class methods for HobWidget for clean Object Oriented design, which changed the code a lot.
So, some of my patches jumped the queue to save merging and rebasing efforts.

Sorry for that.
--
Shane

Richard Purdie wrote on 2012-03-01:
> 

> I also just realised some of these patches were authored by Joshua.

> Please ensure there is a:

> 

> From: XXX <xxx>

> 

> at the head of such patches so the author information gets correctly

> recorded. Unfortunately I realised to late with this push to be able to

> correct it :(

> 

> Cheers,

> 

> Richard
Shane Wang - March 2, 2012, 6:48 a.m.
Joshua Lock wrote on 2012-03-01:
> One thing I did notice whilst reviewing this series is that there's a
> lot of this anti-pattern in the hob 2 code:
> 	for i in range(len(mylist)):
> rather than:
> 	for item in list:
> 
> Can we make an effort to tidy those up?
I will check those later. I went through them quickly.
Some of them are because the code refers to the index i.

Otherwise, we would have the code.
i = 0
for item in list:
 XXXXX
 XXX = i
 i += 1

which also looks not perfect. But anyway, I will check all of them later and send another patch for improvement.
If there is no reference to the index, I will replace with your style.

--
Shane

> 
> Cheers,
> Joshua
Oren Leaffer - March 3, 2012, 3:50 a.m.
Shane,

As I understand it, if you need keep track of indices as you go
through a list, then enumerate() is the python way to do it.
http://docs.python.org/library/functions.html#enumerate

So you would have:

for i, item in enumerate(list):
   ... etc


Best regards,


Oren

On Fri, Mar 2, 2012 at 1:48 AM, Wang, Shane <shane.wang@intel.com> wrote:
> Joshua Lock wrote on 2012-03-01:
>> One thing I did notice whilst reviewing this series is that there's a
>> lot of this anti-pattern in the hob 2 code:
>>       for i in range(len(mylist)):
>> rather than:
>>       for item in list:
>>
>> Can we make an effort to tidy those up?
> I will check those later. I went through them quickly.
> Some of them are because the code refers to the index i.
>
> Otherwise, we would have the code.
> i = 0
> for item in list:
>  XXXXX
>  XXX = i
>  i += 1
>
> which also looks not perfect. But anyway, I will check all of them later and send another patch for improvement.
> If there is no reference to the index, I will replace with your style.
>
> --
> Shane
>
>>
>> Cheers,
>> Joshua
>
>
> _______________________________________________
> bitbake-devel mailing list
> bitbake-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/bitbake-devel