Patchwork [1/1] More quoting fixes

login
register
mail settings
Submitter Paul Eggleton
Date Feb. 29, 2012, 12:59 p.m.
Message ID <9f75e5f43a30ed6e154f299ead955588c98de5c7.1330520324.git.paul.eggleton@linux.intel.com>
Download mbox | patch
Permalink /patch/22413/
State Accepted
Commit 17f2d5d70ad323cea4fb149154bc38844661fa3a
Headers show

Comments

Paul Eggleton - Feb. 29, 2012, 12:59 p.m.
Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 .../opensync/libsyncml_0.5.4.bb                    |    2 +-
 meta/recipes-devtools/guile/guile_2.0.3.bb         |    2 +-
 meta/recipes-graphics/cairo/cairo.inc              |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
Otavio Salvador - Feb. 29, 2012, 1:19 p.m.
On Wed, Feb 29, 2012 at 09:59, Paul Eggleton
<paul.eggleton@linux.intel.com> wrote:
> -export VERBOSE=1
> +export VERBOSE="1"

I fully agree with the change but here it doesn't raise a parser
error. Isn't it expected to happen?
Paul Eggleton - Feb. 29, 2012, 1:24 p.m.
On Wednesday 29 February 2012 10:19:33 Otavio Salvador wrote:
> On Wed, Feb 29, 2012 at 09:59, Paul Eggleton
> 
> <paul.eggleton@linux.intel.com> wrote:
> > -export VERBOSE=1
> > +export VERBOSE="1"
> 
> I fully agree with the change but here it doesn't raise a parser
> error. Isn't it expected to happen?

Yes, that has also been fixed in bitbake master.

Cheers,
Paul
Richard Purdie - Feb. 29, 2012, 1:26 p.m.
On Wed, 2012-02-29 at 10:19 -0300, Otavio Salvador wrote:
> On Wed, Feb 29, 2012 at 09:59, Paul Eggleton
> <paul.eggleton@linux.intel.com> wrote:
> > -export VERBOSE=1
> > +export VERBOSE="1"
> 
> I fully agree with the change but here it doesn't raise a parser
> error. Isn't it expected to happen?

No. I added something to bitbake a short while ago and these are parser
errors now!

Cheers,

Richard
Otavio Salvador - Feb. 29, 2012, 1:27 p.m.
On Wed, Feb 29, 2012 at 10:26, Richard Purdie <rpurdie@rpsys.net> wrote:
> No. I added something to bitbake a short while ago and these are parser
> errors now!

Good.

Patch

diff --git a/meta-demoapps/recipes-connectivity/opensync/libsyncml_0.5.4.bb b/meta-demoapps/recipes-connectivity/opensync/libsyncml_0.5.4.bb
index c045698..e96463b 100644
--- a/meta-demoapps/recipes-connectivity/opensync/libsyncml_0.5.4.bb
+++ b/meta-demoapps/recipes-connectivity/opensync/libsyncml_0.5.4.bb
@@ -14,4 +14,4 @@  PACKAGES += "${PN}-tools"
 FILES_${PN}-tools = "${bindir}"
 FILES_${PN} = "${libdir}/*.so.*"
 
-export VERBOSE=1
+export VERBOSE="1"
diff --git a/meta/recipes-devtools/guile/guile_2.0.3.bb b/meta/recipes-devtools/guile/guile_2.0.3.bb
index 729aed0..538ff46 100644
--- a/meta/recipes-devtools/guile/guile_2.0.3.bb
+++ b/meta/recipes-devtools/guile/guile_2.0.3.bb
@@ -39,7 +39,7 @@  do_configure_prepend() {
 	mkdir -p po
 }
 
-export GUILE_FOR_BUILD=${BUILD_SYS}-guile
+export GUILE_FOR_BUILD="${BUILD_SYS}-guile"
 
 do_compile_append() {
 	# just for target recipe
diff --git a/meta/recipes-graphics/cairo/cairo.inc b/meta/recipes-graphics/cairo/cairo.inc
index 1d5d551..69984cb 100644
--- a/meta/recipes-graphics/cairo/cairo.inc
+++ b/meta/recipes-graphics/cairo/cairo.inc
@@ -27,4 +27,4 @@  EXTRA_OECONF += "${@get_cairo_fpu_setting(bb, d)} \
 inherit autotools pkgconfig
 
 # We don't depend on binutils so we need to disable this
-export ac_cv_lib_bfd_bfd_openr=no
+export ac_cv_lib_bfd_bfd_openr="no"