Patchwork [v2,12/12] gnu-config-native: add dependency on perl-native

login
register
mail settings
Submitter Dexuan Cui
Date April 14, 2011, 8:56 a.m.
Message ID <dc2b7b09baaee3ef172e41edfb2eedfe065b0006.1302770941.git.dexuan.cui@intel.com>
Download mbox | patch
Permalink /patch/2229/
State New, archived
Headers show

Comments

Dexuan Cui - April 14, 2011, 8:56 a.m.
From: Dexuan Cui <dexuan.cui@intel.com>

Fixes [YOCTO #968]

Signed-off-by: Dexuan Cui <dexuan.cui@intel.com>
---
 .../gnu-config/gnu-config_20080123.bb              |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
Saul Wold - April 14, 2011, 9:24 p.m.
On 04/14/2011 01:56 AM, Dexuan Cui wrote:
> From: Dexuan Cui<dexuan.cui@intel.com>
>
> Fixes [YOCTO #968]
>
> Signed-off-by: Dexuan Cui<dexuan.cui@intel.com>
> ---
>   .../gnu-config/gnu-config_20080123.bb              |    4 +++-
>   1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-devtools/gnu-config/gnu-config_20080123.bb b/meta/recipes-devtools/gnu-config/gnu-config_20080123.bb
> index e0a8155..2ad0834 100644
> --- a/meta/recipes-devtools/gnu-config/gnu-config_20080123.bb
> +++ b/meta/recipes-devtools/gnu-config/gnu-config_20080123.bb
> @@ -3,7 +3,9 @@ DESCRIPTION = "Tool that installs the GNU config.guess / config.sub into a direc
>   SECTION = "devel"
>   LICENSE = "GPLv1+"
>   LIC_FILES_CHKSUM = "file://config.guess;endline=39;md5=a089987af4a25cb0419d1c2fd6d495e3"
> -DEPENDS = ""
> +
> +DEPENDS_virtclass-native = "perl-native"
> +
>   INHIBIT_DEFAULT_DEPS = "1"
>
>   FIXEDSRCDATE = "${@bb.data.getVar('FILE', d, 1).split('_')[-1].split('.')[0]}"
Looks like you forgot to bump PR for this.

Also, there is a patch associated with this recipe that needs the 
Upstream-Status tag
Dexuan Cui - April 15, 2011, 2:53 a.m.
Saul Wold wrote:
> On 04/14/2011 01:56 AM, Dexuan Cui wrote:
>> From: Dexuan Cui<dexuan.cui@intel.com>
>> 
>> Fixes [YOCTO #968]
>> 
>> Signed-off-by: Dexuan Cui<dexuan.cui@intel.com>
>> ---
>>   .../gnu-config/gnu-config_20080123.bb              |    4 +++-
>>   1 files changed, 3 insertions(+), 1 deletions(-)
>> 
>> diff --git a/meta/recipes-devtools/gnu-config/gnu-config_20080123.bb
>> b/meta/recipes-devtools/gnu-config/gnu-config_20080123.bb index
>> e0a8155..2ad0834 100644 ---
>> a/meta/recipes-devtools/gnu-config/gnu-config_20080123.bb +++
>>   b/meta/recipes-devtools/gnu-config/gnu-config_20080123.bb @@ -3,7
>>   +3,9 @@ DESCRIPTION = "Tool that installs the GNU config.guess /
>> config.sub into a direc   SECTION = "devel" LICENSE = "GPLv1+"
>> LIC_FILES_CHKSUM =
>> "file://config.guess;endline=39;md5=a089987af4a25cb0419d1c2fd6d495e3"
>>   -DEPENDS = "" + +DEPENDS_virtclass-native = "perl-native" +
>> INHIBIT_DEFAULT_DEPS = "1" 
>> 
>>   FIXEDSRCDATE = "${@bb.data.getVar('FILE', d,
>> 1).split('_')[-1].split('.')[0]}" 
> Looks like you forgot to bump PR for this.
Hi Saul,
I thought it's ok to not bump PR if we only change DEPENDS?
e.g, the following commits didn't bump PR, too:
7c474dc3
2a285e69
2fc03aee
c600ea7b
 
> Also, there is a patch associated with this recipe that needs the
> Upstream-Status tag
Thanks for the reminder!
This is a fix (not an update) and I failed to notice that the recipe has patches... :-(
Will add the tag and re-send the PULL.

Thanks,
-- Dexuan

Patch

diff --git a/meta/recipes-devtools/gnu-config/gnu-config_20080123.bb b/meta/recipes-devtools/gnu-config/gnu-config_20080123.bb
index e0a8155..2ad0834 100644
--- a/meta/recipes-devtools/gnu-config/gnu-config_20080123.bb
+++ b/meta/recipes-devtools/gnu-config/gnu-config_20080123.bb
@@ -3,7 +3,9 @@  DESCRIPTION = "Tool that installs the GNU config.guess / config.sub into a direc
 SECTION = "devel"
 LICENSE = "GPLv1+"
 LIC_FILES_CHKSUM = "file://config.guess;endline=39;md5=a089987af4a25cb0419d1c2fd6d495e3"
-DEPENDS = ""
+
+DEPENDS_virtclass-native = "perl-native"
+
 INHIBIT_DEFAULT_DEPS = "1"
 
 FIXEDSRCDATE = "${@bb.data.getVar('FILE', d, 1).split('_')[-1].split('.')[0]}"