Patchwork gdk-pixbuf: Pick up ${NM} from the environment.

login
register
mail settings
Submitter James Limbouris
Date Feb. 28, 2012, 7:36 a.m.
Message ID <1330414619-21016-1-git-send-email-james@digitalmatter.com.au>
Download mbox | patch
Permalink /patch/22287/
State New
Headers show

Comments

James Limbouris - Feb. 28, 2012, 7:36 a.m.
Signed-off-by: James Limbouris <james@digitalmatter.com.au>
---
 .../gdk-pixbuf-2.24.0/configure_nm.patch           |   19 +++++++++++++++++++
 meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.0.bb |    3 ++-
 2 files changed, 21 insertions(+), 1 deletions(-)
 create mode 100644 meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf-2.24.0/configure_nm.patch
Khem Raj - March 1, 2012, 10:06 a.m.
On 02/27/2012 11:36 PM, James Limbouris wrote:
> Signed-off-by: James Limbouris <james@digitalmatter.com.au>
> ---
>  .../gdk-pixbuf-2.24.0/configure_nm.patch           |   19 +++++++++++++++++++
>  meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.0.bb |    3 ++-
>  2 files changed, 21 insertions(+), 1 deletions(-)
>  create mode 100644 meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf-2.24.0/configure_nm.patch
> 
> diff --git a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf-2.24.0/configure_nm.patch b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf-2.24.0/configure_nm.patch
> new file mode 100644
> index 0000000..1697967
> --- /dev/null
> +++ b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf-2.24.0/configure_nm.patch
> @@ -0,0 +1,19 @@
> +At this stage of configure, ${NM} has already been correctly set.
> +This AC_PATH_PROG overwrites the correct path with a host path.
> +
> +Upstream-Status: Inappropriate [configuration]
> +Signed-off-by: James Limbouris <james@digitalmatter.com.au>
> +
> +Index: gdk-pixbuf-2.24.0/configure.ac
> +===================================================================
> +diff -uNr gdk-pixbuf-2.24.0/configure.ac gdk-pixbuf-2.24.0.mod/configure.ac
> +--- gdk-pixbuf-2.24.0/configure.ac	2011-08-27 11:27:52.000000000 +0800
> ++++ gdk-pixbuf-2.24.0.mod/configure.ac	2012-02-28 14:48:36.481126410 +0800
> +@@ -147,7 +147,6 @@
> + AC_SYS_LARGEFILE
> + 
> + AM_PROG_AS
> +-AC_PATH_PROG(NM, nm, nm)

you could use AC_CHECK_TOOLS(NM, [$NM nm], nm)
here instead of deleting it
James Limbouris - March 2, 2012, 3:07 a.m.
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf
> Of Khem Raj
> Sent: Thursday, 1 March 2012 6:06 PM
> To: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH] gdk-pixbuf: Pick up ${NM} from the
> environment.
> 
> On 02/27/2012 11:36 PM, James Limbouris wrote:
> > Signed-off-by: James Limbouris <james@digitalmatter.com.au>
> > ---
> >  .../gdk-pixbuf-2.24.0/configure_nm.patch           |   19
> +++++++++++++++++++
> >  meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.0.bb |    3 ++-
> >  2 files changed, 21 insertions(+), 1 deletions(-)
> >  create mode 100644 meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf-
> 2.24.0/configure_nm.patch
> >
> > diff --git a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf-
> 2.24.0/configure_nm.patch b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf-
> 2.24.0/configure_nm.patch
> > new file mode 100644
> > index 0000000..1697967
> > --- /dev/null
> > +++ b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf-
> 2.24.0/configure_nm.patch
> > @@ -0,0 +1,19 @@
> > +At this stage of configure, ${NM} has already been correctly set.
> > +This AC_PATH_PROG overwrites the correct path with a host path.
> > +
> > +Upstream-Status: Inappropriate [configuration]
> > +Signed-off-by: James Limbouris <james@digitalmatter.com.au>
> > +
> > +Index: gdk-pixbuf-2.24.0/configure.ac
> >
> +=========================================================
> ==========
> > +diff -uNr gdk-pixbuf-2.24.0/configure.ac gdk-pixbuf-
> 2.24.0.mod/configure.ac
> > +--- gdk-pixbuf-2.24.0/configure.ac	2011-08-27 11:27:52.000000000 +0800
> > ++++ gdk-pixbuf-2.24.0.mod/configure.ac	2012-02-28
> 14:48:36.481126410 +0800
> > +@@ -147,7 +147,6 @@
> > + AC_SYS_LARGEFILE
> > +
> > + AM_PROG_AS
> > +-AC_PATH_PROG(NM, nm, nm)
> 
> you could use AC_CHECK_TOOLS(NM, [$NM nm], nm)
> here instead of deleting it

On my system at least, nm has already been found and examined by the config script at this stage.
The AC_PATH_PROG looks for it a second time, and overwrites the already correct entry.
So, do we need an AC_CHECK_TOOLS?
Khem Raj - March 2, 2012, 5:23 a.m.
On (02/03/12 03:07), James Limbouris wrote:
> > -----Original Message-----
> > From: openembedded-core-bounces@lists.openembedded.org
> > [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf
> > Of Khem Raj
> > Sent: Thursday, 1 March 2012 6:06 PM
> > To: openembedded-core@lists.openembedded.org
> > Subject: Re: [OE-core] [PATCH] gdk-pixbuf: Pick up ${NM} from the
> > environment.
> > 
> > On 02/27/2012 11:36 PM, James Limbouris wrote:
> > > Signed-off-by: James Limbouris <james@digitalmatter.com.au>
> > > ---
> > >  .../gdk-pixbuf-2.24.0/configure_nm.patch           |   19
> > +++++++++++++++++++
> > >  meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.0.bb |    3 ++-
> > >  2 files changed, 21 insertions(+), 1 deletions(-)
> > >  create mode 100644 meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf-
> > 2.24.0/configure_nm.patch
> > >
> > > diff --git a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf-
> > 2.24.0/configure_nm.patch b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf-
> > 2.24.0/configure_nm.patch
> > > new file mode 100644
> > > index 0000000..1697967
> > > --- /dev/null
> > > +++ b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf-
> > 2.24.0/configure_nm.patch
> > > @@ -0,0 +1,19 @@
> > > +At this stage of configure, ${NM} has already been correctly set.
> > > +This AC_PATH_PROG overwrites the correct path with a host path.
> > > +
> > > +Upstream-Status: Inappropriate [configuration]
> > > +Signed-off-by: James Limbouris <james@digitalmatter.com.au>
> > > +
> > > +Index: gdk-pixbuf-2.24.0/configure.ac
> > >
> > +=========================================================
> > ==========
> > > +diff -uNr gdk-pixbuf-2.24.0/configure.ac gdk-pixbuf-
> > 2.24.0.mod/configure.ac
> > > +--- gdk-pixbuf-2.24.0/configure.ac	2011-08-27 11:27:52.000000000 +0800
> > > ++++ gdk-pixbuf-2.24.0.mod/configure.ac	2012-02-28
> > 14:48:36.481126410 +0800
> > > +@@ -147,7 +147,6 @@
> > > + AC_SYS_LARGEFILE
> > > +
> > > + AM_PROG_AS
> > > +-AC_PATH_PROG(NM, nm, nm)
> > 
> > you could use AC_CHECK_TOOLS(NM, [$NM nm], nm)
> > here instead of deleting it
> 
> On my system at least, nm has already been found and examined by the config script at this stage.
> The AC_PATH_PROG looks for it a second time, and overwrites the already correct entry.
> So, do we need an AC_CHECK_TOOLS?

its set in environment yes but removing it in not correct
thing from the package perspective. using AC_CHECK_TOOLS makes it work well
in cross environment and native build bahavior is not changed.
More over such a patch will be a welcome in upstream of this package
as well.
James Limbouris - March 2, 2012, 5:49 a.m.
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf
> Of Khem Raj
> Sent: Friday, 2 March 2012 1:24 PM
> To: Patches and discussions about the oe-core layer
> Subject: Re: [OE-core] [PATCH] gdk-pixbuf: Pick up ${NM} from the
> environment.
> 
> On (02/03/12 03:07), James Limbouris wrote:
> > > -----Original Message-----
> > > From: openembedded-core-bounces@lists.openembedded.org
> > > [mailto:openembedded-core-bounces@lists.openembedded.org] On
> Behalf
> > > Of Khem Raj
> > > Sent: Thursday, 1 March 2012 6:06 PM
> > > To: openembedded-core@lists.openembedded.org
> > > Subject: Re: [OE-core] [PATCH] gdk-pixbuf: Pick up ${NM} from the
> > > environment.
> > >
> > > On 02/27/2012 11:36 PM, James Limbouris wrote:
> > > > Signed-off-by: James Limbouris <james@digitalmatter.com.au>
> > > > ---
> > > >  .../gdk-pixbuf-2.24.0/configure_nm.patch           |   19
> > > +++++++++++++++++++
> > > >  meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.0.bb |    3 ++-
> > > >  2 files changed, 21 insertions(+), 1 deletions(-)
> > > >  create mode 100644 meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf-
> > > 2.24.0/configure_nm.patch
> > > >
> > > > diff --git a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf-
> > > 2.24.0/configure_nm.patch b/meta/recipes-gnome/gdk-pixbuf/gdk-
> pixbuf-
> > > 2.24.0/configure_nm.patch
> > > > new file mode 100644
> > > > index 0000000..1697967
> > > > --- /dev/null
> > > > +++ b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf-
> > > 2.24.0/configure_nm.patch
> > > > @@ -0,0 +1,19 @@
> > > > +At this stage of configure, ${NM} has already been correctly set.
> > > > +This AC_PATH_PROG overwrites the correct path with a host path.
> > > > +
> > > > +Upstream-Status: Inappropriate [configuration]
> > > > +Signed-off-by: James Limbouris <james@digitalmatter.com.au>
> > > > +
> > > > +Index: gdk-pixbuf-2.24.0/configure.ac
> > > >
> > >
> +=========================================================
> > > ==========
> > > > +diff -uNr gdk-pixbuf-2.24.0/configure.ac gdk-pixbuf-
> > > 2.24.0.mod/configure.ac
> > > > +--- gdk-pixbuf-2.24.0/configure.ac	2011-08-27
> 11:27:52.000000000 +0800
> > > > ++++ gdk-pixbuf-2.24.0.mod/configure.ac	2012-02-28
> > > 14:48:36.481126410 +0800
> > > > +@@ -147,7 +147,6 @@
> > > > + AC_SYS_LARGEFILE
> > > > +
> > > > + AM_PROG_AS
> > > > +-AC_PATH_PROG(NM, nm, nm)
> > >
> > > you could use AC_CHECK_TOOLS(NM, [$NM nm], nm)
> > > here instead of deleting it
> >
> > On my system at least, nm has already been found and examined by the
> config script at this stage.
> > The AC_PATH_PROG looks for it a second time, and overwrites the already
> correct entry.
> > So, do we need an AC_CHECK_TOOLS?
> 
> its set in environment yes but removing it in not correct
> thing from the package perspective. using AC_CHECK_TOOLS makes it work
> well
> in cross environment and native build bahavior is not changed.
> More over such a patch will be a welcome in upstream of this package
> as well.

It is more than set in the environment - the configure script spits out two messages about it before hitting this macro.
So, I think the check is entirely extraneous.

I have seen this issue patched out in other gnome packages, some in oe-core.
At least one was marked Upstream-Status: Inappropriate [configuration], and one marked Pending.
So I got the idea that upstream was not interested...
Khem Raj - March 2, 2012, 7:55 a.m.
> It is more than set in the environment - the configure script spits out two messages about it before hitting this macro.
> So, I think the check is entirely extraneous.
> 

if you can point that there is another check which makes this one
redundant thats a different issue and then your patch is ok. but I doubt
thats the case

> I have seen this issue patched out in other gnome packages, some in oe-core.
> At least one was marked Upstream-Status: Inappropriate [configuration], and one marked Pending.
> So I got the idea that upstream was not interested...

usually such patches are taken status may be too conservative

> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
James Limbouris - March 2, 2012, 8:12 a.m.
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf
> Of Khem Raj
> Sent: Friday, 2 March 2012 3:56 PM
> To: Patches and discussions about the oe-core layer
> Subject: Re: [OE-core] [PATCH] gdk-pixbuf: Pick up ${NM} from the
> environment.
> 
> > It is more than set in the environment - the configure script spits out two
> messages about it before hitting this macro.
> > So, I think the check is entirely extraneous.
> >
> 
> if you can point that there is another check which makes this one
> redundant thats a different issue and then your patch is ok. but I doubt
> thats the case
> 
> > I have seen this issue patched out in other gnome packages, some in oe-
> core.
> > At least one was marked Upstream-Status: Inappropriate [configuration],
> and one marked Pending.
> > So I got the idea that upstream was not interested...
> 
> usually such patches are taken status may be too conservative
> 

Here is the fragment from the configure script, with the patch applied. Sorry, it's quite long:

{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for BSD- or MS-compatible name lister (nm)" >&5
$as_echo_n "checking for BSD- or MS-compatible name lister (nm)... " >&6; }
if ${lt_cv_path_NM+:} false; then :
  $as_echo_n "(cached) " >&6
else
  if test -n "$NM"; then
  # Let the user override the test.
  lt_cv_path_NM="$NM"
else
  lt_nm_to_check="${ac_tool_prefix}nm"
  if test -n "$ac_tool_prefix" && test "$build" = "$host"; then
    lt_nm_to_check="$lt_nm_to_check nm"
  fi
  for lt_tmp_nm in $lt_nm_to_check; do
    lt_save_ifs="$IFS"; IFS=$PATH_SEPARATOR
    for ac_dir in $PATH /usr/ccs/bin/elf /usr/ccs/bin /usr/ucb /bin; do
      IFS="$lt_save_ifs"
      test -z "$ac_dir" && ac_dir=.
      tmp_nm="$ac_dir/$lt_tmp_nm"
      if test -f "$tmp_nm" || test -f "$tmp_nm$ac_exeext" ; then
	# Check to see if the nm accepts a BSD-compat flag.
	# Adding the `sed 1q' prevents false positives on HP-UX, which says:
	#   nm: unknown option "B" ignored
	# Tru64's nm complains that /dev/null is an invalid object file
	case `"$tmp_nm" -B /dev/null 2>&1 | sed '1q'` in
	*/dev/null* | *'Invalid file or object type'*)
	  lt_cv_path_NM="$tmp_nm -B"
	  break
	  ;;
	*)
	  case `"$tmp_nm" -p /dev/null 2>&1 | sed '1q'` in
	  */dev/null*)
	    lt_cv_path_NM="$tmp_nm -p"
	    break
	    ;;
	  *)
	    lt_cv_path_NM=${lt_cv_path_NM="$tmp_nm"} # keep the first match, but
	    continue # so that we can try to find one that supports BSD flags
	    ;;
	  esac
	  ;;
	esac
      fi
    done
    IFS="$lt_save_ifs"
  done
  : ${lt_cv_path_NM=no}
fi
fi
{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $lt_cv_path_NM" >&5
$as_echo "$lt_cv_path_NM" >&6; }
if test "$lt_cv_path_NM" != "no"; then
  NM="$lt_cv_path_NM"
else
  # Didn't find any BSD compatible name lister, look for dumpbin.
  if test -n "$DUMPBIN"; then :
    # Let the user override the test.
  else
    if test -n "$ac_tool_prefix"; then
  for ac_prog in dumpbin "link -dump"
  do
    # Extract the first word of "$ac_tool_prefix$ac_prog", so it can be a program name with args.
set dummy $ac_tool_prefix$ac_prog; ac_word=$2
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for $ac_word" >&5
$as_echo_n "checking for $ac_word... " >&6; }
if ${ac_cv_prog_DUMPBIN+:} false; then :
  $as_echo_n "(cached) " >&6
else
  if test -n "$DUMPBIN"; then
  ac_cv_prog_DUMPBIN="$DUMPBIN" # Let the user override the test.
else
as_save_IFS=$IFS; IFS=$PATH_SEPARATOR
for as_dir in $PATH
do
  IFS=$as_save_IFS
  test -z "$as_dir" && as_dir=.
    for ac_exec_ext in '' $ac_executable_extensions; do
  if { test -f "$as_dir/$ac_word$ac_exec_ext" && $as_test_x "$as_dir/$ac_word$ac_exec_ext"; }; then
    ac_cv_prog_DUMPBIN="$ac_tool_prefix$ac_prog"
    $as_echo "$as_me:${as_lineno-$LINENO}: found $as_dir/$ac_word$ac_exec_ext" >&5
    break 2
  fi
done
  done
IFS=$as_save_IFS


I believe this code is generated by libtool, in ./m4/libtool.m4.
I have _no_ idea how libtool works, or fits in with autotools, so I'm not too sure whether AC_CHECK_TOOLS makes sense here or not.
I'm happy to resubmit and/or file a bugzilla report with Gnome.

Regards,
James
Khem Raj - March 6, 2012, 1:37 a.m.
On (02/03/12 08:12), James Limbouris wrote:
> > -----Original Message-----
> > From: openembedded-core-bounces@lists.openembedded.org
> > [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf
> > Of Khem Raj
> > Sent: Friday, 2 March 2012 3:56 PM
> > To: Patches and discussions about the oe-core layer
> > Subject: Re: [OE-core] [PATCH] gdk-pixbuf: Pick up ${NM} from the
> > environment.
> > 
> > > It is more than set in the environment - the configure script spits out two
> > messages about it before hitting this macro.
> > > So, I think the check is entirely extraneous.
> > >
> > 
> > if you can point that there is another check which makes this one
> > redundant thats a different issue and then your patch is ok. but I doubt
> > thats the case
> > 
> > > I have seen this issue patched out in other gnome packages, some in oe-
> > core.
> > > At least one was marked Upstream-Status: Inappropriate [configuration],
> > and one marked Pending.
> > > So I got the idea that upstream was not interested...
> > 
> > usually such patches are taken status may be too conservative
> > 
> 
> Here is the fragment from the configure script, with the patch applied. Sorry, it's quite long:
> 
> { $as_echo "$as_me:${as_lineno-$LINENO}: checking for BSD- or MS-compatible name lister (nm)" >&5
> $as_echo_n "checking for BSD- or MS-compatible name lister (nm)... " >&6; }
> if ${lt_cv_path_NM+:} false; then :
>   $as_echo_n "(cached) " >&6
> else
>   if test -n "$NM"; then
>   # Let the user override the test.
>   lt_cv_path_NM="$NM"
> else
>   lt_nm_to_check="${ac_tool_prefix}nm"
>   if test -n "$ac_tool_prefix" && test "$build" = "$host"; then
>     lt_nm_to_check="$lt_nm_to_check nm"
>   fi
>   for lt_tmp_nm in $lt_nm_to_check; do
>     lt_save_ifs="$IFS"; IFS=$PATH_SEPARATOR
>     for ac_dir in $PATH /usr/ccs/bin/elf /usr/ccs/bin /usr/ucb /bin; do
>       IFS="$lt_save_ifs"
>       test -z "$ac_dir" && ac_dir=.
>       tmp_nm="$ac_dir/$lt_tmp_nm"
>       if test -f "$tmp_nm" || test -f "$tmp_nm$ac_exeext" ; then
> 	# Check to see if the nm accepts a BSD-compat flag.
> 	# Adding the `sed 1q' prevents false positives on HP-UX, which says:
> 	#   nm: unknown option "B" ignored
> 	# Tru64's nm complains that /dev/null is an invalid object file
> 	case `"$tmp_nm" -B /dev/null 2>&1 | sed '1q'` in
> 	*/dev/null* | *'Invalid file or object type'*)
> 	  lt_cv_path_NM="$tmp_nm -B"
> 	  break
> 	  ;;
> 	*)
> 	  case `"$tmp_nm" -p /dev/null 2>&1 | sed '1q'` in
> 	  */dev/null*)
> 	    lt_cv_path_NM="$tmp_nm -p"
> 	    break
> 	    ;;
> 	  *)
> 	    lt_cv_path_NM=${lt_cv_path_NM="$tmp_nm"} # keep the first match, but
> 	    continue # so that we can try to find one that supports BSD flags
> 	    ;;
> 	  esac
> 	  ;;
> 	esac
>       fi
>     done
>     IFS="$lt_save_ifs"
>   done
>   : ${lt_cv_path_NM=no}
> fi
> fi
> { $as_echo "$as_me:${as_lineno-$LINENO}: result: $lt_cv_path_NM" >&5
> $as_echo "$lt_cv_path_NM" >&6; }
> if test "$lt_cv_path_NM" != "no"; then
>   NM="$lt_cv_path_NM"
> else
>   # Didn't find any BSD compatible name lister, look for dumpbin.
>   if test -n "$DUMPBIN"; then :
>     # Let the user override the test.
>   else
>     if test -n "$ac_tool_prefix"; then
>   for ac_prog in dumpbin "link -dump"
>   do
>     # Extract the first word of "$ac_tool_prefix$ac_prog", so it can be a program name with args.
> set dummy $ac_tool_prefix$ac_prog; ac_word=$2
> { $as_echo "$as_me:${as_lineno-$LINENO}: checking for $ac_word" >&5
> $as_echo_n "checking for $ac_word... " >&6; }
> if ${ac_cv_prog_DUMPBIN+:} false; then :
>   $as_echo_n "(cached) " >&6
> else
>   if test -n "$DUMPBIN"; then
>   ac_cv_prog_DUMPBIN="$DUMPBIN" # Let the user override the test.
> else
> as_save_IFS=$IFS; IFS=$PATH_SEPARATOR
> for as_dir in $PATH
> do
>   IFS=$as_save_IFS
>   test -z "$as_dir" && as_dir=.
>     for ac_exec_ext in '' $ac_executable_extensions; do
>   if { test -f "$as_dir/$ac_word$ac_exec_ext" && $as_test_x "$as_dir/$ac_word$ac_exec_ext"; }; then
>     ac_cv_prog_DUMPBIN="$ac_tool_prefix$ac_prog"
>     $as_echo "$as_me:${as_lineno-$LINENO}: found $as_dir/$ac_word$ac_exec_ext" >&5
>     break 2
>   fi
> done
>   done
> IFS=$as_save_IFS
> 
> 
> I believe this code is generated by libtool, in ./m4/libtool.m4.
> I have _no_ idea how libtool works, or fits in with autotools, so I'm not too sure whether AC_CHECK_TOOLS makes sense here or not.
> I'm happy to resubmit and/or file a bugzilla report with Gnome.
> 


Please resubmit

Patch

diff --git a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf-2.24.0/configure_nm.patch b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf-2.24.0/configure_nm.patch
new file mode 100644
index 0000000..1697967
--- /dev/null
+++ b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf-2.24.0/configure_nm.patch
@@ -0,0 +1,19 @@ 
+At this stage of configure, ${NM} has already been correctly set.
+This AC_PATH_PROG overwrites the correct path with a host path.
+
+Upstream-Status: Inappropriate [configuration]
+Signed-off-by: James Limbouris <james@digitalmatter.com.au>
+
+Index: gdk-pixbuf-2.24.0/configure.ac
+===================================================================
+diff -uNr gdk-pixbuf-2.24.0/configure.ac gdk-pixbuf-2.24.0.mod/configure.ac
+--- gdk-pixbuf-2.24.0/configure.ac	2011-08-27 11:27:52.000000000 +0800
++++ gdk-pixbuf-2.24.0.mod/configure.ac	2012-02-28 14:48:36.481126410 +0800
+@@ -147,7 +147,6 @@
+ AC_SYS_LARGEFILE
+ 
+ AM_PROG_AS
+-AC_PATH_PROG(NM, nm, nm)
+ 
+ AC_MSG_CHECKING([for some Win32 platform])
+ AS_CASE(["$host"],
diff --git a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.0.bb b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.0.bb
index 121babd..d75bf2a 100644
--- a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.0.bb
+++ b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.0.bb
@@ -11,6 +11,7 @@  SECTION = "libs"
 DEPENDS = "libpng glib-2.0 jpeg"
 
 SRC_URI = "http://ftp.acc.umu.se/pub/GNOME/sources/gdk-pixbuf/2.24/gdk-pixbuf-${PV}.tar.bz2 \
+           file://configure_nm.patch \
            file://hardcoded_libtool.patch \
            file://configure_fix.patch \
            "
@@ -18,7 +19,7 @@  SRC_URI = "http://ftp.acc.umu.se/pub/GNOME/sources/gdk-pixbuf/2.24/gdk-pixbuf-${
 SRC_URI[md5sum] = "d8ece3a4ade4a91c768328620e473ab8"
 SRC_URI[sha256sum] = "38d2630314e6d91976bffd833236f84fefa440a9038f86dc422820a39f2e3700"
 
-PR = "r4"
+PR = "r5"
 
 inherit autotools pkgconfig gettext