Patchwork mtd-utils: Don't use host 'ranlib' or 'ar'.

login
register
mail settings
Submitter James Limbouris
Date Feb. 28, 2012, 3:49 a.m.
Message ID <1330400946-22941-1-git-send-email-james@digitalmatter.com.au>
Download mbox | patch
Permalink /patch/22205/
State Accepted
Commit b8231237c6878599833c9bbaef7b68060fcbe935
Headers show

Comments

James Limbouris - Feb. 28, 2012, 3:49 a.m.
If ranlib, ar, or cc are not supplied to make, it attempts to use ${CROSS}xxx.
Since ${CROSS} is not set, host ranlib may run, producing an unusable .a file on some platforms.

Signed-off-by: James Limbouris <james@digitalmatter.com.au>
---
 meta/recipes-devtools/mtd/mtd-utils_1.4.9.bb |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Saul Wold - Feb. 28, 2012, 6:46 p.m.
On 02/27/2012 07:49 PM, James Limbouris wrote:
> If ranlib, ar, or cc are not supplied to make, it attempts to use ${CROSS}xxx.
> Since ${CROSS} is not set, host ranlib may run, producing an unusable .a file on some platforms.
>
> Signed-off-by: James Limbouris<james@digitalmatter.com.au>
> ---
>   meta/recipes-devtools/mtd/mtd-utils_1.4.9.bb |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-devtools/mtd/mtd-utils_1.4.9.bb b/meta/recipes-devtools/mtd/mtd-utils_1.4.9.bb
> index 519472c..4228b51 100644
> --- a/meta/recipes-devtools/mtd/mtd-utils_1.4.9.bb
> +++ b/meta/recipes-devtools/mtd/mtd-utils_1.4.9.bb
> @@ -11,9 +11,9 @@ SRC_URI = "git://git.infradead.org/mtd-utils.git;protocol=git;tag=995cfe51b0a3cf
>
>   S = "${WORKDIR}/git/"
>
> -PR = "r0"
> +PR = "r1"
>
> -EXTRA_OEMAKE = "'CC=${CC}' 'CFLAGS=${CFLAGS} -I${S}/include -DWITHOUT_XATTR' 'BUILDDIR=${S}'"
> +EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} -I${S}/include -DWITHOUT_XATTR' 'BUILDDIR=${S}'"
>
>   do_install () {
>   	oe_runmake install DESTDIR=${D} SBINDIR=${sbindir} MANDIR=${mandir} INCLUDEDIR=${includedir}

Merged into OE-core

Thanks
	Sau!

Patch

diff --git a/meta/recipes-devtools/mtd/mtd-utils_1.4.9.bb b/meta/recipes-devtools/mtd/mtd-utils_1.4.9.bb
index 519472c..4228b51 100644
--- a/meta/recipes-devtools/mtd/mtd-utils_1.4.9.bb
+++ b/meta/recipes-devtools/mtd/mtd-utils_1.4.9.bb
@@ -11,9 +11,9 @@  SRC_URI = "git://git.infradead.org/mtd-utils.git;protocol=git;tag=995cfe51b0a3cf
 
 S = "${WORKDIR}/git/"
 
-PR = "r0"
+PR = "r1"
 
-EXTRA_OEMAKE = "'CC=${CC}' 'CFLAGS=${CFLAGS} -I${S}/include -DWITHOUT_XATTR' 'BUILDDIR=${S}'"
+EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} -I${S}/include -DWITHOUT_XATTR' 'BUILDDIR=${S}'"
 
 do_install () {
 	oe_runmake install DESTDIR=${D} SBINDIR=${sbindir} MANDIR=${mandir} INCLUDEDIR=${includedir}