| Submitter | Matthew McClintock |
|---|---|
| Date | Feb. 27, 2012, 7:38 p.m. |
| Message ID | <1330371531-28803-3-git-send-email-msm@freescale.com> |
| Download | mbox | patch |
| Permalink | /patch/22187/ |
| State | New |
| Headers | show |
Comments
On Mon, Feb 27, 2012 at 1:38 PM, Matthew McClintock <msm@freescale.com> wrote: > We can use the default value for TUNE_PKGARCH, and now we just > append "-nf" if no float is the build target > > Signed-off-by: Matthew McClintock <msm@freescale.com> > --- > meta/conf/machine/include/powerpc/arch-powerpc.inc | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/meta/conf/machine/include/powerpc/arch-powerpc.inc b/meta/conf/machine/include/powerpc/arch-powerpc.inc > index c9b2829..350f9a9 100644 > --- a/meta/conf/machine/include/powerpc/arch-powerpc.inc > +++ b/meta/conf/machine/include/powerpc/arch-powerpc.inc > @@ -20,8 +20,7 @@ ABIEXTENSION = "${@['','spe'][d.getVar('TARGET_FPU', True) in ['ppc-efd', 'ppc-e > > PPCPKGSFX_FPU = "${@bb.utils.contains("TUNE_FEATURES", "fpu-hard" , "", "-nf", d)}" This bit above needs to change too.. we need to reverse the logic: -PPCPKGSFX_FPU = "${@bb.utils.contains("TUNE_FEATURES", "fpu-hard" , "", "-nf", d)}" +PPCPKGSFX_FPU = "${@bb.utils.contains("TUNE_FEATURES", "fpu-soft" , "-nf", "", d)}" So for parts with an SPE which define ppc-efd and ppc-efs we don't get the '-nf' appended (the part this patch adds just below) -M > -PPCPKGARCH = "${TUNE_ARCH}${PPCPKGSFX_FPU}" > -TUNE_PKGARCH ?= "${PPCPKGARCH}" > +TUNE_PKGARCH_append = "${PPCPKGSFX_FPU}" > > # Basic tune definitions > AVAILTUNES += "powerpc powerpc-nf"
On Mon, Feb 27, 2012 at 3:41 PM, Matthew McClintock <msm@freescale.com> wrote: > On Mon, Feb 27, 2012 at 1:38 PM, Matthew McClintock <msm@freescale.com> wrote: >> We can use the default value for TUNE_PKGARCH, and now we just >> append "-nf" if no float is the build target >> >> Signed-off-by: Matthew McClintock <msm@freescale.com> >> --- >> meta/conf/machine/include/powerpc/arch-powerpc.inc | 3 +-- >> 1 files changed, 1 insertions(+), 2 deletions(-) >> >> diff --git a/meta/conf/machine/include/powerpc/arch-powerpc.inc b/meta/conf/machine/include/powerpc/arch-powerpc.inc >> index c9b2829..350f9a9 100644 >> --- a/meta/conf/machine/include/powerpc/arch-powerpc.inc >> +++ b/meta/conf/machine/include/powerpc/arch-powerpc.inc >> @@ -20,8 +20,7 @@ ABIEXTENSION = "${@['','spe'][d.getVar('TARGET_FPU', True) in ['ppc-efd', 'ppc-e >> >> PPCPKGSFX_FPU = "${@bb.utils.contains("TUNE_FEATURES", "fpu-hard" , "", "-nf", d)}" > > This bit above needs to change too.. we need to reverse the logic: > > -PPCPKGSFX_FPU = "${@bb.utils.contains("TUNE_FEATURES", "fpu-hard" , > "", "-nf", d)}" > +PPCPKGSFX_FPU = "${@bb.utils.contains("TUNE_FEATURES", "fpu-soft" , > "-nf", "", d)}" > > So for parts with an SPE which define ppc-efd and ppc-efs we don't get > the '-nf' appended (the part this patch adds just below) Or perhaps after finding some python/bitbake foo: PPCPKGSFX_FPU = "${@['', '-nf', '', '-gnuspe'][bb.data.getVar('TARGET_FPU',d,1) in ['fpu-hard', 'fpu-soft', 'ppc-efs', 'ppc-efd']]}" -M
Patch
diff --git a/meta/conf/machine/include/powerpc/arch-powerpc.inc b/meta/conf/machine/include/powerpc/arch-powerpc.inc index c9b2829..350f9a9 100644 --- a/meta/conf/machine/include/powerpc/arch-powerpc.inc +++ b/meta/conf/machine/include/powerpc/arch-powerpc.inc @@ -20,8 +20,7 @@ ABIEXTENSION = "${@['','spe'][d.getVar('TARGET_FPU', True) in ['ppc-efd', 'ppc-e PPCPKGSFX_FPU = "${@bb.utils.contains("TUNE_FEATURES", "fpu-hard" , "", "-nf", d)}" -PPCPKGARCH = "${TUNE_ARCH}${PPCPKGSFX_FPU}" -TUNE_PKGARCH ?= "${PPCPKGARCH}" +TUNE_PKGARCH_append = "${PPCPKGSFX_FPU}" # Basic tune definitions AVAILTUNES += "powerpc powerpc-nf"
We can use the default value for TUNE_PKGARCH, and now we just append "-nf" if no float is the build target Signed-off-by: Matthew McClintock <msm@freescale.com> --- meta/conf/machine/include/powerpc/arch-powerpc.inc | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)