Patchwork [bitbake-devel,0/3] V5 Disk space monitoring

login
mail settings
Submitter Robert Yang
Date Feb. 26, 2012, 8:48 a.m.
Message ID <cover.1330245845.git.liezhi.yang@windriver.com>
Download mbox
Permalink /patch/22077/
State New
Headers show

Pull-request

git://git.pokylinux.org/poky-contrib robert/disk-space-monitor

Comments

Robert Yang - Feb. 26, 2012, 8:48 a.m.
Hi Richard,

Thank you very much for your detailed review, here is V5,
please take your review.

Changes:

* Add the patch "Fix finish_now when no running task" which is from you.

* Change the code as you suggested.

* Change the default disk interval value from "10M,50" to "50M,5K",
  this seems a reasonable value during the testing(not too many or
  few warnings).

* Add more explanations in local.conf.sample

// Robert

The following changes since commit 2ff96d664e8e003f64de42187fce9ad0f9646070:

  crumbs: add back progress implementation for depexp (2012-02-25 11:55:45 +0000)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib robert/disk-space-monitor
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/disk-space-monitor

Robert Yang (3):
  Fix finish_now when no running task
  Disk space monitoring
  Add config sample for disk space monitoring

 bitbake/lib/bb/monitordisk.py     |  237 +++++++++++++++++++++++++++++++++++++
 bitbake/lib/bb/runqueue.py        |   14 ++
 meta-yocto/conf/local.conf.sample |   33 +++++
 3 files changed, 284 insertions(+), 0 deletions(-)
 create mode 100644 bitbake/lib/bb/monitordisk.py
Richard Purdie - Feb. 26, 2012, 11:08 a.m.
On Sun, 2012-02-26 at 16:48 +0800, Robert Yang wrote:
> Hi Richard,
> 
> Thank you very much for your detailed review, here is V5,
> please take your review.
> 
> Changes:
> 
> * Add the patch "Fix finish_now when no running task" which is from you.
> 
> * Change the code as you suggested.
> 
> * Change the default disk interval value from "10M,50" to "50M,5K",
>   this seems a reasonable value during the testing(not too many or
>   few warnings).
> 
> * Add more explanations in local.conf.sample
> 
> // Robert
> 
> The following changes since commit 2ff96d664e8e003f64de42187fce9ad0f9646070:
> 
>   crumbs: add back progress implementation for depexp (2012-02-25 11:55:45 +0000)
> 
> are available in the git repository at:
>   git://git.pokylinux.org/poky-contrib robert/disk-space-monitor
>   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/disk-space-monitor
> 
> Robert Yang (3):
>   Fix finish_now when no running task
>   Disk space monitoring
>   Add config sample for disk space monitoring

Merged to master, thanks. I applied the config sample to
local.conf.sample.extended though.

Cheers,

Richard