Patchwork starling: change `gst-plugin-ivorbis` to `gst-plugin-ivorbisdec` in `RRECOMMENDS_${PN}`

login
register
mail settings
Submitter Paul Menzel
Date April 13, 2011, 3:12 p.m.
Message ID <1302707555.4031.27.camel@mattotaupa>
Download mbox | patch
Permalink /patch/2203/
State Accepted
Commit e33263f864fe4a729200af3c82d4edcdbb259a79
Headers show

Comments

Paul Menzel - April 13, 2011, 3:12 p.m.
Date: Wed, 13 Apr 2011 09:21:16 +0200

With commit e6d170ab [1]

        commit e6d170abad28fcd0e3b8ba831705bed23e3309a4
        Author: Martin Jansa <martin.jansa@gmail.com>
        Date:   Thu Apr 7 00:12:22 2011 +0000
        
            gst-plugins: define disjunctive PACKAGES_DYNAMIC for each pack base/good/bad/ugly

`bitbake starling` fails with the following error message.

        ERROR: Nothing RPROVIDES 'gst-plugin-ivorbis' (but /oe/openembedded/recipes/starling/starling_0.9.bb

The GStreamer recipe creates only a plugin named `gst-plugin-ivorbisdec` which is the same as `gst-plugin-ivorbis`.

        gst-plugins-base-0.10.32$ ./configure --help
        […]
          --disable-ivorbis            disable integer vorbis plug-in: ivorbisdec
        […]

This patch is tested using the following configuration.

	Build Configuration:
	BB_VERSION        = "1.12.0"
	METADATA_BRANCH   = "master"
	METADATA_REVISION = "0779626"
	TARGET_ARCH       = "arm"
	TARGET_OS         = "linux-uclibceabi"
	MACHINE           = "beagleboard"
	DISTRO            = "minimal-uclibc"
	DISTRO_VERSION    = "dev-snapshot-20110413"
	TARGET_FPU        = "hard"

[1] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=e6d170abad28fcd0e3b8ba831705bed23e3309a4

Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
---
1. I do not know if the PR bump is needed.
2. I have still no clue why it worked before that change and how `gst-plugin-ivorbis` was created.
---
 recipes/starling/starling_0.9.bb |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Martin Jansa - April 15, 2011, 6:04 a.m.
On Wed, Apr 13, 2011 at 05:12:35PM +0200, Paul Menzel wrote:
> Date: Wed, 13 Apr 2011 09:21:16 +0200
> 
> With commit e6d170ab [1]
> 
>         commit e6d170abad28fcd0e3b8ba831705bed23e3309a4
>         Author: Martin Jansa <martin.jansa@gmail.com>
>         Date:   Thu Apr 7 00:12:22 2011 +0000
>         
>             gst-plugins: define disjunctive PACKAGES_DYNAMIC for each pack base/good/bad/ugly
> 
> `bitbake starling` fails with the following error message.
> 
>         ERROR: Nothing RPROVIDES 'gst-plugin-ivorbis' (but /oe/openembedded/recipes/starling/starling_0.9.bb
> 
> The GStreamer recipe creates only a plugin named `gst-plugin-ivorbisdec` which is the same as `gst-plugin-ivorbis`.
> 
>         gst-plugins-base-0.10.32$ ./configure --help
>         […]
>           --disable-ivorbis            disable integer vorbis plug-in: ivorbisdec
>         […]
> 
> This patch is tested using the following configuration.
> 
> 	Build Configuration:
> 	BB_VERSION        = "1.12.0"
> 	METADATA_BRANCH   = "master"
> 	METADATA_REVISION = "0779626"
> 	TARGET_ARCH       = "arm"
> 	TARGET_OS         = "linux-uclibceabi"
> 	MACHINE           = "beagleboard"
> 	DISTRO            = "minimal-uclibc"
> 	DISTRO_VERSION    = "dev-snapshot-20110413"
> 	TARGET_FPU        = "hard"
> 
> [1] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=e6d170abad28fcd0e3b8ba831705bed23e3309a4
> 
> Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>

Acked-by: Martin Jansa <Martin.Jansa@gmail.com>

> ---
> 1. I do not know if the PR bump is needed.
> 2. I have still no clue why it worked before that change and how `gst-plugin-ivorbis` was created.
> ---
>  recipes/starling/starling_0.9.bb |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/recipes/starling/starling_0.9.bb b/recipes/starling/starling_0.9.bb
> index 859bf6b..5a9c676 100644
> --- a/recipes/starling/starling_0.9.bb
> +++ b/recipes/starling/starling_0.9.bb
> @@ -3,7 +3,7 @@ SECTION = "gpe/multimedia"
>  PRIORITY = "optional"
>  LICENSE = "GPL"
>  DEPENDS = "gtk+ gstreamer gst-plugins-good gst-plugins-bad ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'gst-plugins-ugly', d)} esound sqlite libsoup libhandoff"
> -PR = "r2"
> +PR = "r3"
>  
>  inherit gpe autotools
>  
> @@ -20,7 +20,7 @@ RDEPENDS_${PN} = "\
>  RRECOMMENDS_${PN} = "\
>    gst-plugin-mad \
>    gst-plugin-modplug \
> -  gst-plugin-ivorbis \
> +  gst-plugin-ivorbisdec \
>    gst-plugin-tcp \
>  "
>  
> -- 
> 1.7.4.1



> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Patch

diff --git a/recipes/starling/starling_0.9.bb b/recipes/starling/starling_0.9.bb
index 859bf6b..5a9c676 100644
--- a/recipes/starling/starling_0.9.bb
+++ b/recipes/starling/starling_0.9.bb
@@ -3,7 +3,7 @@  SECTION = "gpe/multimedia"
 PRIORITY = "optional"
 LICENSE = "GPL"
 DEPENDS = "gtk+ gstreamer gst-plugins-good gst-plugins-bad ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'gst-plugins-ugly', d)} esound sqlite libsoup libhandoff"
-PR = "r2"
+PR = "r3"
 
 inherit gpe autotools
 
@@ -20,7 +20,7 @@  RDEPENDS_${PN} = "\
 RRECOMMENDS_${PN} = "\
   gst-plugin-mad \
   gst-plugin-modplug \
-  gst-plugin-ivorbis \
+  gst-plugin-ivorbisdec \
   gst-plugin-tcp \
 "