Patchwork [04/16] libusb-compat: Address unpackaged files warning

login
register
mail settings
Submitter Richard Purdie
Date Feb. 23, 2012, 1:38 p.m.
Message ID <32a9dc576917167f6c2392c822abf54fba58eaf2.1330004039.git.richard.purdie@linuxfoundation.org>
Download mbox | patch
Permalink /patch/21739/
State Accepted
Commit 019747e5fe834092731cdb2987d9c6e1f7fd1cc1
Headers show

Comments

Richard Purdie - Feb. 23, 2012, 1:38 p.m.
WARNING: For recipe libusb-compat, the following files/directories were installed but not shipped in any package:
WARNING:   /lib/libusb.la

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/recipes-support/libusb/libusb-compat_0.1.3.bb |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Otavio Salvador - Feb. 23, 2012, 2:53 p.m.
On Thu, Feb 23, 2012 at 11:38, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> WARNING: For recipe libusb-compat, the following files/directories were installed but not shipped in any package:
> WARNING:   /lib/libusb.la

Why not drop it?
Richard Purdie - Feb. 24, 2012, 12:13 a.m.
On Thu, 2012-02-23 at 12:53 -0200, Otavio Salvador wrote:
> On Thu, Feb 23, 2012 at 11:38, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > WARNING: For recipe libusb-compat, the following files/directories were installed but not shipped in any package:
> > WARNING:   /lib/libusb.la
> 
> Why not drop it?

I want to be consistent. We currently package the .la files. We've also
recently witnessed what can happen when they're removed...

Cheers,

Richard

Patch

diff --git a/meta/recipes-support/libusb/libusb-compat_0.1.3.bb b/meta/recipes-support/libusb/libusb-compat_0.1.3.bb
index 1595a29..43da5af 100644
--- a/meta/recipes-support/libusb/libusb-compat_0.1.3.bb
+++ b/meta/recipes-support/libusb/libusb-compat_0.1.3.bb
@@ -15,7 +15,7 @@  DEPENDS = "libusb1"
 PROVIDES = "libusb"
 
 PE = "1"
-PR = "r3"
+PR = "r4"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-compat-${PV}.tar.bz2 \
            file://0.1.0-beta1-gcc3.4-fix.patch"
@@ -34,4 +34,4 @@  do_install_append() {
 	fi
 }
 
-FILES_${PN}-dev += "${base_libdir}/*.so"
+FILES_${PN}-dev += "${base_libdir}/*.so ${base_libdir}/*.la"