Patchwork [2/7] bitbake.conf: use weak assignment for BB_CONSOLELOG

login
register
mail settings
Submitter Martin Jansa
Date Feb. 23, 2012, 10:43 a.m.
Message ID <9ea9d5b7ab46d2c4ea8c0b18d24a341b54248011.1329993620.git.Martin.Jansa@gmail.com>
Download mbox | patch
Permalink /patch/21625/
State Accepted
Commit d3a06178202c65ce52ea8ad7af5b72ed5c0881d4
Headers show

Comments

Martin Jansa - Feb. 23, 2012, 10:43 a.m.
* some people prefer subdirectory like /cooker/.log

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta/conf/bitbake.conf |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Richard Purdie - Feb. 24, 2012, 12:40 a.m.
On Thu, 2012-02-23 at 11:43 +0100, Martin Jansa wrote:
> * some people prefer subdirectory like /cooker/.log

I think we should probably change that to the default actually...

Cheers,

Richard

> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  meta/conf/bitbake.conf |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 90e5f7a..869b409 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -723,7 +723,8 @@ DISTRO[unexport] = "1"
>  # Used by canadian-cross to handle string conversions on TARGET_ARCH where needed
>  TRANSLATED_TARGET_ARCH ??= "${@d.getVar('TARGET_ARCH', True).replace("_", "-")}"
>  
> -BB_CONSOLELOG = "${TMPDIR}/cooker.log.${DATETIME}"
> +# Complete output from bitbake, if you're changing it, make sure to use existing directory
> +BB_CONSOLELOG ?= "${TMPDIR}/cooker.log.${DATETIME}"
>  
>  # Setup our default hash policy
>  BB_SIGNATURE_HANDLER ?= "OEBasic"
Martin Jansa - Feb. 24, 2012, 12:47 a.m.
On Fri, Feb 24, 2012 at 12:40:07AM +0000, Richard Purdie wrote:
> On Thu, 2012-02-23 at 11:43 +0100, Martin Jansa wrote:
> > * some people prefer subdirectory like /cooker/.log
> 
> I think we should probably change that to the default actually...

But that would need to implement that directory creation if it doesn't
exist. (I have to create it manually for each build from scratch). And
because it's in bitbake then we can make this default only after
increasing required bitbake version (which we should anyway for latest
sstate changes..).

Cheers,

> Cheers,
> 
> Richard
> 
> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > ---
> >  meta/conf/bitbake.conf |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> > 
> > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> > index 90e5f7a..869b409 100644
> > --- a/meta/conf/bitbake.conf
> > +++ b/meta/conf/bitbake.conf
> > @@ -723,7 +723,8 @@ DISTRO[unexport] = "1"
> >  # Used by canadian-cross to handle string conversions on TARGET_ARCH where needed
> >  TRANSLATED_TARGET_ARCH ??= "${@d.getVar('TARGET_ARCH', True).replace("_", "-")}"
> >  
> > -BB_CONSOLELOG = "${TMPDIR}/cooker.log.${DATETIME}"
> > +# Complete output from bitbake, if you're changing it, make sure to use existing directory
> > +BB_CONSOLELOG ?= "${TMPDIR}/cooker.log.${DATETIME}"
> >  
> >  # Setup our default hash policy
> >  BB_SIGNATURE_HANDLER ?= "OEBasic"
> 
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 90e5f7a..869b409 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -723,7 +723,8 @@  DISTRO[unexport] = "1"
 # Used by canadian-cross to handle string conversions on TARGET_ARCH where needed
 TRANSLATED_TARGET_ARCH ??= "${@d.getVar('TARGET_ARCH', True).replace("_", "-")}"
 
-BB_CONSOLELOG = "${TMPDIR}/cooker.log.${DATETIME}"
+# Complete output from bitbake, if you're changing it, make sure to use existing directory
+BB_CONSOLELOG ?= "${TMPDIR}/cooker.log.${DATETIME}"
 
 # Setup our default hash policy
 BB_SIGNATURE_HANDLER ?= "OEBasic"