From patchwork Fri Mar 17 22:42:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Sakoman X-Patchwork-Id: 21169 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 310ABC7619A for ; Fri, 17 Mar 2023 22:43:19 +0000 (UTC) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mx.groups.io with SMTP id smtpd.web10.456.1679092993906425052 for ; Fri, 17 Mar 2023 15:43:13 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@sakoman-com.20210112.gappssmtp.com header.s=20210112 header.b=8Kn04ARb; spf=softfail (domain: sakoman.com, ip: 209.85.214.180, mailfrom: steve@sakoman.com) Received: by mail-pl1-f180.google.com with SMTP id h8so6804481plf.10 for ; Fri, 17 Mar 2023 15:43:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakoman-com.20210112.gappssmtp.com; s=20210112; t=1679092993; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=GBb+6kiTDi9AqINTl6VXGr8O1iipEyt/3xUAqiDcOl4=; b=8Kn04ARbFilffOuPql9xsYMoVFkQZ5TWjbMLUBud/XgWKaFP6ZjkPJlk7LB1gmjD7m wLz1Ml37TYE71XK96gX63LOgQIt/cBRMtBtrZP7qy1zJSjSQi3AL+YKuZqEimMKq/lcI JxWTYr15YCGVqXrrc0lxVZfweg/VDPDfBh7CXdrMjFB74DKw/1KdXS29XsgZjrLQFeSD NLWOfKX0kbpEvvusvTfgnTMplYLTh696pT1bLruad7yG2Wdtew2JYUX3l77pTvAs9Hpk tzbjtWbEF0HTIuODXWoYhNG6GvOLXlgDbMzU9VUi/yymro4K6IeocIJlO7hkXffDPDqA 9W/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679092993; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GBb+6kiTDi9AqINTl6VXGr8O1iipEyt/3xUAqiDcOl4=; b=RIxpSWcBUqlisx8olc7CxSuMp/H4+5NRV5XqC+HdekkWjI5qJau987iR3daSXRr85Q txi6OoqyAxUldQi4XL8B5TThmM2W4pt59EVJtGdxOjcq00KicRkXgJ1vgNymIlaNtG+f nV1ZQi1g9SSoqSZfy6WZEx0iuiSZAx1inx1vyHhHVhZGdCXBvz50HSvkAgA1+eGH/K5J Iosj5ekHJr1YNVPxigo3ZzbcWlxIQ9x/1sXdhqAbSuxf/0ZlRFY2Cvua1N8sxwMGjzZB dIKfy0ZWh4IHW61jYfOJMs8kTo4vGXF0CCS9PfPND5Pa4exsVRyyNdqI+b30DiOCwvfW 7Usg== X-Gm-Message-State: AO0yUKX0z4X0eQgD7NWtBydbcV9H5ojp78CW67EF+zgEcFKuLmD2E3tg T4k6wPKE7ndYcMFNENeFgsn4GkkPkwpVAI5Pht8= X-Google-Smtp-Source: AK7set9D/BR2Z+ukA9WX6QWGvTT5iOrlF0MYzGqX+/pAkq5QIixOVeH+MHoYc4X+WppDxXiwhSbkuA== X-Received: by 2002:a17:902:fa0d:b0:1a1:7bd7:cbfa with SMTP id la13-20020a170902fa0d00b001a17bd7cbfamr8269678plb.13.1679092993004; Fri, 17 Mar 2023 15:43:13 -0700 (PDT) Received: from hexa.router0800d9.com (dhcp-72-253-4-112.hawaiiantel.net. [72.253.4.112]) by smtp.gmail.com with ESMTPSA id jb13-20020a170903258d00b001a19040435bsm2027152plb.100.2023.03.17.15.43.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Mar 2023 15:43:12 -0700 (PDT) From: Steve Sakoman To: openembedded-core@lists.openembedded.org Subject: [OE-core][kirkstone 17/21] buildtools-tarball: Handle spaces within user $PATH Date: Fri, 17 Mar 2023 12:42:31 -1000 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 17 Mar 2023 22:43:19 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/178778 From: Kenfe-Mickael Laventure The environment-setup script generated by the recipe was not quoting the user existing PATH when updating it causing the export command to fail. Add necessary double quotes around $PATH. Signed-off-by: Kenfe-Mickael Laventure Signed-off-by: Alexandre Belloni (cherry picked from commit 2d4c032bf3187aaa953a0c33a999074e695f54bb) Signed-off-by: Steve Sakoman --- meta/recipes-core/meta/buildtools-tarball.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-core/meta/buildtools-tarball.bb b/meta/recipes-core/meta/buildtools-tarball.bb index 34f7773398..70d740b4e0 100644 --- a/meta/recipes-core/meta/buildtools-tarball.bb +++ b/meta/recipes-core/meta/buildtools-tarball.bb @@ -67,7 +67,7 @@ create_sdk_files:append () { # Generate new (mini) sdk-environment-setup file script=${1:-${SDK_OUTPUT}/${SDKPATH}/environment-setup-${SDK_SYS}} touch $script - echo 'export PATH=${SDKPATHNATIVE}${bindir_nativesdk}:${SDKPATHNATIVE}${sbindir_nativesdk}:${SDKPATHNATIVE}${base_bindir_nativesdk}:${SDKPATHNATIVE}${base_sbindir_nativesdk}:$PATH' >> $script + echo 'export PATH="${SDKPATHNATIVE}${bindir_nativesdk}:${SDKPATHNATIVE}${sbindir_nativesdk}:${SDKPATHNATIVE}${base_bindir_nativesdk}:${SDKPATHNATIVE}${base_sbindir_nativesdk}:$PATH"' >> $script echo 'export OECORE_NATIVE_SYSROOT="${SDKPATHNATIVE}"' >> $script if [ -e "${SDK_OUTPUT}${SDKPATHNATIVE}${sysconfdir}/ssl/certs/ca-certificates.crt" ]; then echo 'export GIT_SSL_CAINFO="${SDKPATHNATIVE}${sysconfdir}/ssl/certs/ca-certificates.crt"' >>$script