From patchwork Thu Mar 16 21:45:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Sakoman X-Patchwork-Id: 21107 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4700BC7619A for ; Thu, 16 Mar 2023 21:46:04 +0000 (UTC) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mx.groups.io with SMTP id smtpd.web11.5094.1679003162416572699 for ; Thu, 16 Mar 2023 14:46:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@sakoman-com.20210112.gappssmtp.com header.s=20210112 header.b=iiJooQPP; spf=softfail (domain: sakoman.com, ip: 209.85.214.179, mailfrom: steve@sakoman.com) Received: by mail-pl1-f179.google.com with SMTP id i5so3269006pla.2 for ; Thu, 16 Mar 2023 14:46:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakoman-com.20210112.gappssmtp.com; s=20210112; t=1679003161; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=GBb+6kiTDi9AqINTl6VXGr8O1iipEyt/3xUAqiDcOl4=; b=iiJooQPPsHuL0VpdB3JipyONqC5XtTHKEqZpUZZrUwqJaDTD6H3j4aKYn09CtR8bhb mIzgbS/2kOWIEMlhZDKuJPIGmFo1TTqezXnynB67l9tMgxVCDX/n+N1RfDr6XuDK3t25 vbM/4NpMtJZJRL3OI7o8bBRzah+SpAROQKk+Kyu3CrgiCemRtfPgAzcm2g9rWa6aqb3C yFNCyv84khgmTqXih7X5OMA0AstQrhVzYp4VcisPdbON3MgtcEBlrc/6yXJhUHrCCMLW 8P20VEz23Ks128XKXIaXfjJF30D83wJTh2OT9lG+1hMqcOCmiaQfbfr+WuaTV2Rv+XrH YWww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679003161; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GBb+6kiTDi9AqINTl6VXGr8O1iipEyt/3xUAqiDcOl4=; b=u2Ph994KqntdWEppVSLp6Dyny11gueVFkZiH8Ddrs5XjqUa46qm57/975jlzd15OJd FbsVUZ3AUlzWroXFP5dYs4LBBvV9E+vooeXXQIkXft4TM92JQmqrjdBCABWHdUdMNVYw JpupDv5qpf8B2hivlqedisY6Otn6YwJM1w9Qd19mbyBcb5JRpFsnLi6O5qtfvDuvyb5+ XdpGiUbNF7GZS4FKbGK4pmRZR8wSs6Cmdn9xgdxVfkDOgA39H9ZwGogqILNwtZ00toHz TX9eKVYNvviVPW08wY0Lj2ktvMlVq5v0aGRGXwqLXMk2GrR/qsMx/aBAxw1Rp1YPr3+A zoSw== X-Gm-Message-State: AO0yUKUDBMzQLfDlhalOwyZd688ml+Vlba3SSUyN3yMVHY9t7hkIx5sX sbZ6ngP1t6Dd2Wvwr08zGdggUU2Jv8MvAK0ksg4= X-Google-Smtp-Source: AK7set9tFwH1N+pY6Yda33J7rwZ7DgGjAdNze6GvTqXVd9rJ6xgpRra4y2YS0M93w7SrWodorH5CJw== X-Received: by 2002:a05:6a20:6d21:b0:be:c1b2:514d with SMTP id fv33-20020a056a206d2100b000bec1b2514dmr869298pzb.13.1679003161485; Thu, 16 Mar 2023 14:46:01 -0700 (PDT) Received: from hexa.router0800d9.com (dhcp-72-253-4-112.hawaiiantel.net. [72.253.4.112]) by smtp.gmail.com with ESMTPSA id bn10-20020a056a00324a00b005a84ef49c63sm137746pfb.214.2023.03.16.14.46.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Mar 2023 14:46:01 -0700 (PDT) From: Steve Sakoman To: openembedded-core@lists.openembedded.org Subject: [OE-core][langdale 19/23] buildtools-tarball: Handle spaces within user $PATH Date: Thu, 16 Mar 2023 11:45:16 -1000 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 16 Mar 2023 21:46:04 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/178730 From: Kenfe-Mickael Laventure The environment-setup script generated by the recipe was not quoting the user existing PATH when updating it causing the export command to fail. Add necessary double quotes around $PATH. Signed-off-by: Kenfe-Mickael Laventure Signed-off-by: Alexandre Belloni (cherry picked from commit 2d4c032bf3187aaa953a0c33a999074e695f54bb) Signed-off-by: Steve Sakoman --- meta/recipes-core/meta/buildtools-tarball.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-core/meta/buildtools-tarball.bb b/meta/recipes-core/meta/buildtools-tarball.bb index 34f7773398..70d740b4e0 100644 --- a/meta/recipes-core/meta/buildtools-tarball.bb +++ b/meta/recipes-core/meta/buildtools-tarball.bb @@ -67,7 +67,7 @@ create_sdk_files:append () { # Generate new (mini) sdk-environment-setup file script=${1:-${SDK_OUTPUT}/${SDKPATH}/environment-setup-${SDK_SYS}} touch $script - echo 'export PATH=${SDKPATHNATIVE}${bindir_nativesdk}:${SDKPATHNATIVE}${sbindir_nativesdk}:${SDKPATHNATIVE}${base_bindir_nativesdk}:${SDKPATHNATIVE}${base_sbindir_nativesdk}:$PATH' >> $script + echo 'export PATH="${SDKPATHNATIVE}${bindir_nativesdk}:${SDKPATHNATIVE}${sbindir_nativesdk}:${SDKPATHNATIVE}${base_bindir_nativesdk}:${SDKPATHNATIVE}${base_sbindir_nativesdk}:$PATH"' >> $script echo 'export OECORE_NATIVE_SYSROOT="${SDKPATHNATIVE}"' >> $script if [ -e "${SDK_OUTPUT}${SDKPATHNATIVE}${sysconfdir}/ssl/certs/ca-certificates.crt" ]; then echo 'export GIT_SSL_CAINFO="${SDKPATHNATIVE}${sysconfdir}/ssl/certs/ca-certificates.crt"' >>$script