Patchwork [meta-oe,3/3] polkit: depends on systemd

login
register
mail settings
Submitter Otavio Salvador
Date Feb. 7, 2012, 8:58 p.m.
Message ID <1cd08c798a7b335ba66ed186d6fbd3b4002d2f8a.1328648257.git.otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/20911/
State Accepted
Commit 6f371fa946d094c1b03d98692383aac803ae2fe0
Headers show

Comments

Otavio Salvador - Feb. 7, 2012, 8:58 p.m.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 .../recipes-extended/polkit/polkit_0.104.bbappend  |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
 create mode 100644 meta-oe/recipes-extended/polkit/polkit_0.104.bbappend
Martin Jansa - Feb. 9, 2012, 4 p.m.
On Tue, Feb 07, 2012 at 08:58:24PM +0000, Otavio Salvador wrote:
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>

Can you please change it to something like:

SESSION_EXTRA_DEPENDS = "systemd"
SESSION_EXTRA_OECONF = "--enable-systemd"

DEPENDS += "${SESSION_EXTRA_DEPENDS}"
EXTRA_OECONF += "${SESSION_EXTRA_OECONF}"

PRINC := "${@int(PRINC) + 1}"

So it's clear that systemd will always be enabled and still easy to override
both with .bbappend?

With library split from:
http://lists.linuxtogo.org/pipermail/openembedded-devel/2012-February/037828.html
it won't be so big problem as described here:
http://lists.linuxtogo.org/pipermail/openembedded-devel/2012-January/037597.html
but still better to make it easy to change this in some upper layer

Cheers,

> ---
>  .../recipes-extended/polkit/polkit_0.104.bbappend  |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>  create mode 100644 meta-oe/recipes-extended/polkit/polkit_0.104.bbappend
> 
> diff --git a/meta-oe/recipes-extended/polkit/polkit_0.104.bbappend b/meta-oe/recipes-extended/polkit/polkit_0.104.bbappend
> new file mode 100644
> index 0000000..3c43970
> --- /dev/null
> +++ b/meta-oe/recipes-extended/polkit/polkit_0.104.bbappend
> @@ -0,0 +1,3 @@
> +DEPENDS += "systemd"
> +
> +PRINC = "1"
> -- 
> 1.7.2.5
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Otavio Salvador - Feb. 9, 2012, 4:14 p.m.
On Thu, Feb 9, 2012 at 14:00, Martin Jansa <martin.jansa@gmail.com> wrote:

> So it's clear that systemd will always be enabled and still easy to
> override
> both with .bbappend?
>

For the current state of polkit it might be better to disable systemd on
this, completely. So passing --disable-systemd to autoconf. What do you
think?
Koen Kooi - Feb. 9, 2012, 6:51 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 09-02-12 17:14, Otavio Salvador schreef:
> On Thu, Feb 9, 2012 at 14:00, Martin Jansa <martin.jansa@gmail.com>
> wrote:
> 
>> So it's clear that systemd will always be enabled and still easy to 
>> override both with .bbappend?
>> 
> 
> For the current state of polkit it might be better to disable systemd on 
> this, completely. So passing --disable-systemd to autoconf. What do you 
> think?

Well, systemd is the only backend that actually works in our current
metadata, so I'm hesitant to globally disable it.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (Darwin)
Comment: GPGTools - http://gpgtools.org

iEYEARECAAYFAk80FbEACgkQMkyGM64RGpFyNQCfU0ANmYwoxrK4+J8bzMGr8Wy3
J7sAnil8V8UOxuc+p+8zCXszOB8zhbzp
=/tbB
-----END PGP SIGNATURE-----

Patch

diff --git a/meta-oe/recipes-extended/polkit/polkit_0.104.bbappend b/meta-oe/recipes-extended/polkit/polkit_0.104.bbappend
new file mode 100644
index 0000000..3c43970
--- /dev/null
+++ b/meta-oe/recipes-extended/polkit/polkit_0.104.bbappend
@@ -0,0 +1,3 @@ 
+DEPENDS += "systemd"
+
+PRINC = "1"