Patchwork [meta-xfce,3/3] xfce4-panel: Disable building of static libraries.

login
register
mail settings
Submitter Peter Tworek
Date Feb. 4, 2012, 6:30 p.m.
Message ID <1328380249-11697-4-git-send-email-tworaz666@gmail.com>
Download mbox | patch
Permalink /patch/20697/
State Superseded
Headers show

Comments

Peter Tworek - Feb. 4, 2012, 6:30 p.m.
Current recipe triggers several QA warnings about non -staticdev packages
containing .a files. The offending files are static versions of panel
plugins. They have no actual use. They're just a byproduct. Xfce4-panel
contains only one more library libxfce4-panel. Similary to panel plugins
it's static version is rather useless.

Disabling building of static libs makes -dev package smaller and fixes
all QA warnings.

Run tested on netbook pro.

Signed-off-by: Peter Tworek <tworaz666@gmail.com>
---
 .../recipes-xfce/xfce4-panel/xfce4-panel_4.8.6.bb  |   13 +++++--------
 1 files changed, 5 insertions(+), 8 deletions(-)
Andreas Müller - Feb. 5, 2012, 5 p.m.
On Sat, Feb 4, 2012 at 7:30 PM, Peter Tworek <tworaz666@gmail.com> wrote:
> Current recipe triggers several QA warnings about non -staticdev packages
> containing .a files. The offending files are static versions of panel
> plugins. They have no actual use. They're just a byproduct. Xfce4-panel
> contains only one more library libxfce4-panel. Similary to panel plugins
> it's static version is rather useless.
>
> Disabling building of static libs makes -dev package smaller and fixes
> all QA warnings.
>
> Run tested on netbook pro.
>
> Signed-off-by: Peter Tworek <tworaz666@gmail.com>
> ---
>  .../recipes-xfce/xfce4-panel/xfce4-panel_4.8.6.bb  |   13 +++++--------
>  1 files changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/meta-xfce/recipes-xfce/xfce4-panel/xfce4-panel_4.8.6.bb b/meta-xfce/recipes-xfce/xfce4-panel/xfce4-panel_4.8.6.bb
> index 0cd8eba..937b078 100644
> --- a/meta-xfce/recipes-xfce/xfce4-panel/xfce4-panel_4.8.6.bb
> +++ b/meta-xfce/recipes-xfce/xfce4-panel/xfce4-panel_4.8.6.bb
> @@ -4,15 +4,17 @@ LICENSE = "GPLv2"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=26a8bd75d8f8498bdbbe64a27791d4ee"
>  DEPENDS = "libxfce4util garcon libxfce4ui xfconf exo gtk+ dbus cairo virtual/libx11 libxml2 libwnck"
>
> -PR = "r1"
> +PR = "r2"
>
>  inherit xfce
>
> +EXTRA_OECONF = "--disable-static"
I think hereby you disable static for the whole: panel+plugins. I
would feel better if you simply have

FILES_${PN}-staticdev += "${libdir}/xfce4/panel/plugins/*.*a \

below.
> +
>  python populate_packages_prepend() {
>        plugin_dir = bb.data.expand('${libdir}/xfce4/panel/plugins/', d)
>        plugin_name = bb.data.expand('${PN}-plugin-%s', d)
>        do_split_packages(d, plugin_dir, '^lib(.*).so$', plugin_name,
> -                         '${PN} plugin for %s', extra_depends='', prepend=True,
> +                         '${PN} %s plugin', extra_depends='', prepend=True,
>                          aux_files_pattern=['${datadir}/xfce4/panel/plugins/%s.desktop',
>                                             '${sysconfdir}/xdg/xfce/panel/%s-*',
>                                             '${datadir}/icons/hicolor/48x48/apps/*-%s.png',
> @@ -23,12 +25,7 @@ PACKAGES_DYNAMIC = "${PN}-plugin-*"
>
>  FILES_${PN} += "${libdir}/xfce4/panel/migrate \
>                 ${libdir}/xfce4/panel/wrapper"
> -
> -FILES_${PN}-dbg += "${libdir}/xfce4/panel/plugins/.debug \
> -                  "
> -
> -FILES_${PN}-dev += "${libdir}/xfce4/panel/plugins/*.*a \
> -                   "
> +FILES_${PN}-dbg += "${libdir}/xfce4/panel/plugins/.debug"
>
>  SRC_URI[md5sum] = "9d7bf0503d5867c4044cef04bb5845b1"
>  SRC_URI[sha256sum] = "66f1266a1242ee5ecada995a4a584dd9802aa24456759b40b0c29227c39bed03"
> --
Regards

Andreas
Peter Tworek - Feb. 5, 2012, 5:05 p.m.
On 02/05/2012 06:00 PM, Andreas Müller wrote:
> On Sat, Feb 4, 2012 at 7:30 PM, Peter Tworek<tworaz666@gmail.com>  wrote:
>> Current recipe triggers several QA warnings about non -staticdev packages
>> containing .a files. The offending files are static versions of panel
>> plugins. They have no actual use. They're just a byproduct. Xfce4-panel
>> contains only one more library libxfce4-panel. Similary to panel plugins
>> it's static version is rather useless.
>>
>> Disabling building of static libs makes -dev package smaller and fixes
>> all QA warnings.
>>
>> Run tested on netbook pro.
>>
>> Signed-off-by: Peter Tworek<tworaz666@gmail.com>
>> ---
>>   .../recipes-xfce/xfce4-panel/xfce4-panel_4.8.6.bb  |   13 +++++--------
>>   1 files changed, 5 insertions(+), 8 deletions(-)
>>
>> diff --git a/meta-xfce/recipes-xfce/xfce4-panel/xfce4-panel_4.8.6.bb b/meta-xfce/recipes-xfce/xfce4-panel/xfce4-panel_4.8.6.bb
>> index 0cd8eba..937b078 100644
>> --- a/meta-xfce/recipes-xfce/xfce4-panel/xfce4-panel_4.8.6.bb
>> +++ b/meta-xfce/recipes-xfce/xfce4-panel/xfce4-panel_4.8.6.bb
>> @@ -4,15 +4,17 @@ LICENSE = "GPLv2"
>>   LIC_FILES_CHKSUM = "file://COPYING;md5=26a8bd75d8f8498bdbbe64a27791d4ee"
>>   DEPENDS = "libxfce4util garcon libxfce4ui xfconf exo gtk+ dbus cairo virtual/libx11 libxml2 libwnck"
>>
>> -PR = "r1"
>> +PR = "r2"
>>
>>   inherit xfce
>>
>> +EXTRA_OECONF = "--disable-static"
> I think hereby you disable static for the whole: panel+plugins. I
> would feel better if you simply have
>
> FILES_${PN}-staticdev += "${libdir}/xfce4/panel/plugins/*.*a \

The question is do we really need static version of panel plugins. They 
can't be used for anything, really. Even if you package them, you have 
no way of using those static libs. There are no headers which define 
what functions those libs expose. If you feel bad about 
--disable-static, than how about:
do_install_append () {
find "${D}/${libdir}/xfce4/panel/plugins" -name '*.a' -exec rm -f {} +
}

??

> below.
>> +
>>   python populate_packages_prepend() {
>>         plugin_dir = bb.data.expand('${libdir}/xfce4/panel/plugins/', d)
>>         plugin_name = bb.data.expand('${PN}-plugin-%s', d)
>>         do_split_packages(d, plugin_dir, '^lib(.*).so$', plugin_name,
>> -                         '${PN} plugin for %s', extra_depends='', prepend=True,
>> +                         '${PN} %s plugin', extra_depends='', prepend=True,
>>                           aux_files_pattern=['${datadir}/xfce4/panel/plugins/%s.desktop',
>>                                              '${sysconfdir}/xdg/xfce/panel/%s-*',
>>                                              '${datadir}/icons/hicolor/48x48/apps/*-%s.png',
>> @@ -23,12 +25,7 @@ PACKAGES_DYNAMIC = "${PN}-plugin-*"
>>
>>   FILES_${PN} += "${libdir}/xfce4/panel/migrate \
>>                  ${libdir}/xfce4/panel/wrapper"
>> -
>> -FILES_${PN}-dbg += "${libdir}/xfce4/panel/plugins/.debug \
>> -                  "
>> -
>> -FILES_${PN}-dev += "${libdir}/xfce4/panel/plugins/*.*a \
>> -                   "
>> +FILES_${PN}-dbg += "${libdir}/xfce4/panel/plugins/.debug"
>>
>>   SRC_URI[md5sum] = "9d7bf0503d5867c4044cef04bb5845b1"
>>   SRC_URI[sha256sum] = "66f1266a1242ee5ecada995a4a584dd9802aa24456759b40b0c29227c39bed03"
>> --
> Regards
>
> Andreas
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Patch

diff --git a/meta-xfce/recipes-xfce/xfce4-panel/xfce4-panel_4.8.6.bb b/meta-xfce/recipes-xfce/xfce4-panel/xfce4-panel_4.8.6.bb
index 0cd8eba..937b078 100644
--- a/meta-xfce/recipes-xfce/xfce4-panel/xfce4-panel_4.8.6.bb
+++ b/meta-xfce/recipes-xfce/xfce4-panel/xfce4-panel_4.8.6.bb
@@ -4,15 +4,17 @@  LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=26a8bd75d8f8498bdbbe64a27791d4ee"
 DEPENDS = "libxfce4util garcon libxfce4ui xfconf exo gtk+ dbus cairo virtual/libx11 libxml2 libwnck"
 
-PR = "r1"
+PR = "r2"
 
 inherit xfce
 
+EXTRA_OECONF = "--disable-static"
+
 python populate_packages_prepend() {
 	plugin_dir = bb.data.expand('${libdir}/xfce4/panel/plugins/', d)
 	plugin_name = bb.data.expand('${PN}-plugin-%s', d)
 	do_split_packages(d, plugin_dir, '^lib(.*).so$', plugin_name,
-	                  '${PN} plugin for %s', extra_depends='', prepend=True,
+	                  '${PN} %s plugin', extra_depends='', prepend=True,
 	                  aux_files_pattern=['${datadir}/xfce4/panel/plugins/%s.desktop',
 	                                     '${sysconfdir}/xdg/xfce/panel/%s-*',
 	                                     '${datadir}/icons/hicolor/48x48/apps/*-%s.png',
@@ -23,12 +25,7 @@  PACKAGES_DYNAMIC = "${PN}-plugin-*"
 
 FILES_${PN} += "${libdir}/xfce4/panel/migrate \
                 ${libdir}/xfce4/panel/wrapper"
-
-FILES_${PN}-dbg += "${libdir}/xfce4/panel/plugins/.debug \
-		   "
-
-FILES_${PN}-dev += "${libdir}/xfce4/panel/plugins/*.*a \
-                   "
+FILES_${PN}-dbg += "${libdir}/xfce4/panel/plugins/.debug"
 
 SRC_URI[md5sum] = "9d7bf0503d5867c4044cef04bb5845b1"
 SRC_URI[sha256sum] = "66f1266a1242ee5ecada995a4a584dd9802aa24456759b40b0c29227c39bed03"