Patchwork busybox: Add flock utility to default configuration.

login
register
mail settings
Submitter Peter Tworek
Date Feb. 2, 2012, 8:21 p.m.
Message ID <1328214086-6824-1-git-send-email-tworaz666@gmail.com>
Download mbox | patch
Permalink /patch/20579/
State Accepted
Commit a8ba002b5eb3c2e57550483d7b3ea99f0cc8a9cb
Headers show

Comments

Peter Tworek - Feb. 2, 2012, 8:21 p.m.
Flock is required by by pm-utils package to function properly
(/usr/lib/pm-utils/functions). It's shipped in both busybox and
util-linux. Both versions work fine with pm-utils. Enabling it
in busybox seems like simpliest solution for the problem.

Signed-off-by: Peter Tworek <tworaz666@gmail.com>
---
 meta/recipes-core/busybox/busybox-1.19.3/defconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Paul Menzel - Feb. 3, 2012, 5:46 p.m.
Am Donnerstag, den 02.02.2012, 21:21 +0100 schrieb Peter Tworek:
> Flock is required by by pm-utils package to function properly

One »by« too much.

> (/usr/lib/pm-utils/functions). It's shipped in both busybox and
> util-linux. Both versions work fine with pm-utils. Enabling it
> in busybox seems like simpliest solution for the problem.

simplest

> Signed-off-by: Peter Tworek <tworaz666@gmail.com>
> ---
>  meta/recipes-core/busybox/busybox-1.19.3/defconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-core/busybox/busybox-1.19.3/defconfig b/meta/recipes-core/busybox/busybox-1.19.3/defconfig
> index b474ad4..fa9c078 100644
> --- a/meta/recipes-core/busybox/busybox-1.19.3/defconfig
> +++ b/meta/recipes-core/busybox/busybox-1.19.3/defconfig
> @@ -540,7 +540,7 @@ CONFIG_FEATURE_FDISK_WRITABLE=y
>  # CONFIG_FEATURE_GPT_LABEL is not set
>  # CONFIG_FEATURE_FDISK_ADVANCED is not set
>  # CONFIG_FINDFS is not set
> -# CONFIG_FLOCK is not set
> +CONFIG_FLOCK=y
>  # CONFIG_FREERAMDISK is not set
>  CONFIG_FSCK_MINIX=y
>  # CONFIG_MKFS_EXT2 is not set

People are always interested in the size changes of the package when
such programs are added to the default configuration. Do you have such
numbers?

Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>


Thanks,

Paul
Peter Tworek - Feb. 3, 2012, 11:55 p.m.
On 02/03/2012 06:46 PM, Paul Menzel wrote:
> Am Donnerstag, den 02.02.2012, 21:21 +0100 schrieb Peter Tworek:
>> Flock is required by by pm-utils package to function properly
> One »by« too much.
Fixed in v2, thanks.
>
>> (/usr/lib/pm-utils/functions). It's shipped in both busybox and
>> util-linux. Both versions work fine with pm-utils. Enabling it
>> in busybox seems like simpliest solution for the problem.
> simplest
Thanks, fixed in v2.
>
>> Signed-off-by: Peter Tworek<tworaz666@gmail.com>
>> ---
>>   meta/recipes-core/busybox/busybox-1.19.3/defconfig |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta/recipes-core/busybox/busybox-1.19.3/defconfig b/meta/recipes-core/busybox/busybox-1.19.3/defconfig
>> index b474ad4..fa9c078 100644
>> --- a/meta/recipes-core/busybox/busybox-1.19.3/defconfig
>> +++ b/meta/recipes-core/busybox/busybox-1.19.3/defconfig
>> @@ -540,7 +540,7 @@ CONFIG_FEATURE_FDISK_WRITABLE=y
>>   # CONFIG_FEATURE_GPT_LABEL is not set
>>   # CONFIG_FEATURE_FDISK_ADVANCED is not set
>>   # CONFIG_FINDFS is not set
>> -# CONFIG_FLOCK is not set
>> +CONFIG_FLOCK=y
>>   # CONFIG_FREERAMDISK is not set
>>   CONFIG_FSCK_MINIX=y
>>   # CONFIG_MKFS_EXT2 is not set
> People are always interested in the size changes of the package when
> such programs are added to the default configuration. Do you have such
> numbers?
Added some data to v2. On armv5t it makes busybox binary larger by ~2.8k

>
> Reviewed-by: Paul Menzel<paulepanter@users.sourceforge.net>
>
>
> Thanks,
>
> Paul
Saul Wold - Feb. 8, 2012, 4:02 a.m.
On 02/02/2012 12:21 PM, Peter Tworek wrote:
> Flock is required by by pm-utils package to function properly
> (/usr/lib/pm-utils/functions). It's shipped in both busybox and
> util-linux. Both versions work fine with pm-utils. Enabling it
> in busybox seems like simpliest solution for the problem.
>
> Signed-off-by: Peter Tworek<tworaz666@gmail.com>
> ---
>   meta/recipes-core/busybox/busybox-1.19.3/defconfig |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-core/busybox/busybox-1.19.3/defconfig b/meta/recipes-core/busybox/busybox-1.19.3/defconfig
> index b474ad4..fa9c078 100644
> --- a/meta/recipes-core/busybox/busybox-1.19.3/defconfig
> +++ b/meta/recipes-core/busybox/busybox-1.19.3/defconfig
> @@ -540,7 +540,7 @@ CONFIG_FEATURE_FDISK_WRITABLE=y
>   # CONFIG_FEATURE_GPT_LABEL is not set
>   # CONFIG_FEATURE_FDISK_ADVANCED is not set
>   # CONFIG_FINDFS is not set
> -# CONFIG_FLOCK is not set
> +CONFIG_FLOCK=y
>   # CONFIG_FREERAMDISK is not set
>   CONFIG_FSCK_MINIX=y
>   # CONFIG_MKFS_EXT2 is not set

Merged this one into OE-core, missed the v2 version with updated comment

Sorry and Thanks
	Sau!

Patch

diff --git a/meta/recipes-core/busybox/busybox-1.19.3/defconfig b/meta/recipes-core/busybox/busybox-1.19.3/defconfig
index b474ad4..fa9c078 100644
--- a/meta/recipes-core/busybox/busybox-1.19.3/defconfig
+++ b/meta/recipes-core/busybox/busybox-1.19.3/defconfig
@@ -540,7 +540,7 @@  CONFIG_FEATURE_FDISK_WRITABLE=y
 # CONFIG_FEATURE_GPT_LABEL is not set
 # CONFIG_FEATURE_FDISK_ADVANCED is not set
 # CONFIG_FINDFS is not set
-# CONFIG_FLOCK is not set
+CONFIG_FLOCK=y
 # CONFIG_FREERAMDISK is not set
 CONFIG_FSCK_MINIX=y
 # CONFIG_MKFS_EXT2 is not set