Patchwork [bitbake-devel,1/1] prserv: Do not ping PRService if not required

login
register
mail settings
Submitter Lianhao Lu
Date Jan. 31, 2012, 6:18 a.m.
Message ID <fe0512a8af642c0b23a9fbbb6aa82953b9e17313.1327990542.git.lianhao.lu@intel.com>
Download mbox | patch
Permalink /patch/20425/
State New
Headers show

Comments

Lianhao Lu - Jan. 31, 2012, 6:18 a.m.
[YOCTO #1942]
Ping the PRService only if PRSERV_HOST and PRSERV_PORT are set.

Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
---
 bitbake/lib/prserv/serv.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Khem Raj - Jan. 31, 2012, 3:34 p.m.
On Mon, Jan 30, 2012 at 10:18 PM, Lianhao Lu <lianhao.lu@intel.com> wrote:
> [YOCTO #1942]
> Ping the PRService only if PRSERV_HOST and PRSERV_PORT are set.
>
> Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
> ---
>  bitbake/lib/prserv/serv.py |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/bitbake/lib/prserv/serv.py b/bitbake/lib/prserv/serv.py
> index fa437f9..5567c6f 100644
> --- a/bitbake/lib/prserv/serv.py
> +++ b/bitbake/lib/prserv/serv.py
> @@ -268,7 +268,7 @@ def is_local_special(host, port):
>
>  def auto_start(d):
>     global singleton
> -    if d.getVar('USE_PR_SERV', True) == '0':
> +    if (not d.getVar('PRSERV_HOST', True)) or (not d.getVar('PRSERV_PORT', True)):


should it warn in case when USE_PR_SERV is set but one of PRSERV_HOST
or PRSERV_PORT are unset

>         return True
>
>     if is_local_special(d.getVar('PRSERV_HOST', True), int(d.getVar('PRSERV_PORT', True))) and not singleton:
> --
> 1.7.0.4
>
>
> _______________________________________________
> bitbake-devel mailing list
> bitbake-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/bitbake-devel
Lianhao Lu - Feb. 1, 2012, 1:08 a.m.
Khem Raj wrote on 2012-01-31:
> On Mon, Jan 30, 2012 at 10:18 PM, Lianhao Lu <lianhao.lu@intel.com> wrote:

>> [YOCTO #1942]

>> Ping the PRService only if PRSERV_HOST and PRSERV_PORT are set.

>> 

>> Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>

>> ---

>>  bitbake/lib/prserv/serv.py |    2 +-

>>  1 files changed, 1 insertions(+), 1 deletions(-)

>> 

>> diff --git a/bitbake/lib/prserv/serv.py b/bitbake/lib/prserv/serv.py

>> index fa437f9..5567c6f 100644

>> --- a/bitbake/lib/prserv/serv.py

>> +++ b/bitbake/lib/prserv/serv.py

>> @@ -268,7 +268,7 @@ def is_local_special(host, port):

>> 

>>  def auto_start(d):

>>     global singleton

>> -    if d.getVar('USE_PR_SERV', True) == '0':

>> +    if (not d.getVar('PRSERV_HOST', True)) or (not d.getVar('PRSERV_PORT', True)):

>

> 

> should it warn in case when USE_PR_SERV is set but one of PRSERV_HOST

> or PRSERV_PORT are unset


USE_PR_SERV will also be set if PRSERV_LOCKDOWN is set in the case of release 'lockdown'.

>>         return True

>> 

>>     if is_local_special(d.getVar('PRSERV_HOST', True), int(d.getVar('PRSERV_PORT', True))) and not singleton:

>> --

>> 1.7.0.4

>> 

>> 

>> _______________________________________________

>> bitbake-devel mailing list

>> bitbake-devel@lists.openembedded.org

>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/bitbake-devel

Patch

diff --git a/bitbake/lib/prserv/serv.py b/bitbake/lib/prserv/serv.py
index fa437f9..5567c6f 100644
--- a/bitbake/lib/prserv/serv.py
+++ b/bitbake/lib/prserv/serv.py
@@ -268,7 +268,7 @@  def is_local_special(host, port):
 
 def auto_start(d):
     global singleton
-    if d.getVar('USE_PR_SERV', True) == '0':
+    if (not d.getVar('PRSERV_HOST', True)) or (not d.getVar('PRSERV_PORT', True)):
         return True
 
     if is_local_special(d.getVar('PRSERV_HOST', True), int(d.getVar('PRSERV_PORT', True))) and not singleton: