Patchwork [meta-oe,3/3] pidgin: Add gconf to RDEPENDS for libpurple.

login
register
mail settings
Submitter Peter Tworek
Date Jan. 30, 2012, 7:47 p.m.
Message ID <1327952855-28040-1-git-send-email-tworaz666@gmail.com>
Download mbox | patch
Permalink /patch/20341/
State New, archived
Headers show

Comments

Peter Tworek - Jan. 30, 2012, 7:47 p.m.
Without it postinst script for libpurple fails when gconf is not installed:
//var/lib/opkg/info/libpurple.postinst: line 8: gconftool-2: command not found

Signed-off-by: Peter Tworek <tworaz666@gmail.com>
---
 meta-oe/recipes-support/pidgin/pidgin.inc |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
Koen Kooi - Jan. 30, 2012, 8 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 30-01-12 20:47, Peter Tworek schreef:
> Without it postinst script for libpurple fails when gconf is not
> installed: //var/lib/opkg/info/libpurple.postinst: line 8: gconftool-2:
> command not found

Why is gconf.bbclass failing to do that?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (Darwin)
Comment: GPGTools - http://gpgtools.org

iEYEARECAAYFAk8m9u8ACgkQMkyGM64RGpGRTQCgrzWdMpyRtNE3kO2CKw6b7haa
j5UAoJ2NPDIIlCsRwYOJSTGTWd2i/hj0
=axku
-----END PGP SIGNATURE-----
Peter Tworek - Jan. 30, 2012, 8:28 p.m.
On 01/30/2012 09:00 PM, Koen Kooi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Op 30-01-12 20:47, Peter Tworek schreef:
>> Without it postinst script for libpurple fails when gconf is not
>> installed: //var/lib/opkg/info/libpurple.postinst: line 8: gconftool-2:
>> command not found
> Why is gconf.bbclass failing to do that?
As far as I understand it only adds gconf to DEPENDS. If a package 
contents are not linked with libgconf-2 (libpurple only needs 
gconftool-2) gconf won't be pulled in as a runtime dependency.

> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (Darwin)
> Comment: GPGTools - http://gpgtools.org
>
> iEYEARECAAYFAk8m9u8ACgkQMkyGM64RGpGRTQCgrzWdMpyRtNE3kO2CKw6b7haa
> j5UAoJ2NPDIIlCsRwYOJSTGTWd2i/hj0
> =axku
> -----END PGP SIGNATURE-----
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Koen Kooi - Jan. 31, 2012, 8:06 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 30-01-12 21:28, Peter Tworek schreef:
> On 01/30/2012 09:00 PM, Koen Kooi wrote: Op 30-01-12 20:47, Peter Tworek
> schreef:
>>>> Without it postinst script for libpurple fails when gconf is not 
>>>> installed: //var/lib/opkg/info/libpurple.postinst: line 8:
>>>> gconftool-2: command not found
> Why is gconf.bbclass failing to do that?
>> As far as I understand it only adds gconf to DEPENDS. If a package
>> contents are not linked with libgconf-2 (libpurple only needs
>> gconftool-2) gconf won't be pulled in as a runtime dependency.

That means it's a bug in gconf.bbclass and needs to get fixed there.



-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (Darwin)
Comment: GPGTools - http://gpgtools.org

iEYEARECAAYFAk8noPsACgkQMkyGM64RGpFLWACfQzo9Hq4Ok94Sw1cT+NWWLGaL
OooAn3b5psoVBYh6IzGA162CdHkoGEqA
=1Qot
-----END PGP SIGNATURE-----
McClintock Matthew-B29882 - Jan. 31, 2012, 4:53 p.m.
On Tue, Jan 31, 2012 at 2:06 AM, Koen Kooi <koen@dominion.thruhere.net> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Op 30-01-12 21:28, Peter Tworek schreef:
>> On 01/30/2012 09:00 PM, Koen Kooi wrote: Op 30-01-12 20:47, Peter Tworek
>> schreef:
>>>>> Without it postinst script for libpurple fails when gconf is not
>>>>> installed: //var/lib/opkg/info/libpurple.postinst: line 8:
>>>>> gconftool-2: command not found
>> Why is gconf.bbclass failing to do that?
>>> As far as I understand it only adds gconf to DEPENDS. If a package
>>> contents are not linked with libgconf-2 (libpurple only needs
>>> gconftool-2) gconf won't be pulled in as a runtime dependency.
>
> That means it's a bug in gconf.bbclass and needs to get fixed there.

Really? Do you really want to automatically add gconf deps to the
misc. packages added by a recipe?

-M
Koen Kooi - Jan. 31, 2012, 6:45 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 31-01-12 17:53, McClintock Matthew-B29882 schreef:
> On Tue, Jan 31, 2012 at 2:06 AM, Koen Kooi <koen@dominion.thruhere.net>
> wrote:
>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
>> 
>> Op 30-01-12 21:28, Peter Tworek schreef:
>>> On 01/30/2012 09:00 PM, Koen Kooi wrote: Op 30-01-12 20:47, Peter
>>> Tworek schreef:
>>>>>> Without it postinst script for libpurple fails when gconf is
>>>>>> not installed: //var/lib/opkg/info/libpurple.postinst: line 8: 
>>>>>> gconftool-2: command not found
>>> Why is gconf.bbclass failing to do that?
>>>> As far as I understand it only adds gconf to DEPENDS. If a package 
>>>> contents are not linked with libgconf-2 (libpurple only needs 
>>>> gconftool-2) gconf won't be pulled in as a runtime dependency.
>> 
>> That means it's a bug in gconf.bbclass and needs to get fixed there.
> 
> Really? Do you really want to automatically add gconf deps to the misc.
> packages added by a recipe?

Since it's adding the postinst calls with gconf-tool already, yes. Or do you
like having broken postinsts?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (Darwin)
Comment: GPGTools - http://gpgtools.org

iEYEARECAAYFAk8oNrYACgkQMkyGM64RGpHORQCfbiw/JoEW5byJaWXigd23GNDD
TTIAn2xJ/EgmHT9LMoykyPVLB0DLTEZ7
=hvUv
-----END PGP SIGNATURE-----
Otavio Salvador - Jan. 31, 2012, 7:05 p.m.
On Tue, Jan 31, 2012 at 14:53, McClintock Matthew-B29882 <
B29882@freescale.com> wrote:

> On Tue, Jan 31, 2012 at 2:06 AM, Koen Kooi <koen@dominion.thruhere.net>
> wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > Op 30-01-12 21:28, Peter Tworek schreef:
> >> On 01/30/2012 09:00 PM, Koen Kooi wrote: Op 30-01-12 20:47, Peter Tworek
> >> schreef:
> >>>>> Without it postinst script for libpurple fails when gconf is not
> >>>>> installed: //var/lib/opkg/info/libpurple.postinst: line 8:
> >>>>> gconftool-2: command not found
> >> Why is gconf.bbclass failing to do that?
> >>> As far as I understand it only adds gconf to DEPENDS. If a package
> >>> contents are not linked with libgconf-2 (libpurple only needs
> >>> gconftool-2) gconf won't be pulled in as a runtime dependency.
> >
> > That means it's a bug in gconf.bbclass and needs to get fixed there.
>
> Really? Do you really want to automatically add gconf deps to the
> misc. packages added by a recipe?


If it uses gconf it needs to rdepends on it.

Patch

diff --git a/meta-oe/recipes-support/pidgin/pidgin.inc b/meta-oe/recipes-support/pidgin/pidgin.inc
index 1a35457..305c116 100644
--- a/meta-oe/recipes-support/pidgin/pidgin.inc
+++ b/meta-oe/recipes-support/pidgin/pidgin.inc
@@ -3,7 +3,7 @@  SECTION = "x11/network"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
 DEPENDS = "python startup-notification avahi gtk+ ncurses gnutls virtual/libintl gstreamer dbus"
-INC_PR = "r2"
+INC_PR = "r3"
 
 inherit autotools gettext pkgconfig gconf perlnative
 
@@ -30,6 +30,8 @@  OE_LT_RPATH_ALLOW[export]="1"
 
 PACKAGES =+ "libpurple-dbg libpurple-dev libpurple libgnt-dbg libgnt libgnt-dev finch-dbg finch finch-dev ${PN}-data"
 
+RDEPENDS_libpurple = "gconf"
+
 LEAD_SONAME = "libpurple.so.0"
 FILES_libpurple     = "${libdir}/libpurple*.so.* ${libdir}/purple-2 ${bindir}/purple-* ${sysconfdir}/gconf/schemas/purple* ${datadir}/purple/ca-certs"
 FILES_libpurple-dev = "${libdir}/libpurple*.la \