Patchwork [1/2] alsa-state: fix RDEPENDS assignment

login
register
mail settings
Submitter Koen Kooi
Date Jan. 30, 2012, 4:49 p.m.
Message ID <1327942199-4604-1-git-send-email-koen@dominion.thruhere.net>
Download mbox | patch
Permalink /patch/20325/
State Accepted
Commit 358ad279d525ca3c806cbb6ceadb2d6170468d80
Headers show

Comments

Koen Kooi - Jan. 30, 2012, 4:49 p.m.
Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
---
 meta/recipes-bsp/alsa-state/alsa-state.bb |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
Joshua Lock - Jan. 30, 2012, 6:17 p.m.
On 30/01/12 09:56, Phil Blundell wrote:
> On Mon, 2012-01-30 at 09:50 -0800, Joshua Lock wrote:
>> Yikes, I don't know why I keep making this mistake. Thanks for catching
>> it Koen.
>>
>> I thought we caught this in a QA error but I definitely didn't see it,
>> best investigate.
>
> It seems that Yocto doesn't enable those checks.  Possibly it should, or
> maybe we should just turn them on by default for everybody.

Personally, I feel that this check is useful enough to be turned on by 
default.

Cheers,
Joshua
Saul Wold - Jan. 30, 2012, 8:09 p.m.
On 01/30/2012 10:39 AM, Koen Kooi wrote:
> Op 30 jan. 2012, om 18:50 heeft Joshua Lock het volgende geschreven:
>
>> Yikes, I don't know why I keep making this mistake. Thanks for catching it Koen.
>
> I'm still finding recipes that I wrote that have that mistake :)
>
>> I thought we caught this in a QA error but I definitely didn't see it, best investigate.
>
> it's part of recipe-sanity, which you need to call manually.
>

Time to add that to my checklist!  I have a set of things I am trying to 
remember to do (they don't always get done, but I try) to validate recipes.

Sau!

> regards,
>
> Koen
>
>
>>
>> On 30/01/12 08:49, Koen Kooi wrote:
>>> Signed-off-by: Koen Kooi<koen@dominion.thruhere.net>
>> Signed-off-by: Joshua Lock<josh@linux.intel.com>
>>
>> Joshua
>>
>>> ---
>>>   meta/recipes-bsp/alsa-state/alsa-state.bb |    5 ++---
>>>   1 files changed, 2 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/meta/recipes-bsp/alsa-state/alsa-state.bb b/meta/recipes-bsp/alsa-state/alsa-state.bb
>>> index bc17b25..83c9faa 100644
>>> --- a/meta/recipes-bsp/alsa-state/alsa-state.bb
>>> +++ b/meta/recipes-bsp/alsa-state/alsa-state.bb
>>> @@ -10,7 +10,7 @@ sound state at system boot and save it at system shut down."
>>>   LICENSE = "MIT"
>>>   LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
>>>   PV = "0.2.0"
>>> -PR = "r0"
>>> +PR = "r2"
>>>
>>>   SRC_URI = "\
>>>     file://asound.conf \
>>> @@ -18,8 +18,6 @@ SRC_URI = "\
>>>     file://alsa-state \
>>>   "
>>>
>>> -RDEPENDS = "alsa-utils-alsactl"
>>> -
>>>   inherit update-rc.d
>>>
>>>   INITSCRIPT_NAME = "alsa-state"
>>> @@ -39,6 +37,7 @@ PACKAGES += "alsa-states"
>>>
>>>   RRECOMMENDS_alsa-state = "alsa-states"
>>>
>>> +RDEPENDS_${PN} = "alsa-utils-alsactl"
>>>   FILES_${PN} = "${sysconfdir}/init.d ${sysconfdir}/asound.conf"
>>>   CONFFILES_${PN} = "${sysconfdir}/asound.conf"
>>>
>>
>> --
>> Joshua Lock
>>         Yocto Project "Johannes factotum"
>>         Intel Open Source Technology Centre
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
Saul Wold - Feb. 2, 2012, 5:57 p.m.
On 01/30/2012 08:49 AM, Koen Kooi wrote:
> Signed-off-by: Koen Kooi<koen@dominion.thruhere.net>
> ---
>   meta/recipes-bsp/alsa-state/alsa-state.bb |    5 ++---
>   1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-bsp/alsa-state/alsa-state.bb b/meta/recipes-bsp/alsa-state/alsa-state.bb
> index bc17b25..83c9faa 100644
> --- a/meta/recipes-bsp/alsa-state/alsa-state.bb
> +++ b/meta/recipes-bsp/alsa-state/alsa-state.bb
> @@ -10,7 +10,7 @@ sound state at system boot and save it at system shut down."
>   LICENSE = "MIT"
>   LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
>   PV = "0.2.0"
> -PR = "r0"
> +PR = "r2"
>
>   SRC_URI = "\
>     file://asound.conf \
> @@ -18,8 +18,6 @@ SRC_URI = "\
>     file://alsa-state \
>   "
>
> -RDEPENDS = "alsa-utils-alsactl"
> -
>   inherit update-rc.d
>
>   INITSCRIPT_NAME = "alsa-state"
> @@ -39,6 +37,7 @@ PACKAGES += "alsa-states"
>
>   RRECOMMENDS_alsa-state = "alsa-states"
>
> +RDEPENDS_${PN} = "alsa-utils-alsactl"
>   FILES_${PN} = "${sysconfdir}/init.d ${sysconfdir}/asound.conf"
>   CONFFILES_${PN} = "${sysconfdir}/asound.conf"
>

Merged this along with the alsa-utils to OE-core

Thanks
	Sau!

Patch

diff --git a/meta/recipes-bsp/alsa-state/alsa-state.bb b/meta/recipes-bsp/alsa-state/alsa-state.bb
index bc17b25..83c9faa 100644
--- a/meta/recipes-bsp/alsa-state/alsa-state.bb
+++ b/meta/recipes-bsp/alsa-state/alsa-state.bb
@@ -10,7 +10,7 @@  sound state at system boot and save it at system shut down."
 LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
 PV = "0.2.0"
-PR = "r0"
+PR = "r2"
 
 SRC_URI = "\
   file://asound.conf \
@@ -18,8 +18,6 @@  SRC_URI = "\
   file://alsa-state \
 "
 
-RDEPENDS = "alsa-utils-alsactl"
-
 inherit update-rc.d
 
 INITSCRIPT_NAME = "alsa-state"
@@ -39,6 +37,7 @@  PACKAGES += "alsa-states"
 
 RRECOMMENDS_alsa-state = "alsa-states"
 
+RDEPENDS_${PN} = "alsa-utils-alsactl"
 FILES_${PN} = "${sysconfdir}/init.d ${sysconfdir}/asound.conf"
 CONFFILES_${PN} = "${sysconfdir}/asound.conf"