| Submitter | Saul Wold |
|---|---|
| Date | Jan. 25, 2012, 7:29 p.m. |
| Message ID | <ae108b14ac3903401a784251e370aef987c99e25.1327519635.git.sgw@linux.intel.com> |
| Download | mbox | patch |
| Permalink | /patch/20153/ |
| State | New |
| Headers | show |
Comments
On Wed, 2012-01-25 at 11:29 -0800, Saul Wold wrote:
> +RDEPENDS = "grep"
Don't you get a QA error for that?
p.
Phil Blundell <philb@gnu.org> writes: > On Wed, 2012-01-25 at 11:29 -0800, Saul Wold wrote: >> +RDEPENDS = "grep" > > Don't you get a QA error for that? > I didn't see any QA warnings when building with yocto (edison branch). I'll resend the patch with some corrections. Here's bitbake output on my machine (with RDEPENDS = "grep"): NOTE: Resolving any missing task queue dependencies NOTE: Preparing runqueue NOTE: Executing SetScene Tasks NOTE: Executing RunQueue Tasks NOTE: Running task 630 of 703 (ID: 4, /home/marc/yocto/poky/meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb, do_fetch) NOTE: package pm-utils-1.4.1-r1: task do_fetch: Started NOTE: package pm-utils-1.4.1-r1: task do_fetch: Succeeded NOTE: Running task 693 of 703 (ID: 0, /home/marc/yocto/poky/meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb, do_unpack) NOTE: package pm-utils-1.4.1-r1: task do_unpack: Started NOTE: package pm-utils-1.4.1-r1: task do_unpack: Succeeded NOTE: Running task 694 of 703 (ID: 1, /home/marc/yocto/poky/meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb, do_patch) NOTE: package pm-utils-1.4.1-r1: task do_patch: Started NOTE: package pm-utils-1.4.1-r1: task do_patch: Succeeded NOTE: Running task 695 of 703 (ID: 6, /home/marc/yocto/poky/meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb, do_configure) NOTE: Running task 696 of 703 (ID: 10, /home/marc/yocto/poky/meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb, do_populate_lic) NOTE: package pm-utils-1.4.1-r1: task do_configure: Started NOTE: package pm-utils-1.4.1-r1: task do_populate_lic: Started NOTE: package pm-utils-1.4.1-r1: task do_populate_lic: Succeeded NOTE: package pm-utils-1.4.1-r1: task do_configure: Succeeded NOTE: Running task 697 of 703 (ID: 7, /home/marc/yocto/poky/meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb, do_compile) NOTE: package pm-utils-1.4.1-r1: task do_compile: Started NOTE: package pm-utils-1.4.1-r1: task do_compile: Succeeded NOTE: Running task 698 of 703 (ID: 2, /home/marc/yocto/poky/meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb, do_install) NOTE: package pm-utils-1.4.1-r1: task do_install: Started NOTE: package pm-utils-1.4.1-r1: task do_install: Succeeded NOTE: Running task 699 of 703 (ID: 9, /home/marc/yocto/poky/meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb, do_package) NOTE: Running task 700 of 703 (ID: 3, /home/marc/yocto/poky/meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb, do_populate_sysroot) NOTE: package pm-utils-1.4.1-r1: task do_populate_sysroot: Started NOTE: package pm-utils-1.4.1-r1: task do_package: Started NOTE: package pm-utils-1.4.1-r1: task do_populate_sysroot: Succeeded NOTE: package pm-utils-1.4.1-r1: task do_package: Succeeded NOTE: Running task 701 of 703 (ID: 11, /home/marc/yocto/poky/meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb, do_package_write_rpm) NOTE: package pm-utils-1.4.1-r1: task do_package_write_rpm: Started NOTE: package pm-utils-1.4.1-r1: task do_package_write_rpm: Succeeded NOTE: Running noexec task 702 of 703 (ID: 8, /home/marc/yocto/poky/meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb, do_package_write) NOTE: Running noexec task 703 of 703 (ID: 5, /home/marc/yocto/poky/meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb, do_build) NOTE: Tasks Summary: Attempted 703 tasks of which 691 didn't need to be rerun and 0 failed. Marc
On Wed, 2012-01-25 at 16:04 -0500, Marc Ferland wrote: > Phil Blundell <philb@gnu.org> writes: > > > On Wed, 2012-01-25 at 11:29 -0800, Saul Wold wrote: > >> +RDEPENDS = "grep" > > > > Don't you get a QA error for that? > > > > I didn't see any QA warnings when building with yocto (edison > branch). I'll resend the patch with some corrections. > > Here's bitbake output on my machine (with RDEPENDS = "grep"): Ah, hm. Does yocto not use recipe_sanity by default? p.
Op 25 jan. 2012 om 20:29 heeft Saul Wold <sgw@linux.intel.com> het volgende geschreven: > From: Marc Ferland <ferlandm@sonatest.com> > > This is needed because the pm-utils functions uses the "-x" > option of grep which is not supported by the busybox grep. > > [YOCTO #1887] > > Written-by: Marc Ferland <ferlandm@sonatest.com> > Signed-off-by: Saul Wold <sgw@linux.intel.com> > --- > meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb b/meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb > index a4ac230..a976c25 100644 > --- a/meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb > +++ b/meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb > @@ -6,12 +6,14 @@ LICENSE="GPLv2" > LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \ > file://src/pm-pmu.c;beginline=1;endline=22;md5=3c1ddbc54e735fb4a0386e14c78a3147" > > -PR = "r0" > +PR = "r1" > > SRC_URI = "http://pm-utils.freedesktop.org/releases/pm-utils-${PV}.tar.gz" > > inherit pkgconfig autotools > > +RDEPENDS = "grep" RDEPENDS_${PN} = "grep" > + > FILES_${PN}-dbg += "${libdir}/pm-utils/bin/.debug \ > ${datadir}/doc/pm-utils/README.debugging" > > -- > 1.7.6.5 > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Patch
diff --git a/meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb b/meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb index a4ac230..a976c25 100644 --- a/meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb +++ b/meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb @@ -6,12 +6,14 @@ LICENSE="GPLv2" LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \ file://src/pm-pmu.c;beginline=1;endline=22;md5=3c1ddbc54e735fb4a0386e14c78a3147" -PR = "r0" +PR = "r1" SRC_URI = "http://pm-utils.freedesktop.org/releases/pm-utils-${PV}.tar.gz" inherit pkgconfig autotools +RDEPENDS = "grep" + FILES_${PN}-dbg += "${libdir}/pm-utils/bin/.debug \ ${datadir}/doc/pm-utils/README.debugging"