Patchwork [2/7] gdb-common: Drop elfutils from DEPENDS

login
register
mail settings
Submitter Khem Raj
Date Jan. 24, 2012, 5:42 p.m.
Message ID <3fb1ade006bc2d93226724eab047b9ecd49e2525.1327426808.git.raj.khem@gmail.com>
Download mbox | patch
Permalink /patch/20081/
State Accepted
Commit 8330205eeb605354c139605618255940e3b312d4
Headers show

Comments

Khem Raj - Jan. 24, 2012, 5:42 p.m.
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-devtools/gdb/gdb-common.inc |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
Richard Purdie - Jan. 25, 2012, 12:32 p.m.
On Tue, 2012-01-24 at 09:42 -0800, Khem Raj wrote:
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-devtools/gdb/gdb-common.inc |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/recipes-devtools/gdb/gdb-common.inc b/meta/recipes-devtools/gdb/gdb-common.inc
> index d728139..930a71b 100644
> --- a/meta/recipes-devtools/gdb/gdb-common.inc
> +++ b/meta/recipes-devtools/gdb/gdb-common.inc
> @@ -2,7 +2,7 @@ DESCRIPTION = "gdb - GNU debugger"
>  HOMEPAGE = "http://www.gnu.org/software/gdb/"
>  LICENSE="GPLv3+"
>  SECTION = "devel"
> -DEPENDS = "ncurses readline elfutils ${LTTNGUST}"
> +DEPENDS = "ncurses readline ${LTTNGUST}"
>  
>  LTTNGUST = "lttng-ust"
>  LTTNGUST_libc-uclibc = ""
> @@ -11,7 +11,7 @@ LTTNGUST_mipsel = ""
>  LTTNGUST_mips64 = ""
>  LTTNGUST_mips64el = ""
>  
> -INC_PR = "r4"
> +INC_PR = "r5"
>  
>  LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \
>  		file://COPYING.LIB;md5=9f604d8a4f8e74f4f5140845a21b6674 \
> @@ -40,7 +40,7 @@ EXPAT = "--without-expat"
>  
>  EXTRA_OECONF = "--disable-gdbtk --disable-tui --disable-x \
>                  --with-curses --disable-multilib --with-system-readline --disable-sim \
> -                ${GDBPROPREFIX} --with-libelf=${STAGING_DIR_TARGET} ${EXPAT} \
> +                ${GDBPROPREFIX} ${EXPAT} \
>                  ${@base_contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)} \
>                 "

very good, but why?

Cheers,

Richard
Khem Raj - Jan. 25, 2012, 2:58 p.m.
On Wed, Jan 25, 2012 at 4:32 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Tue, 2012-01-24 at 09:42 -0800, Khem Raj wrote:
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>>  meta/recipes-devtools/gdb/gdb-common.inc |    6 +++---
>>  1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/meta/recipes-devtools/gdb/gdb-common.inc b/meta/recipes-devtools/gdb/gdb-common.inc
>> index d728139..930a71b 100644
>> --- a/meta/recipes-devtools/gdb/gdb-common.inc
>> +++ b/meta/recipes-devtools/gdb/gdb-common.inc
>> @@ -2,7 +2,7 @@ DESCRIPTION = "gdb - GNU debugger"
>>  HOMEPAGE = "http://www.gnu.org/software/gdb/"
>>  LICENSE="GPLv3+"
>>  SECTION = "devel"
>> -DEPENDS = "ncurses readline elfutils ${LTTNGUST}"
>> +DEPENDS = "ncurses readline ${LTTNGUST}"
>>
>>  LTTNGUST = "lttng-ust"
>>  LTTNGUST_libc-uclibc = ""
>> @@ -11,7 +11,7 @@ LTTNGUST_mipsel = ""
>>  LTTNGUST_mips64 = ""
>>  LTTNGUST_mips64el = ""
>>
>> -INC_PR = "r4"
>> +INC_PR = "r5"
>>
>>  LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \
>>               file://COPYING.LIB;md5=9f604d8a4f8e74f4f5140845a21b6674 \
>> @@ -40,7 +40,7 @@ EXPAT = "--without-expat"
>>
>>  EXTRA_OECONF = "--disable-gdbtk --disable-tui --disable-x \
>>                  --with-curses --disable-multilib --with-system-readline --disable-sim \
>> -                ${GDBPROPREFIX} --with-libelf=${STAGING_DIR_TARGET} ${EXPAT} \
>> +                ${GDBPROPREFIX} ${EXPAT} \
>>                  ${@base_contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)} \
>>                 "
>
> very good, but why?

Nitin added it to overcome a build break in 7.1 there seem to be no other reason
to have it in if 7.3 builds ok without it. Since libelf does not build
with uclibc this was
breaking target gdb builds with uclibc. I could make it conditional
like ust too but it seems to be not needed.

>
> Cheers,
>
> Richard
>
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-devtools/gdb/gdb-common.inc b/meta/recipes-devtools/gdb/gdb-common.inc
index d728139..930a71b 100644
--- a/meta/recipes-devtools/gdb/gdb-common.inc
+++ b/meta/recipes-devtools/gdb/gdb-common.inc
@@ -2,7 +2,7 @@  DESCRIPTION = "gdb - GNU debugger"
 HOMEPAGE = "http://www.gnu.org/software/gdb/"
 LICENSE="GPLv3+"
 SECTION = "devel"
-DEPENDS = "ncurses readline elfutils ${LTTNGUST}"
+DEPENDS = "ncurses readline ${LTTNGUST}"
 
 LTTNGUST = "lttng-ust"
 LTTNGUST_libc-uclibc = ""
@@ -11,7 +11,7 @@  LTTNGUST_mipsel = ""
 LTTNGUST_mips64 = ""
 LTTNGUST_mips64el = ""
 
-INC_PR = "r4"
+INC_PR = "r5"
 
 LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \
 		file://COPYING.LIB;md5=9f604d8a4f8e74f4f5140845a21b6674 \
@@ -40,7 +40,7 @@  EXPAT = "--without-expat"
 
 EXTRA_OECONF = "--disable-gdbtk --disable-tui --disable-x \
                 --with-curses --disable-multilib --with-system-readline --disable-sim \
-                ${GDBPROPREFIX} --with-libelf=${STAGING_DIR_TARGET} ${EXPAT} \
+                ${GDBPROPREFIX} ${EXPAT} \
                 ${@base_contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)} \
                "