From patchwork Thu Jan 19 14:36:03 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [bitbake-devel,1/1] bitbake/runqueue: always log tasks summary Date: Thu, 19 Jan 2012 14:36:03 -0000 From: Paul Eggleton X-Patchwork-Id: 19787 Message-Id: To: bitbake-devel@lists.openembedded.org It's unclear from the history but at some point we stopped logging the "Tasks Summary" NOTE when tasks failed. Reinstate this for failure, and also make the count of attempted tasks include the failed task. Signed-off-by: Paul Eggleton --- bitbake/lib/bb/runqueue.py | 12 +++++++----- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/bitbake/lib/bb/runqueue.py b/bitbake/lib/bb/runqueue.py index 054d36c..be6bbb1 100644 --- a/bitbake/lib/bb/runqueue.py +++ b/bitbake/lib/bb/runqueue.py @@ -959,6 +959,13 @@ class RunQueue: if self.state is runQueueCleanUp: self.rqexe.finish() + if self.state is runQueueComplete or self.state is runQueueFailed: + if self.rqexe.stats.failed: + logger.info("Tasks Summary: Attempted %d tasks of which %d didn't need to be rerun and %d failed.", self.rqexe.stats.completed + self.rqexe.stats.failed, self.rqexe.stats.skipped, self.rqexe.stats.failed) + else: + # Let's avoid the word "failed" if nothing actually did + logger.info("Tasks Summary: Attempted %d tasks of which %d didn't need to be rerun and all succeeded.", self.rqexe.stats.completed, self.rqexe.stats.skipped) + if self.state is runQueueFailed: if not self.rqdata.taskData.tryaltconfigs: raise bb.runqueue.TaskFailure(self.rqexe.failed_fnids) @@ -968,11 +975,6 @@ class RunQueue: if self.state is runQueueComplete: # All done - if self.rqexe.stats.failed: - logger.info("Tasks Summary: Attempted %d tasks of which %d didn't need to be rerun and %d failed.", self.rqexe.stats.completed, self.rqexe.stats.skipped, self.rqexe.stats.failed) - else: - # Let's avoid the word "failed" if nothing actually did - logger.info("Tasks Summary: Attempted %d tasks of which %d didn't need to be rerun and all succeeded.", self.rqexe.stats.completed, self.rqexe.stats.skipped) return False if self.state is runQueueChildProcess: