| Message ID | 20230217124043.341990-1-richard.purdie@linuxfoundation.org |
|---|---|
| State | Accepted, archived |
| Commit | 13279044f16f2cf2502ebf39d277415f99bb6c18 |
| Headers | show |
| Series | cookerdata: Drop dubious exception handling code | expand |
diff --git a/lib/bb/cookerdata.py b/lib/bb/cookerdata.py index 2d52ce4c8f..dc498c205a 100644 --- a/lib/bb/cookerdata.py +++ b/lib/bb/cookerdata.py @@ -294,14 +294,9 @@ class CookerDataBuilder(object): bb.event.fire(bb.event.MultiConfigParsed(mcdata), self.data) self.data_hash = data_hash.hexdigest() - except (SyntaxError, bb.BBHandledException): - raise bb.BBHandledException() except bb.data_smart.ExpansionError as e: logger.error(str(e)) raise bb.BBHandledException() - except Exception: - logger.exception("Error parsing configuration files") - raise bb.BBHandledException() bb.codeparser.update_module_dependencies(self.data)
This code appears to be dangerous, it swallows exceptions, turning them into "handled" versions which then show no errors to the user. This is a pretty poor user experience and I can't see why this code should be swallowing such things. Drop the worst bits of code. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> --- lib/bb/cookerdata.py | 5 ----- 1 file changed, 5 deletions(-)