From patchwork Tue Jan 17 08:32:20 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [CONSOLIDATED, PULL, 35/62] package.bbclass: quote pathname given to objdump Date: Tue, 17 Jan 2012 08:32:20 -0000 From: Saul Wold X-Patchwork-Id: 19561 Message-Id: <37d3cd88ff4d88031f2de3b309aff705c7b92720.1326786990.git.sgw@linux.intel.com> To: openembedded-core@lists.openembedded.org From: Enrico Scholz Packaging will fail with executable files containing spaces in their names. Patch quotes the parameter passed to 'objdump'. Signed-off-by: Enrico Scholz --- meta/classes/package.bbclass | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass index f8f0a12..1088470 100644 --- a/meta/classes/package.bbclass +++ b/meta/classes/package.bbclass @@ -1205,7 +1205,7 @@ SHLIBSDIR = "${STAGING_DIR_HOST}/shlibs" SHLIBSWORKDIR = "${WORKDIR}/shlibs" python package_do_shlibs() { - import re + import re, pipes exclude_shlibs = d.getVar('EXCLUDE_FROM_SHLIBS', 0) if exclude_shlibs: @@ -1234,7 +1234,7 @@ python package_do_shlibs() { lf = bb.utils.lockfile(bb.data.expand("${PACKAGELOCK}", d)) def linux_so(root, path, file): - cmd = d.getVar('OBJDUMP', True) + " -p " + os.path.join(root, file) + " 2>/dev/null" + cmd = d.getVar('OBJDUMP', True) + " -p " + pipes.quote(os.path.join(root, file)) + " 2>/dev/null" cmd = "PATH=\"%s\" %s" % (d.getVar('PATH', True), cmd) fd = os.popen(cmd) lines = fd.readlines()