From patchwork Wed Jan 11 18:30:51 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [bitbake-devel, 4/4] bitbake/runqueue: avoid "failed" in task summary if nothing did Date: Wed, 11 Jan 2012 18:30:51 -0000 From: Paul Eggleton X-Patchwork-Id: 19089 Message-Id: <382b63ffa704ca53d59115cd6777ae90574d141d.1326306561.git.paul.eggleton@linux.intel.com> To: bitbake-devel@lists.openembedded.org Seeing the word "failed" alone without reading the whole context has occasionally triggered an automatic assumption on the part of some users (myself included) that something has gone wrong, even when this message is telling you that "0 [tasks] failed". To avoid this let's just say "all succeeded" in this case instead. As a bonus this means you can now search the output for "fail" and not find anything if all went well. Signed-off-by: Paul Eggleton --- bitbake/lib/bb/runqueue.py | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/bitbake/lib/bb/runqueue.py b/bitbake/lib/bb/runqueue.py index 86744fb..054d36c 100644 --- a/bitbake/lib/bb/runqueue.py +++ b/bitbake/lib/bb/runqueue.py @@ -968,7 +968,11 @@ class RunQueue: if self.state is runQueueComplete: # All done - logger.info("Tasks Summary: Attempted %d tasks of which %d didn't need to be rerun and %d failed.", self.rqexe.stats.completed, self.rqexe.stats.skipped, self.rqexe.stats.failed) + if self.rqexe.stats.failed: + logger.info("Tasks Summary: Attempted %d tasks of which %d didn't need to be rerun and %d failed.", self.rqexe.stats.completed, self.rqexe.stats.skipped, self.rqexe.stats.failed) + else: + # Let's avoid the word "failed" if nothing actually did + logger.info("Tasks Summary: Attempted %d tasks of which %d didn't need to be rerun and all succeeded.", self.rqexe.stats.completed, self.rqexe.stats.skipped) return False if self.state is runQueueChildProcess: