Patchwork Add grep to RDEPENDS to avoid command failures.

login
register
mail settings
Submitter Marc Ferland
Date Jan. 10, 2012, 8:22 p.m.
Message ID <1326226959-21371-1-git-send-email-ferlandm@sonatest.com>
Download mbox | patch
Permalink /patch/18969/
State New
Headers show

Comments

Marc Ferland - Jan. 10, 2012, 8:22 p.m.
Fixes [YOCTO #1887]

Signed-off-by: Marc Ferland <ferlandm@sonatest.com>
---
 meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
Phil Blundell - Jan. 10, 2012, 8:24 p.m.
On Tue, 2012-01-10 at 15:22 -0500, Marc Ferland wrote:
> -PR = "r0"
> +PR = "r1"
> +RDEPENDS = "grep"

Do you not get a QA warning for that?  Usually it would be RDEPENDS_${PN}.

p.
Otavio Salvador - Jan. 10, 2012, 8:39 p.m.
On Tue, Jan 10, 2012 at 18:22, Marc Ferland <ferlandm@sonatest.com> wrote:

> ...

+PR = "r1"
> +RDEPENDS = "grep"
>

Busybox ought to provide it; what is missing?
Otavio Salvador - Jan. 10, 2012, 9:25 p.m.
On Tue, Jan 10, 2012 at 19:14, Marc Ferland <ferlandm@sonatest.com> wrote:

> I was having trouble running the pm-suspend command. See:
> http://bugzilla.pokylinux.org/show_bug.cgi?id=1887
>
> Basically the '-x' option is missing from busybox's grep.


Can't pm-suspend be patched to avoid using the -x option? Maybe making the
regexp more strict, for example?

Patch

diff --git a/meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb b/meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb
index a4ac230..5e09f7b 100644
--- a/meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb
+++ b/meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb
@@ -1,12 +1,13 @@ 
 SECTION = "base"
 SUMMARY = "Utilities and scripts for power management"
-DESCRIPTION = "Simple shell command line toos to suspect and hibernate."
+DESCRIPTION = "Simple shell command line tools to suspend and hibernate."
 HOMEPAGE = "http://pm-utils.freedesktop.org/wiki/"
 LICENSE="GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \
                     file://src/pm-pmu.c;beginline=1;endline=22;md5=3c1ddbc54e735fb4a0386e14c78a3147"
 
-PR = "r0"
+PR = "r1"
+RDEPENDS = "grep"
 
 SRC_URI = "http://pm-utils.freedesktop.org/releases/pm-utils-${PV}.tar.gz"