Patchwork [3/3] task-base: add alsa-state to task-base-alsa

login
register
mail settings
Submitter Joshua Lock
Date Jan. 10, 2012, 5:39 p.m.
Message ID <35eca064e6310d94b517b481beef5f5a5a3f395b.1326216024.git.josh@linux.intel.com>
Download mbox | patch
Permalink /patch/18961/
State New
Headers show

Comments

Joshua Lock - Jan. 10, 2012, 5:39 p.m.
This enables automatic configuration setting and restoration on systems
with alsa.

Signed-off-by: Joshua Lock <josh@linux.intel.com>
---
 meta/recipes-core/tasks/task-base.bb |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
Darren Hart - Jan. 12, 2012, 4:23 p.m.
On 01/10/2012 09:39 AM, Joshua Lock wrote:
> This enables automatic configuration setting and restoration on systems
> with alsa.
> 
> Signed-off-by: Joshua Lock <josh@linux.intel.com>

Acked-by: Darren Hart <dvhart@linux.intel.com>

> ---
>  meta/recipes-core/tasks/task-base.bb |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-core/tasks/task-base.bb b/meta/recipes-core/tasks/task-base.bb
> index e0960b5..7460be4 100644
> --- a/meta/recipes-core/tasks/task-base.bb
> +++ b/meta/recipes-core/tasks/task-base.bb
> @@ -2,7 +2,7 @@ DESCRIPTION = "Merge machine and distro options to create a basic machine task/p
>  LICENSE = "MIT"
>  LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
>                      file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
> -PR = "r72"
> +PR = "r73"
>  
>  inherit task
>  
> @@ -183,7 +183,8 @@ RRECOMMENDS_task-base-vfat = "\
>  
>  RDEPENDS_task-base-alsa = "\
>      alsa-utils-alsactl \
> -    alsa-utils-alsamixer"
> +    alsa-utils-alsamixer \
> +    alsa-state"
>  
>  RRECOMMENDS_task-base-alsa = "\
>      kernel-module-snd-mixer-oss \
Martin Jansa - Jan. 12, 2012, 4:31 p.m.
On Thu, Jan 12, 2012 at 08:23:16AM -0800, Darren Hart wrote:
> 
> 
> On 01/10/2012 09:39 AM, Joshua Lock wrote:
> > This enables automatic configuration setting and restoration on systems
> > with alsa.
> > 
> > Signed-off-by: Joshua Lock <josh@linux.intel.com>
> 
> Acked-by: Darren Hart <dvhart@linux.intel.com>

can we use VIRTUAL_RUNTIME for this, please?

for example in SHR we have alsa-state provided by fsoaudiod

Cheers,

> 
> > ---
> >  meta/recipes-core/tasks/task-base.bb |    5 +++--
> >  1 files changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/meta/recipes-core/tasks/task-base.bb b/meta/recipes-core/tasks/task-base.bb
> > index e0960b5..7460be4 100644
> > --- a/meta/recipes-core/tasks/task-base.bb
> > +++ b/meta/recipes-core/tasks/task-base.bb
> > @@ -2,7 +2,7 @@ DESCRIPTION = "Merge machine and distro options to create a basic machine task/p
> >  LICENSE = "MIT"
> >  LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
> >                      file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
> > -PR = "r72"
> > +PR = "r73"
> >  
> >  inherit task
> >  
> > @@ -183,7 +183,8 @@ RRECOMMENDS_task-base-vfat = "\
> >  
> >  RDEPENDS_task-base-alsa = "\
> >      alsa-utils-alsactl \
> > -    alsa-utils-alsamixer"
> > +    alsa-utils-alsamixer \
> > +    alsa-state"
> >  
> >  RRECOMMENDS_task-base-alsa = "\
> >      kernel-module-snd-mixer-oss \
> 
> -- 
> Darren Hart
> Intel Open Source Technology Center
> Yocto Project - Linux Kernel
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Joshua Lock - Jan. 13, 2012, 6:54 p.m.
On 12/01/12 08:31, Martin Jansa wrote:
> On Thu, Jan 12, 2012 at 08:23:16AM -0800, Darren Hart wrote:
>>
>>
>> On 01/10/2012 09:39 AM, Joshua Lock wrote:
>>> This enables automatic configuration setting and restoration on systems
>>> with alsa.
>>>
>>> Signed-off-by: Joshua Lock<josh@linux.intel.com>
>>
>> Acked-by: Darren Hart<dvhart@linux.intel.com>
>
> can we use VIRTUAL_RUNTIME for this, please?
>
> for example in SHR we have alsa-state provided by fsoaudiod

That's a fine idea. VIRTUAL-RUNTIME_alsa-state?

I'm testing a patch for it now.

Cheers,
Joshua
Martin Jansa - Jan. 13, 2012, 6:58 p.m.
On Fri, Jan 13, 2012 at 10:54:38AM -0800, Joshua Lock wrote:
> 
> 
> On 12/01/12 08:31, Martin Jansa wrote:
> > On Thu, Jan 12, 2012 at 08:23:16AM -0800, Darren Hart wrote:
> >>
> >>
> >> On 01/10/2012 09:39 AM, Joshua Lock wrote:
> >>> This enables automatic configuration setting and restoration on systems
> >>> with alsa.
> >>>
> >>> Signed-off-by: Joshua Lock<josh@linux.intel.com>
> >>
> >> Acked-by: Darren Hart<dvhart@linux.intel.com>
> >
> > can we use VIRTUAL_RUNTIME for this, please?
> >
> > for example in SHR we have alsa-state provided by fsoaudiod
> 
> That's a fine idea. VIRTUAL-RUNTIME_alsa-state?

good for me.

> I'm testing a patch for it now.

Thanks!

> 
> Cheers,
> Joshua
> -- 
> Joshua Lock
>          Yocto Project "Johannes factotum"
>          Intel Open Source Technology Centre
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-core/tasks/task-base.bb b/meta/recipes-core/tasks/task-base.bb
index e0960b5..7460be4 100644
--- a/meta/recipes-core/tasks/task-base.bb
+++ b/meta/recipes-core/tasks/task-base.bb
@@ -2,7 +2,7 @@  DESCRIPTION = "Merge machine and distro options to create a basic machine task/p
 LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
                     file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
-PR = "r72"
+PR = "r73"
 
 inherit task
 
@@ -183,7 +183,8 @@  RRECOMMENDS_task-base-vfat = "\
 
 RDEPENDS_task-base-alsa = "\
     alsa-utils-alsactl \
-    alsa-utils-alsamixer"
+    alsa-utils-alsamixer \
+    alsa-state"
 
 RRECOMMENDS_task-base-alsa = "\
     kernel-module-snd-mixer-oss \